Firebird

Hello:

> Afaik, the behaviour is still right, but performance is about 20% better.

The only problem with that will be with the amount of memory used by the 
charsets if we do that in tha way.

As it's now there will be Encoding instances on ly in the charsets that 
are being used, while if we do it in the ctor there will be Encoding 
instances for all charsets.

This could be a problem wehen working with the compact framework.

Maybe i can try to do the change (for the 2.1.0 sources) using 
conditional code ....

Carlos,

AFAIK you don't create more objects. Is exactly the same, the difference is 
that instead of making thousands of calls to GetEncoding , and going several 
times through the switch statement, you just do it once... We didn't detect 
a hit on memory consumption (I will double check), but peformance hit is 
great!


==========
The only problem with that will be with the amount of memory used by the
charsets if we do that in tha way.

As it's now there will be Encoding instances on ly in the charsets that
are being used, while if we do it in the ctor there will be Encoding
instances for all charsets.

This could be a problem wehen working with the compact framework.

Maybe i can try to do the change (for the 2.1.0 sources) using
conditional code ....

----- Original Message ----- 
From: "pablosantosluac" <pablosantosluac@...>
To: "Carlos Guzmán Álvarez" <carlosga05@...>
Cc: "For users and developers of the Firebird .NET providers" 
<firebird-net-provider@...>
Sent: Monday, April 16, 2007 12:59 PM
Subject: [Firebird-net-provider] Big performance gain on Charset.cs


> Hi all,
>
> We are heavily relying on Firebird for our version control product, 
> Plastic
> SCM, and we have just found a big performance boost making a small change 
> on
> Charset.cs.
>
> On our tests we have reduced overall time around 20% just changing the
> following on Charset.cs, so we thought you might be interested:
>
> instead of making the following switch statement each time a GetBytes was
> invoked:
> switch (this.systemName)
>
> {
>
> case "NONE":
>
> mEncoding = Encoding.Default;
>
> break;
>
> case "OCTETS":
>
> mEncoding = new BinaryEncoding();
>
> break;
>
> default:
>
> mEncoding = Encoding.GetEncoding(this.systemName);
>
> break;
>
> }
>
>
>
> We have moved it to the constructor and created a member variable
> (mEncoding) to create the right one.
>
> Afaik, the behaviour is still right, but performance is about 20% better.
>
>
>
> Cheers,
>
>
>
> pablo
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Firebird-net-provider mailing list
> Firebird-net-provider@...
> https://lists.sourceforge.net/lists/listinfo/firebird-net-provider

> AFAIK you don't create more objects. Is exactly the same, the difference
> is that instead of making thousands of calls to GetEncoding , and going
> several times through the switch statement, you just do it once... We
> didn't detect a hit on memory consumption (I will double check), but
> peformance hit is great!

I'm not sure about the CF, but in the normal framework, once you create an
Encoding object, it is cached in a hashtable anyway (that's what it does
looking at Encoding.GetEncoding in Reflector). So every call to
Encoding.GetEncoding with the same codepage will get the exact same instance
anyway.

So, at least for the normal framework, doing it once in the constructor is
the same as doing it each time it is used (in terms of the behavior).

Dean.

Hi all!
I want to get Exception Message without Exception Name and line

Ex:
"CUSTOMER_DUPLI_CODE\r\nDuplicate code\r\nAt procedure 'CUSTOMER_IU' line:
50, col: 9"
--> 
I want: "Duplicate Code"

Hello:

> So, at least for the normal framework, doing it once in the constructor is
> the same as doing it each time it is used (in terms of the behavior).

I can try to check it in the changelog but if i remember well, that 
change was done time ago on a user request for that reason ( i maybe 
wrong ;) )

Well, we have run our internal tests, and also the profiler, and changing 
this code gains 20%, so it doesn't seem to be doing exactly the same. The 
"old" code running through the switch several times, and creating an 
encoding object thousands of times too.

Our tests run our Plastic SCM system for about 20 minutes, and 20% was lost 
there.

pablo


----- Original Message ----- 
From: "Dean Harding" <dean.harding@...>
To: "'For users and developers of the Firebird .NET providers'" 
<firebird-net-provider@...>; "'Carlos Guzmán Álvarez'" 
<carlosga05@...>
Sent: Tuesday, April 17, 2007 1:38 AM
Subject: Re: [Firebird-net-provider] Big performance gain on Charset.cs


>> AFAIK you don't create more objects. Is exactly the same, the difference
>> is that instead of making thousands of calls to GetEncoding , and going
>> several times through the switch statement, you just do it once... We
>> didn't detect a hit on memory consumption (I will double check), but
>> peformance hit is great!
>
> I'm not sure about the CF, but in the normal framework, once you create an
> Encoding object, it is cached in a hashtable anyway (that's what it does
> looking at Encoding.GetEncoding in Reflector). So every call to
> Encoding.GetEncoding with the same codepage will get the exact same 
> instance
> anyway.
>
> So, at least for the normal framework, doing it once in the constructor is
> the same as doing it each time it is used (in terms of the behavior).
>
> Dean.
>
>
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Firebird-net-provider mailing list
> Firebird-net-provider@...
> https://lists.sourceforge.net/lists/listinfo/firebird-net-provider

Pham Huu Le Quoc Phuc wrote:
> Hi all!
> I want to get Exception Message without Exception Name and line
> 
> Ex:
> "CUSTOMER_DUPLI_CODE\r\nDuplicate code\r\nAt procedure 'CUSTOMER_IU' line:
> 50, col: 9"
> --> 
> I want: "Duplicate Code"

And where/how you're handling/logging exceptions?


-- 
Jiri {x2} Cincura
http://blog.vyvojar.cz/jirka/ | http://www.ID3renamer.com

> Well, we have run our internal tests, and also the profiler, and changing
> this code gains 20%, so it doesn't seem to be doing exactly the same. The
> "old" code running through the switch several times, and creating an
> encoding object thousands of times too.

Well, I meant the same in terms of actual functionality. The code in
Encoding.GetEncoding caches the return value so when you call it again with
the same name, it returns the same instance as before.

The speed-up you get is from not having to convert from the string name to
an integer codepage and doing a hashtable lookup (basically what
Encoding.GetEncoding does internall). Depending on the number of times that
gets done, the speedup could be significant.

Dean.

In Sp, I throw an exception

WHEN any DO
     exception CUSTOMER_DUPLI_CODE 'Duplicate Code';

and write try catch at code(C#)


-----Original Message-----
From: firebird-net-provider-bounces@...
[mailto:firebird-net-provider-bounces@...] On Behalf Of
Jiri Cincura
Sent: Tuesday, April 17, 2007 20:44 PM
To: For users and developers of the Firebird .NET providers
Subject: Re: [Firebird-net-provider] How to get exception message without
Exception Name and line code

Pham Huu Le Quoc Phuc wrote:
> Hi all!
> I want to get Exception Message without Exception Name and line
> 
> Ex:
> "CUSTOMER_DUPLI_CODE\r\nDuplicate code\r\nAt procedure 'CUSTOMER_IU' line:
> 50, col: 9"
> --> 
> I want: "Duplicate Code"

And where/how you're handling/logging exceptions?


-- 
Jiri {x2} Cincura
http://blog.vyvojar.cz/jirka/ | http://www.ID3renamer.com

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Firebird-net-provider mailing list
Firebird-net-provider@...
https://lists.sourceforge.net/lists/listinfo/firebird-net-provider

Hello:

> Well, we have run our internal tests, and also the profiler, and changing =
> this code gains 20%, so it doesn't seem to be doing exactly the same. The =
> "old" code running through the switch several times, and creating an =
> encoding object thousands of times too.
> Our tests run our Plastic SCM system for about 20 minutes, and 20% was lost =
> there.

I will try to do the change, using conditional code, to maintain the 
actual way of handling the Encoding on .net compact framework.

Pham Huu Le Quoc Phuc wrote:
> In Sp, I throw an exception
> 
> WHEN any DO
>      exception CUSTOMER_DUPLI_CODE 'Duplicate Code';
> 
> and write try catch at code(C#)

In try-catch block you have to catch FbException. And in Message 
property you have text from server, where among other things also the 
exception message is.

-- 
Jiri {x2} Cincura
http://blog.vyvojar.cz/jirka/ | http://www.ID3renamer.com

chao ban
minh ten duc
o tphcm
minh cung dang su dung firebird lam app
nhung ma sao co luc tao connect duoc, co luc khong duoc
minh dung c# 2003
Ban co doan ket noi nao lam vi du, cho minh voi duoc kkhong
thanks

Hello:
> AFAIK you don't create more objects. Is exactly the same, the 
> difference is that instead of making thousands of calls to GetEncoding 
> , and going several times through the switch statement, you just do it 
> once... We didn't detect a hit on memory consumption (I will double 
> check), but peformance hit is great!
I have committed a change on Charset.cs to the 2.1.0 sources

-- 
Carlos Guzmán Álvarez
Vigo-Spain

http://carlosga.wordpress.com