Webware for Python

On Sat, 2003-03-01 at 20:43, Randall Randall wrote:
> Is there a 'normal' way to restart the AppServer from within
> a page?  Calling self.application().server().restart() doesn't
> seem to do it (though it does prevent the page from actually
> being served).

I think you should call shouldRestart() instead of restart() -- only the
main thread can initiate the restart, and shouldRestart() asks it to do
so.

  Ian

On Saturday 01 March 2003 22:12, Ian Bicking wrote:
> On Sat, 2003-03-01 at 20:43, Randall Randall wrote:
> > Is there a 'normal' way to restart the AppServer from within
> > a page?  Calling self.application().server().restart() doesn't
> > seem to do it (though it does prevent the page from actually
> > being served).
>
> I think you should call shouldRestart() instead of restart() -- only the
> main thread can initiate the restart, and shouldRestart() asks it to do
> so.

Hmm, I suggest renaming the current restart() to _restart() and replacing the 
public method with something like this instead:

    def restart(self):
        """Tell the main thread to restart the server."""
        self._shouldRestart = True

This was the naming scheme I used in the original code that WebKit 0.8's 
version was based on.  I'm not sure why this was renamed.  
self._shouldRestart was meant to be a private implementation detail.

Ian Bicking wrote:

>On Sat, 2003-03-01 at 20:43, Randall Randall wrote:
>  
>
>>Is there a 'normal' way to restart the AppServer from within
>>a page?  Calling self.application().server().restart() doesn't
>>seem to do it (though it does prevent the page from actually
>>being served).
>>    
>>
>
>I think you should call shouldRestart() instead of restart() -- only the
>main thread can initiate the restart, and shouldRestart() asks it to do
>so.
>
>  Ian
>  
>
I recall a discussion suggesting that the Auto Reloading app server 
should get rolled into AppServer.
We should consider this functionality at that time, if not before.  I 
think the terminology here is confusing.  I just ran into it myself. 
 "restart()" sounds like a command.  "shouldRestart()" could easily be 
interpreted as a question.

On Sun, 2003-03-02 at 00:35, Tavis Rudd wrote:
> Hmm, I suggest renaming the current restart() to _restart() and replacing the 
> public method with something like this instead:
> 
>     def restart(self):
>         """Tell the main thread to restart the server."""
>         self._shouldRestart = True

Those names sound good to me.

  Ian

Ian Bicking wrote:
> On Sat, 2003-03-01 at 20:43, Randall Randall wrote:
> 
>>Is there a 'normal' way to restart the AppServer from within
>>a page?  Calling self.application().server().restart() doesn't
>>seem to do it (though it does prevent the page from actually
>>being served).
> 
> 
> I think you should call shouldRestart() instead of restart() -- only the
> main thread can initiate the restart, and shouldRestart() asks it to do
> so.

Great!  This is exactly what I was looking for.

Thanks!

-- 
Randall Randall <randall@...>
'Institute regime change everywhere...
 to "None of the above."' -- Alex Future Bokov