> -----Original Message-----
> From: Kristian Van Der Vliet [mailto:vanders@...]
> Sent: den 27 december 2003 11:42
> To: syllable-developer@...
> Subject: Re: [Syllable-developer] Checkbox
> > In my research for making a treeviewchecknode, I found a
> function in
> > CheckBox that is commented out! It says that it will break binary
> > compatibility, but since this is 0.5 series, why don't we
> enable that
> > function. The name is CheckBox::KeyDown()
> Sounds fine with me, we've already broken libsyllable since
> 0.5.1 (So 0.5.2 will have libsyllable.so.2) Please ensure
> you test it thouroughly.
> I've just looked & CheckBox has no "spare" virtual methods at
> all, so this would be the time to add some reserved virtual's
> for future use. There is also this comment in CheckBox::Paint()
> // For this to work, we need the FocusChanged callback =>
> breaking binary compatibilty
> Henrik, any idea?
I think I wrote that... :o)
Anyway, that has to be wrong... There is no FocusChanged callback, and it
should work just fine anyway.
The comment above KeyDown should be correct though. I'm saying "should"
because I don't know how these vtables are inherited, ie. if it really does
break binary compatibility to override a virtual method in the base class...
(I mean we're not adding a new virtual, we're just overriding the old one,
so there should already be a vtable entry for it, right?)
Either way, it's ok to uncomment that piece of code now. :o)