Small Device C Compiler suite

On Tue, 16 Mar 2004 michaelh@... wrote:

> NO!
> 
> Or, to quote Ethan:
> NO NO NO NO NO NO!
> 
> I don't shout often, but please do not do an automated re-format of the code. 
> It completly breaks the CVS history, merging, and is just plain unnessercary. 
> Certian people have done this to sdcc before and it caused a world of hurt for
> no benefit.
> 
> Always follow, in spirit at least, the coding style of any pre-existing code. 
> sdcc's may be ugly but at least it is a standard.

Hi Michael,

Since there's no context in your message, it's not clear to whom this
shout should be directed (but since I started this thread, I'll go ahead
and respond :). I don't think anyone wants to arbitrarily reformat the
code (even though arbitrary formatting is what's crept in over time). The
last time someone did this it screwed up a bunch of stuff. I did suggest
introducing a 'make indent' option as a method of fixing the adhoc (or
defacto sdcc standard) style that's currently used. One obviously must use
this feature judiciously, perhaps during the code freeze phase just before
a release.

The only reason I'm even bothering to bring up this issue is I noticed 
that someone has (arbitrarily) re-formatted the pic14 port. A little 
digging around in the src directory also indicates a random scattering of 
tabs and differing amounts of indentation. Sure it's a matter of 
esthetics, but to be quite frank it's sloppy and unprofessional.

But, to get back to my original question which prompted this thread - I
thought a couple of years ago we had said not to use tabs; is this true or 
not? If not then that's fine. In which case, I'll let my editor work it's 
magic in the areas I touch. If so, then I'll create an SDCC-C mode for 
emacs and use it. I don't really care to debate the esthetics of 2,4, or 8 
tabs - I really only care about consistancy. Bernhard has taken steps to 
say that SDCC should adhere to the "gnu style". Unfortunately, that style 
says nothing about tabs...

Regards,
Scott

Scott Dattalo schrieb:

>On Tue, 16 Mar 2004 michaelh@... wrote:
>  
>
>But, to get back to my original question which prompted this thread - I
>thought a couple of years ago we had said not to use tabs; is this true or 
>not? If not then that's fine. In which case, I'll let my editor work it's 
>magic in the areas I touch. If so, then I'll create an SDCC-C mode for 
>emacs and use it. I don't really care to debate the esthetics of 2,4, or 8 
>tabs - I really only care about consistancy. Bernhard has taken steps to 
>say that SDCC should adhere to the "gnu style". Unfortunately, that style 
>says nothing about tabs...
>  
>
Hm.... Since GNU suggests indents of 2 character positions, and I guess 
nobody has set his tabsize to "2",
tabs should be avoided. Whatever you do, please don't mix tabs and 
spaces to indent.

>Regards,
>Scott
>
>
>
>-------------------------------------------------------
>This SF.Net email is sponsored by: IBM Linux Tutorials
>Free Linux tutorial presented by Daniel Robbins, President and CEO of
>GenToo technologies. Learn everything from fundamentals to system
>administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
>_______________________________________________
>sdcc-devel mailing list
>sdcc-devel@...
>https://lists.sourceforge.net/lists/listinfo/sdcc-devel
>
>  
>
Regards Hans

On Tue, 16 Mar 2004, Hans J=FCrgen Dorn wrote:

> Scott Dattalo schrieb:
>=20
> >On Tue, 16 Mar 2004 michaelh@... wrote:
> > =20
> >But, to get back to my original question which prompted this thread - I
> >thought a couple of years ago we had said not to use tabs; is this true =
or=20
> >not? If not then that's fine. In which case, I'll let my editor work it'=
s=20
> >magic in the areas I touch. If so, then I'll create an SDCC-C mode for=
=20
> >emacs and use it. I don't really care to debate the esthetics of 2,4, or=
 8=20
> >tabs - I really only care about consistancy. Bernhard has taken steps to=
=20
> >say that SDCC should adhere to the "gnu style". Unfortunately, that styl=
e=20
> >says nothing about tabs...
> >
> Hm.... Since GNU suggests indents of 2 character positions, and I guess=
=20
> nobody has set his tabsize to "2",
> tabs should be avoided. Whatever you do, please don't mix tabs and=20
> spaces to indent.

Setting the tabsize to 2 would be very bad, since the majority of SDCC
source already has mixed tabs and spaces (with the assumption of a tabsize
of 8). My preference is to purely use spaces; it is much easier to change
the indentation.

There is quite a bit of existing SDCC source that does not follow GNU
style. The most noticable deviation is the brace placement. Although
frequent code reformatting would be certainly be bad (especially if
committed along with a functional change), I would not mind a one-time
style clean-up; it has never caused a problem for me when researching a
source file's ancestry.

  Erik

On Tue, 16 Mar 2004, Erik Petrich wrote:

> Setting the tabsize to 2 would be very bad, since the majority of SDCC
> source already has mixed tabs and spaces (with the assumption of a tabsize
> of 8). My preference is to purely use spaces; it is much easier to change
> the indentation.

I agree that setting the tabsize to 2 is a bad thing. And that was the 
tab size when the PIC port was recently formatted. I agree that tabs 
should not be used. Since there isn't a resounding consensus, I'll change 
those portions of the pic14 port that I touch to: NO tabs, and to 
indentation levels of 2 spaces.

Scott