Spring Framework

[ http://opensource.atlassian.com/projects/spring/browse/RCP-408?page=comments#action_19862 ] 

Geoffrey De Smet commented on RCP-408:
--------------------------------------

It seems the "ok" button is considered the "cancel" button?

    protected String getCancelCommandId() {
        return OK_FACE_DESCRIPTOR_ID;
    }


    protected final boolean onFinish() {
        // final because it can never get called
        return true;
    }


Seems like a message dialog is canceled instead of finished.

> MessageDialog's ok button should be the default button (enter key should press it)
> ----------------------------------------------------------------------------------
>
>          Key: RCP-408
>          URL: http://opensource.atlassian.com/projects/spring/browse/RCP-408
>      Project: Spring Framework Rich Client Project
>         Type: Bug

>   Components: Dialog System
>     Versions: 0.2.1
>     Reporter: Geoffrey De Smet
>     Assignee: Geoffrey De Smet
>     Priority: Minor
>      Fix For: 0.3.0

>
> Now it's not the default button, so when a login succeeds, you have to press escape (instead of enter) to press it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/spring/browse/RCP-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_25056 ] 

Yudhi Widyatama commented on RCP-408:
-------------------------------------

It is strange that MessageDialog chooses to make the Cancel button the default button. Even when we don't do this (by commenting getCancelCommandId, getCommandGroupMembers, and registerDefaultCommand in MessageDialog.class) the enter button still does nothing when the dialog first popped up. I think its about the focus, I need to press tab several times before I could close the dialog using enter key.
So I tried to make the message area unfocusable. Added  messageArea.setFocusable(false) in AlertMessageArea.init(Messagable), and now we could press enter key to 'OK' a MessageDialog.

> MessageDialog's ok button should be the default button (enter key should press it)
> ----------------------------------------------------------------------------------
>
>                 Key: RCP-408
>                 URL: http://opensource.atlassian.com/projects/spring/browse/RCP-408
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>          Components: Dialog System
>    Affects Versions: 0.2.1
>            Reporter: Geoffrey De Smet
>            Priority: Minor
>             Fix For: 0.3.0
>
>
> Now it's not the default button, so when a login succeeds, you have to press escape (instead of enter) to press it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/spring/browse/RCP-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yudhi Widyatama updated RCP-408:
--------------------------------

    Attachment: RCP-408.patch

makes the messagearea in AlertMessageAreaPane unfocusable. I think this solves RCP-408.

> MessageDialog's ok button should be the default button (enter key should press it)
> ----------------------------------------------------------------------------------
>
>                 Key: RCP-408
>                 URL: http://opensource.atlassian.com/projects/spring/browse/RCP-408
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>          Components: Dialog System
>    Affects Versions: 0.2.1
>            Reporter: Geoffrey De Smet
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: RCP-408.patch
>
>
> Now it's not the default button, so when a login succeeds, you have to press escape (instead of enter) to press it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/spring/browse/RCP-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Stembridge resolved RCP-408.
----------------------------------

    Resolution: Fixed

Patch applied. Thanks very much Yudhi.

The reason that the OK button was not being set as the default was because the message dialog uses an underlying JTextPane, which will 'hijack' the ENTER key. 

See this JRootPane javadoc:
http://java.sun.com/j2se/1.4.2/docs/api/javax/swing/JRootPane.html#setDefaultButton(javax.swing.JButton)



> MessageDialog's ok button should be the default button (enter key should press it)
> ----------------------------------------------------------------------------------
>
>                 Key: RCP-408
>                 URL: http://opensource.atlassian.com/projects/spring/browse/RCP-408
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>          Components: Dialog System
>    Affects Versions: 0.2.1
>            Reporter: Geoffrey De Smet
>            Assignee: Kevin Stembridge
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: RCP-408.patch
>
>
> Now it's not the default button, so when a login succeeds, you have to press escape (instead of enter) to press it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira