SQLObject

On Fri, May 27, 2005 at 04:03:53PM -0400, Kevin Dangoor wrote:
> Attached is the svn diff for my pysqlite2 changes.

   Thank you! I'll look at it and run tests later. Monday or Tuesday,
perhaps..

Oleg.
-- 
     Oleg Broytmann            http://phd.pp.ru/            phd@...
           Programmers don't die, they just GOSUB without RETURN.

Hello!

On Fri, May 27, 2005 at 04:03:53PM -0400, Kevin Dangoor wrote:
> - if you're using UnicodeCols with an encoding other than UTF-8,
> you're not going to want to use pysqlite2 as it stands now.

   I see "UTF-8" here, but "ascii" in the code:

class ASCIIStringValidator(validators.Validator):

    def fromPython(self, value, state):
        if value is None:
            return None
        if isinstance(value, str):
            return value
        if isinstance(value, unicode):
            return value.encode("ascii")
        return value

    def toPython(self, value, state):
        if value is None:
            return None
        if isinstance(value, unicode):
           return value.encode("ascii")
        return value

   Why "ascii"? IMO it must be either UTF-8 or configured by the user.

Oleg.
-- 
     Oleg Broytmann            http://phd.pp.ru/            phd@...
           Programmers don't die, they just GOSUB without RETURN.

On 6/1/05, Oleg Broytmann <phd@...> wrote:
[asciistringvalidator snipped]

>     def toPython(self, value, state):
>         if value is None:
>             return None
>         if isinstance(value, unicode):
>            return value.encode("ascii")
>         return value
>=20
>    Why "ascii"? IMO it must be either UTF-8 or configured by the user.

I had thought that StringCol was defined as being ASCII. What you're
saying makes sense, though. You'd think a String should be encoded in
whatever encoding the user uses. Sure, give that a try.

Kevin

On Wed, Jun 01, 2005 at 01:36:36PM -0400, Kevin Dangoor wrote:
> On 6/1/05, Oleg Broytmann <phd@...> wrote:
> [asciistringvalidator snipped]
> 
> >     def toPython(self, value, state):
> >         if value is None:
> >             return None
> >         if isinstance(value, unicode):
> >            return value.encode("ascii")
> >         return value
> > 
> >    Why "ascii"? IMO it must be either UTF-8 or configured by the user.
> 
> I had thought that StringCol was defined as being ASCII. What you're

   No, it stores Python 8-bit strings that don't have an attached
semantic/encoding. If you do
   result = unicode("some Russian Cyriliic string", "koi8-r").encode("UTF-8")
you cannot ask the result what encoding it has. It doesn't know. It's a
programmer who must know the encoding.

> saying makes sense, though. You'd think a String should be encoded in
> whatever encoding the user uses. Sure, give that a try.

Oleg.
-- 
     Oleg Broytmann            http://phd.pp.ru/            phd@...
           Programmers don't die, they just GOSUB without RETURN.

Hello!

On Fri, May 27, 2005 at 04:03:53PM -0400, Kevin Dangoor wrote:
> Attached is the svn diff for my pysqlite2 changes.

   Well, I just committed my current work on it - revision 815. I have
ran a lot of tests with SQLite 3.2.1 and Postgres 7.2, and the status is:

Python 2.2 AND (pysqlite1 OR psycopg):
   Most tests passed; some failed due to the very py.test
   (re)introduced incompatibility with Python 2.2.

Python 2.3 AND (pysqlite1 OR psycopg):
   Most tests passed; some failed due to known problems in Pg 7.2.

Python 2.4 AND (pysqlite2 OR psycopg):
   Most tests passed; some failed due to known problems in Pg 7.2.
   Some tests failed due to problems with PySQLite2.

   test_basic.py and test_delete.py failed with error "OperationalError:
database table is locked".

   test_validation.py failed with the error

    def confirmSubclass(self, value, state):
        if not isinstance(value, self.subclass):
            raise InvalidField(self.message('subclass', "%(object)s is not a subclass of %(subclass)s")
                               % {'object': repr(value),
                                  'subclass': self.subclass},
E                              value, state)
>           InvalidField: u'y' is not a subclass of <type 'str'>. Value: u'y'

   It seems PySQLite2 had converted the default value to unicode.

   test_unicode.py failed with UnicodeDecodeError and I don't know how I
can fix it. The following program

#! /usr/local/bin/python -O
# -*- coding: koi8-r -*-

from pysqlite2 import dbapi2 as sqlite
con = sqlite.connect(":memory:")
cur = con.cursor()
cur.execute("create table person (id integer primary key, name varchar)")
cur.execute("insert into person values (1, 'Олег')") # this is my name 'Oleg' in koi8-r
cur.execute("select * from person")
print cur.fetchall()

   fails:

    cur.execute("select * from person")
UnicodeDecodeError: 'utf8' codec can't decode bytes in position 0-2: invalid data

   There must be a way to set encoding for
cur.execute("insert into person ...
   but I don't know what it is. Any idea?

Oleg.
-- 
     Oleg Broytmann            http://phd.pp.ru/            phd@...
           Programmers don't die, they just GOSUB without RETURN.

On Tue, Jun 14, 2005 at 03:27:46PM +0400, Oleg Broytmann wrote:
> #! /usr/local/bin/python -O
> # -*- coding: koi8-r -*-
> 
> from pysqlite2 import dbapi2 as sqlite
> con = sqlite.connect(":memory:")
> cur = con.cursor()
> cur.execute("create table person (id integer primary key, name varchar)")
> cur.execute("insert into person values (1, 'Олег')") # this is my name 'Oleg' in koi8-r
> cur.execute("select * from person")
> print cur.fetchall()

   Got it:

cur.execute(unicode("insert into person values (1, 'Олег')", "koi8-r"))

   Now I should find a way to generate unicode query strings in
SQLObject...

Oleg.
-- 
     Oleg Broytmann            http://phd.pp.ru/            phd@...
           Programmers don't die, they just GOSUB without RETURN.