ROX Desktop

On Fri, 16 Dec 2005 14:59:49 +0100, Andras Mohari wrote:

> Hi,
> 
> Does it make sense to colourize the file icons (including the pinboard
> icons) to the selection colour instead of the fixed blue colour?  That's
> what the attached patch does.
> 
> It looks more consistent with GTK+ themes than a fixed colour.

Applied :-)

> The pixbufs are colourized on-the-fly, which is surely somewhat slower
> than using pre-colourized pixbufs. On the other hand, it requires a
> little bit less memory.

We'll see if anyone complains...


-- 
Dr Thomas Leonard		http://rox.sourceforge.net
GPG: 9242 9807 C985 3C07 44A6  8B9A AE07 8280 59A5 3CC1

On Fri, 16 Dec 2005 20:56:33 +0000, Thomas Leonard wrote:

> > It looks more consistent with GTK+ themes than a fixed colour.
>
> Applied :-)

Thanks a lot! However, I have run into a nasty bug. The last change
made to collection.c (rev 1.116 -> 1.117) makes the filer segfault
when using the CleanIce theme engine. Looks like it does not accept NULL
for the 'detail' argument to gtk_paint_flat_box(). Either that, or I am
clueless.

Also, there is a problem with my last patch too. In some themes, the
"base" colour used to highlight the icon does not match the colour used
to draw the icon's text. This only seems to happen in icons view;
using the "bg" colour seems to help. The problematic themes are, for
example, MagicChicken and CortlandChicken.

-- 
Andras Mohari

On Sat, 17 Dec 2005 11:51:02 +0100, Andras Mohari wrote:

> On Fri, 16 Dec 2005 20:56:33 +0000, Thomas Leonard wrote:
> 
>> > It looks more consistent with GTK+ themes than a fixed colour.
>>
>> Applied :-)
> 
> Thanks a lot! However, I have run into a nasty bug. The last change
> made to collection.c (rev 1.116 -> 1.117) makes the filer segfault
> when using the CleanIce theme engine. Looks like it does not accept NULL
> for the 'detail' argument to gtk_paint_flat_box(). Either that, or I am
> clueless.

The GTK API docs say NULL is OK. However, cleanice does this:

  } else if (!strncmp ("cell_even", detail, strlen ("cell_even")) ||

I've change the detail to "collection". That doesn't seem to crash any
theme :-)
 
> Also, there is a problem with my last patch too. In some themes, the
> "base" colour used to highlight the icon does not match the colour used
> to draw the icon's text. This only seems to happen in icons view; using
> the "bg" colour seems to help. The problematic themes are, for example,
> MagicChicken and CortlandChicken.

Fixed.


-- 
Dr Thomas Leonard		http://rox.sourceforge.net
GPG: 9242 9807 C985 3C07 44A6  8B9A AE07 8280 59A5 3CC1