CEDET

Hi Felix,

Sorry for the slow response.  This is a great place to post patches to 
CEDET.

Thanks for the patches!  They worked fine against the test suites I ran. 
  I'll also guess it will fix a problem I've been bumping into, but 
hadn't had time to fully investigate.

I did an additional grep around for additional examples, found another 
similar featurep check, so was able to fix that too.

Thanks!
Eric

On 09/10/2012 03:47 PM, Felix Geller wrote:
> Hi,
>
> I needed the following two patches to get db-javap to work:
>
>   - Fix a rename: semantic/db rather than semanticdb
>   - Add semantic-javap-classpath to the searched paths
>
> I attached the files, but they are also available online:
>
> https://github.com/fgeller/cedet/commits/fixes-to-javap
>
> I'm not sure if this is the correct way to contribute, please do let me
> know what you think :)
>
>
>
> Cheers,
> Felix Geller
>

Hi Eric,

"Eric M. Ludlam" <ericludlam@...> writes:

> Sorry for the slow response.

No worries :)

> Thanks for the patches!  They worked fine against the test suites I ran. 
>   I'll also guess it will fix a problem I've been bumping into, but 
> hadn't had time to fully investigate.

I just pulled in the recent changes, but don't see addition of the
`semantic-javap-classpath' variable to the searched paths. Does this
mean that I should do this some other way?


Cheers,
Felix


> On 09/10/2012 03:47 PM, Felix Geller wrote:
>> Hi,
>>
>> I needed the following two patches to get db-javap to work:
>>
>>   - Fix a rename: semantic/db rather than semanticdb
>>   - Add semantic-javap-classpath to the searched paths
>>
>> I attached the files, but they are also available online:
>>
>> https://github.com/fgeller/cedet/commits/fixes-to-javap
>>
>> I'm not sure if this is the correct way to contribute, please do let me
>> know what you think :)
>>
>>
>>
>> Cheers,
>> Felix Geller
>>

-- 
Felix Geller

On 09/11/2012 01:36 AM, Felix Geller wrote:
> Hi Eric,
>
> "Eric M. Ludlam"<ericludlam@...>  writes:
>
>> Sorry for the slow response.
>
> No worries :)
>
>> Thanks for the patches!  They worked fine against the test suites I ran.
>>    I'll also guess it will fix a problem I've been bumping into, but
>> hadn't had time to fully investigate.
>
> I just pulled in the recent changes, but don't see addition of the
> `semantic-javap-classpath' variable to the searched paths. Does this
> mean that I should do this some other way?
>

I think that was a case of me not scrolling down far enough in your 
email last night.

That variable has been a standing incomplete issue and I haven't gotten 
around to solving.  Seems simple in retrospect.  Thanks!

Eric