Boa Constructor - wxPython GUI Builder

Chris,

On 27/11/2010 18:32, Chris Spencer wrote:
> wx.DIALOG_MODAL and wx.DIALOG_MODELESS have been removed as of
> wxPython 2.9.  It is dangerous (and unnecessary) to leave them in Boa
> Constructor.  Therefore, in the file FrameCompanions.py, replace...
>
> class DialogDTC(FramesConstr, BaseFrameDTC):
>      dialogLayout = True
>
>      def __init__(self, name, designer, frameCtrl):
>          BaseFrameDTC.__init__(self, name, designer, frameCtrl)
>          self.windowStyles = ['wx.DIALOG_MODAL', 'wx.DIALOG_MODELESS',
>                'wx.CAPTION', 'wx.DEFAULT_DIALOG_STYLE',
> 'wx.RESIZE_BORDER',
>                'wx.THICK_FRAME', 'wx.STAY_ON_TOP',
> 'wx.DIALOG_NO_PARENT',
>                'wx.SYSTEM_MENU', 'wx.CLOSE_BOX']\
>                + self.windowStyles
>
> with...
>
> class DialogDTC(FramesConstr, BaseFrameDTC):
>      dialogLayout = True
>
>      def __init__(self, name, designer, frameCtrl):
>          BaseFrameDTC.__init__(self, name, designer, frameCtrl)
>          self.windowStyles = [
>                'wx.CAPTION', 'wx.DEFAULT_DIALOG_STYLE',
> 'wx.RESIZE_BORDER',
>                'wx.THICK_FRAME', 'wx.STAY_ON_TOP',
> 'wx.DIALOG_NO_PARENT',
>                'wx.SYSTEM_MENU', 'wx.CLOSE_BOX']\
>                + self.windowStyles
>
> (just removing wx.DIALOG_MODAL and wx.DIALOG_MODELESS references)
Shouldn't changes like this be conditioned by Version?  I.e. if one is 
on wxPython 2.8 or lower this is still active otherwise not.

There is already quite a big of "if wx.VERSION[:2] >= (2, 7):" type code 
in there.


Werner

On Sun, 28 Nov 2010 11:17:26 +0100, "Werner F. Bruhin"
<werner.bruhin@...> wrote:
>Chris,
>(just removing wx.DIALOG_MODAL and wx.DIALOG_MODELESS references)
>Shouldn't changes like this be conditioned by Version?  I.e. if one is 
>on wxPython 2.8 or lower this is still active otherwise not.
>
>There is already quite a big of "if wx.VERSION[:2] >= (2, 7):" type code 
>in there.
>
>
>Werner

Oh, absolutely, if I were going to patch the main trunk to BOA.  I was
just putting that out there for people working with wxPython 2.9 and
up, not patching BOA itself.

I promise to be careful about versions when I do production-ready BOA
patches...

For me, I'm okay with pinning a minimum version on BOA so that we
don't have to support versions of wxPython back to the stone-age,
which would just bloat Boa with "if-blocks" all over the place.

For me, all of this is academic until AT THE VERY LEAST we set up a
repository somewhere for new code commits (I'm still pulling for
Mercurial).

I'd also like SOME kind of blessing from Riaan.  Even though GPL lets
us fork this code, I'd hope it'd be done in a way that respects the
ENORMOUS work of the original author.  His lack of reaction to this
current turn of events makes me wonder if he's even reading this list
anymore.

I am about 2 weeks away from being able to provide the repository on a
TEMPORARY basis (to get us started).  I'd say we give Riaan until Dec.
15 to give us SOMETHING of a reaction before forking it without him.
Even THAT makes me feel icky, but progress must be made.

Chris.

Hi Chris,

On 28/11/2010 16:37, Chris Spencer wrote:
> On Sun, 28 Nov 2010 11:17:26 +0100, "Werner F. Bruhin"
> <werner.bruhin@...>  wrote:
>> Chris,
>> (just removing wx.DIALOG_MODAL and wx.DIALOG_MODELESS references)
>> Shouldn't changes like this be conditioned by Version?  I.e. if one is
>> on wxPython 2.8 or lower this is still active otherwise not.
>>
>> There is already quite a big of "if wx.VERSION[:2]>= (2, 7):" type code
>> in there.
>>
>>
>> Werner
>
> Oh, absolutely, if I were going to patch the main trunk to BOA.  I was
> just putting that out there for people working with wxPython 2.9 and
> up, not patching BOA itself.
>
> I promise to be careful about versions when I do production-ready BOA
> patches...
>
> For me, I'm okay with pinning a minimum version on BOA so that we
> don't have to support versions of wxPython back to the stone-age,
> which would just bloat Boa with "if-blocks" all over the place.
Agreed, but I think at a minimum 2.8 needs to be support for a long time 
to come.
>
> For me, all of this is academic until AT THE VERY LEAST we set up a
> repository somewhere for new code commits (I'm still pulling for
> Mercurial).
Agreed - lets see if Riaan has a preference.
>
> I'd also like SOME kind of blessing from Riaan.  Even though GPL lets
> us fork this code, I'd hope it'd be done in a way that respects the
> ENORMOUS work of the original author.  His lack of reaction to this
> current turn of events makes me wonder if he's even reading this list
> anymore.
He is.  I have been in touch with him off-list less then a week ago.
>
> I am about 2 weeks away from being able to provide the repository on a
> TEMPORARY basis (to get us started).  I'd say we give Riaan until Dec.
> 15 to give us SOMETHING of a reaction before forking it without him.
> Even THAT makes me feel icky, but progress must be made.
I don't think that this will be an issue as there are plenty of optiones 
for OpenSource projects.  One could stay on SourceForge, they are coming 
out with new stuff and they support all the top source code management 
systems or go with one of the others.  I wouldn't do some temp stuff and 
then move again as this is all just work .....

Werner