Linux Test Project

On Mon, Apr 26, 2010 at 2:21 PM, Cyril Hrubis <chrubis@...> wrote:
> Hi!
> Attached patch adds types for functions in sources for fs-bench just because
> when function doesn't have return type it defaults to int and this causes
> problems (for example when doing return from such function without value).
>
> Signed-off-by: Cyril Hrubis chrubis@...
>
>
> Side note:
>
> The code quality for fs-bench is very poor, there is no documentation and the
> scripts are broken (mostly wrongly hardcoded paths). IMHO these tests are not
> worth fixing and candidate for removal.

    Please provide a build log.
Thanks,
-Garrett

Hi!
> > Attached patch adds types for functions in sources for fs-bench just because
> > when function doesn't have return type it defaults to int and this causes
> > problems (for example when doing return from such function without value).
> >
> > Signed-off-by: Cyril Hrubis chrubis@...
> >
> >
> > Side note:
> >
> > The code quality for fs-bench is very poor, there is no documentation and the
> > scripts are broken (mostly wrongly hardcoded paths). IMHO these tests are not
> > worth fixing and candidate for removal.
> 
>     Please provide a build log.

Okay apparently I've missed some "unused variable" and "implicit
function declaration" warnings.  Attached patch fixes all compilation
issues (has previous two merged) but still at least the test scripts are
broken.

Signed-off-by: Cyril Hrubis chrubis@...

-- 
Cyril Hrubis
chrubis@...

On Thu, 2010-07-08 at 12:55 +0200, Cyril Hrubis wrote: 
> Hi!
> > > Attached patch adds types for functions in sources for fs-bench just because
> > > when function doesn't have return type it defaults to int and this causes
> > > problems (for example when doing return from such function without value).
> > >
> > > Signed-off-by: Cyril Hrubis chrubis@...
> > >
> > >
> > > Side note:
> > >
> > > The code quality for fs-bench is very poor, there is no documentation and the
> > > scripts are broken (mostly wrongly hardcoded paths). IMHO these tests are not
> > > worth fixing and candidate for removal.
> > 
> >     Please provide a build log.
> 
> Okay apparently I've missed some "unused variable" and "implicit
> function declaration" warnings.  Attached patch fixes all compilation
> issues (has previous two merged) but still at least the test scripts are
> broken.
> 
> Signed-off-by: Cyril Hrubis chrubis@...

Thanks.

Regards--
Subrata

> 
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Sprint
> What will you do first with EVO, the first 4G phone?
> Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
> _______________________________________________ Ltp-list mailing list Ltp-list@... https://lists.sourceforge.net/lists/listinfo/ltp-list