Pidgin

was this lack of title done intentionally?
luke

----- Forwarded message from Bjoern Voigt <bjoern@...> -----

Date: Wed, 5 Nov 2003 21:33:49 +0100 (CET)
From: Bjoern Voigt <bjoern@...>
To: Luke Schierer <lschiere@...>
Subject: Missing title patch (missing-title1.patch)

The message box which informs the user, that he/she is disconnected
has no title. This patch changes this. Is the title "Disconnected" ok?

Bj?rn
Index: src/gtkconn.c
===================================================================
RCS file: /cvsroot/gaim/gaim/src/gtkconn.c,v
retrieving revision 1.24
diff -u -3 -p -u -r1.24 gtkconn.c
--- src/gtkconn.c	5 Nov 2003 06:15:48 -0000	1.24
+++ src/gtkconn.c	5 Nov 2003 18:27:13 -0000
@@ -329,7 +329,7 @@ gaim_gtk_connection_report_disconnect(Ga
 		GtkTreeSelection *sel;
 	
 		disconnect_window = g_new0(struct disconnect_window, 1);
-		disconnect_window->window = gtk_dialog_new_with_buttons("", NULL, GTK_DIALOG_NO_SEPARATOR,
+		disconnect_window->window = gtk_dialog_new_with_buttons(_("Disconnected"), NULL, GTK_DIALOG_NO_SEPARATOR,
 									_("Reconnect"), GTK_RESPONSE_ACCEPT,
 									GTK_STOCK_CLOSE, GTK_RESPONSE_CLOSE, NULL);
 		g_signal_connect(G_OBJECT(disconnect_window->window), "response", G_CALLBACK(disconnect_response_cb), disconnect_window);


----- End forwarded message -----

-- 
-This email is made of 100% recycled electrons.

Re: [Gaim-devel] Fwd: Missing title patch (missing-title1.patch) From: Sean Egan <sean.egan@bi...> - 2003-11-06 06:46 On Wed, 2003-11-05 at 17:46, Luke Schierer wrote: > was this lack of title done intentionally? Yes. Alert dialogs should not have titles. -s.

[Gaim-devel] Re: Fwd: Missing title patch (missing-title1.patch) From: Bjoern Voigt <bjoern@cs...> - 2003-11-07 22:58 Sean Egan <sean.egan@...> wrote: > On Wed, 2003-11-05 at 17:46, Luke Schierer wrote: > > was this lack of title done intentionally? >=20 > Yes. Alert dialogs should not have titles. OK, but as a consquence, metacity (GNOME's standard window manager) displays this window as "untitled window" (not translated! - but this is a metacity i18n problem) in it's window list. Also it's not easy to find the Gaim windows in the window list of the window manager. For instance the main window of Gaim is now called "Buddy List" (see src/gtkblist.c:2150). =20 gtk_window_set_title(GTK_WINDOW(gtkblist->window), _("Buddy List")); Former Gaim versions called this window something like "Gaim - Buddy List". Who has changed this and why? I miss the old "Gaim - ..." titles because with this titles it was easier to find a Gaim window in the window list. Bj=F6rn

Re: [Gaim-devel] Re: Fwd: Missing title patch (missing-title1.patch) From: Luke Schierer <lschiere@us...> - 2003-11-08 00:20 its kind of ironic that we got the idea not to have a title from gnome's HIG, and yet gnome's default wm handles it poorly. luke On Fri, Nov 07, 2003 at 11:52:17PM +0100, Bjoern Voigt wrote: > Sean Egan <sean.egan@...> wrote: > > On Wed, 2003-11-05 at 17:46, Luke Schierer wrote: > > > was this lack of title done intentionally? > > > > Yes. Alert dialogs should not have titles. > > OK, but as a consquence, metacity (GNOME's standard window manager) > displays this window as "untitled window" (not translated! - but this > is a metacity i18n problem) in it's window list. > > Also it's not easy to find the Gaim windows in the window list of the > window manager. For instance the main window of Gaim is now called > "Buddy List" (see src/gtkblist.c:2150). > > gtk_window_set_title(GTK_WINDOW(gtkblist->window), _("Buddy List")); > > Former Gaim versions called this window something like "Gaim - Buddy > List". Who has changed this and why? I miss the old "Gaim - ..." > titles because with this titles it was easier to find a Gaim window in > the window list. > > Bj?rn > > > ------------------------------------------------------- > This SF.Net email sponsored by: ApacheCon 2003, > 16-19 November in Las Vegas. Learn firsthand the latest > developments in Apache, PHP, Perl, XML, Java, MySQL, > WebDAV, and more! http://www.apachecon.com/ > _______________________________________________ > Gaim-devel mailing list > Gaim-devel@... > https://lists.sourceforge.net/lists/listinfo/gaim-devel > > -- -This email is made of 100% recycled electrons.

[Gaim-devel] Re: Re: Fwd: Missing title patch (missing-title1.patch) From: Bjoern Voigt <bjoern@cs...> - 2003-11-08 23:08 Luke Schierer <lschiere@...> wrote: > its kind of ironic that we got the idea not to have a title from gnome's= =20 > HIG, and yet gnome's default wm handles it poorly. Yes, sure. And I wonder that also the Gnome Developers don't use empty titles for alert messages. I tested some alert messages (errors) from GEdit, Evolution and Nautilus (current Gnome 2.4 versions). This applications use short titles like "Question" or "Error". Sometimes they also use other titles, for instance, Nautilus often uses the directory name. GEdit has an interesting error message, if you try to overwrite an existing file with "Save as...": The window has the title "Question". This alert windows is listed in the "Alt-Tab" window list, but not in the window list of the Gnome Panel. The GEdit alert dialog has the following source (see gedit/gedit/gedit-file-selector-util.c): msgbox =3D gtk_message_dialog_new (parent, GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_= WITH_PARENT, GTK_MESSAGE_QUESTION, GTK_BUTTONS_NONE, message, uri_for_display); =20 The title "Question" is automatically set, because of the option GTK_MESSAGE_QUESTION. There are also some other options: GTK_MESSAGE_INFO=09 Informational message=20 GTK_MESSAGE_WARNING=09 Nonfatal warning message=20 GTK_MESSAGE_QUESTION Question requiring a choice=20 GTK_MESSAGE_ERROR=09 Fatal error message Bj=F6rn

Re: [Gaim-devel] Re: Fwd: Missing title patch (missing-title1.patch) From: Sean Egan <sean.egan@bi...> - 2003-11-10 17:23 On Fri, 2003-11-07 at 17:52, Bjoern Voigt wrote: > OK, but as a consquence, metacity (GNOME's standard window manager) > displays this window as "untitled window" (not translated! - but this > is a metacity i18n problem) in it's window list. I believe you mean the Window List applet. Metacity correctly gives the window no title. Either way, the logic is that an alert window will not be in your window list long enough for it to matter. I believe the old behavior was not to put untitled windows in the window list at all. > Former Gaim versions called this window something like "Gaim - Buddy > List". Who has changed this and why? I changed it. The HIG recommends (and I agree) that the window title should state only what the window is---not what application created it. -s.

Re: [Gaim-devel] Re: Fwd: Missing title patch (missing-title1.patch) From: Ethan Blanton <eblanton@cs...> - 2003-11-10 17:27 Attachments: Message as HTML      Sean Egan spake unto us the following wisdom: > > Former Gaim versions called this window something like "Gaim - Buddy > > List". Who has changed this and why?=20 >=20 > I changed it. The HIG recommends (and I agree) that the window title > should state only what the window is---not what application created it. I also agree. It's not our job to cater to ghetto window managers that don't so much "manage" your windows... Ethan --=20 To surrender one's personal weapon is to invite disaster. This has been obvious for so long and so often that there is probably a Greek word for the practice. -- Jeff Cooper

Re: [Gaim-devel] Re: Fwd: Missing title patch (missing-title1.patch) From: Luke Schierer <lschiere@us...> - 2003-11-10 17:27 On Mon, Nov 10, 2003 at 12:23:15PM -0500, Sean Egan wrote: > On Fri, 2003-11-07 at 17:52, Bjoern Voigt wrote: > > OK, but as a consquence, metacity (GNOME's standard window manager) > > displays this window as "untitled window" (not translated! - but this > > is a metacity i18n problem) in it's window list. > > I believe you mean the Window List applet. Metacity correctly gives the > window no title. Either way, the logic is that an alert window will not > be in your window list long enough for it to matter. I believe the old > behavior was not to put untitled windows in the window list at all. the problem with this logic is that it fails for gaim. we create one error per connection per attemt to reconnect when the network fails, which often happens when the user is not at the screen. at least, we did while the autoreconnect plugin worked. luke > > > Former Gaim versions called this window something like "Gaim - Buddy > > List". Who has changed this and why? > > I changed it. The HIG recommends (and I agree) that the window title > should state only what the window is---not what application created it. > > -s. > > > ------------------------------------------------------- > This SF.Net email sponsored by: ApacheCon 2003, > 16-19 November in Las Vegas. Learn firsthand the latest > developments in Apache, PHP, Perl, XML, Java, MySQL, > WebDAV, and more! http://www.apachecon.com/ > _______________________________________________ > Gaim-devel mailing list > Gaim-devel@... > https://lists.sourceforge.net/lists/listinfo/gaim-devel

Re: [Gaim-devel] Re: Fwd: Missing title patch (missing-title1.patch) From: Sean Egan <sean.egan@bi...> - 2003-11-10 17:31 On Mon, 2003-11-10 at 12:28, Luke Schierer wrote: > we create one > error per connection per attemt to reconnect when the network fails, > which often happens when the user is not at the screen. at least, we did > while the autoreconnect plugin worked. Apparently you missed that this discussion is spawned from a patch changing the title of the single window that shows all disconnections in it. -s.

6 messages have been excluded from this view by a project administrator.