On Tue, 13 Nov 2007 at 15:13 +0000, Dave Nomura wrote:
> Marc Schafer wrote:
> >I disagree with the idea of not displaying callee/caller information
> >that doesn't meet the threshold specified with -t. I use -t to limit
> >the functions that I am looking at, but if I am doing call graph
> >analysis, then I expect to see the callees and callers of the functions
> >that I have selected. Sometimes a function appears high up in the
> >profile not because it is inherently slow, but rather because it is
> >getting called too many times. That is why I would like to see all the
> >callers of a hotspot even if they themselves are not hotspots.
> >I definitely would not like to see this functionality removed from the
> >text output just to make it match the xml. I think it would be much
> >better to always have all the idrefs at the bottom of the xml file and
> >leave the -t filtering the way it is.
> I think that Marc makes a good point. I would think that if you are
> using the threshold option, you still want to see the callee/caller
> information regardless whether or not they meet the threshold
> criterion. What do you think?
Well, the point of -t is to remove noise, if you have 500 callees and only
one hot, I don't see the point to keep them.
> I am working on a patch to make the XML generation generate SYMBOL_DATA
> for the caller/callee symbols, regardless whether they meet the
> threshold criterion or not.
Hmmm, we can't apply least surprise principle here, we disagree on what
approach is the least surprising. I always used -t as an apply first option
before considering any other options. Ok send your patch Dave, because we
want to fix this bug, this approach is simpler to implement than the
filtering I wanted first and my 500 callees example is rather a caricatural
case than a real one I already saw.
Otoh if someone in future complains, show a real example of noisy output
*and* come with a patch to implement the other way, I'll restart this
discussion and consider to apply this new patch. Waiting this hypothetical
event we can go for your way.