qooxdoo

Revision: 24063
          http://qooxdoo.svn.sourceforge.net/qooxdoo/?rev=24063&view=rev
Author:   chris_schmidt
Date:     2010-11-30 10:26:34 +0000 (Tue, 30 Nov 2010)

Log Message:
-----------
[BUG #1897] Only model items are allowed to select.

Modified Paths:
--------------
    trunk/qooxdoo/framework/source/class/qx/ui/list/provider/WidgetProvider.js

Modified: trunk/qooxdoo/framework/source/class/qx/ui/list/provider/WidgetProvider.js
===================================================================
--- trunk/qooxdoo/framework/source/class/qx/ui/list/provider/WidgetProvider.js	2010-11-30 10:19:01 UTC (rev 24062)
+++ trunk/qooxdoo/framework/source/class/qx/ui/list/provider/WidgetProvider.js	2010-11-30 10:26:34 UTC (rev 24063)
@@ -186,6 +186,10 @@
     // interface implementation
     isSelectable : function(row)
     {
+      if (this._list._isGroup(row)) {
+        return false;
+      }
+
       var widget = this._list._layer.getRenderedCellWidget(row, 0);
 
       if (widget != null) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

Revision: 24072
          http://qooxdoo.svn.sourceforge.net/qooxdoo/?rev=24072&view=rev
Author:   chris_schmidt
Date:     2010-11-30 14:19:42 +0000 (Tue, 30 Nov 2010)

Log Message:
-----------
[BUG #1897] Minor improvement, renamed _cellRenderer to _itemRenderer.

Modified Paths:
--------------
    trunk/qooxdoo/framework/source/class/qx/ui/list/provider/WidgetProvider.js

Modified: trunk/qooxdoo/framework/source/class/qx/ui/list/provider/WidgetProvider.js
===================================================================
--- trunk/qooxdoo/framework/source/class/qx/ui/list/provider/WidgetProvider.js	2010-11-30 14:14:06 UTC (rev 24071)
+++ trunk/qooxdoo/framework/source/class/qx/ui/list/provider/WidgetProvider.js	2010-11-30 14:19:42 UTC (rev 24072)
@@ -47,18 +47,18 @@
 
     this._list = list;
 
-    this._cellRenderer = this.createItemRenderer();
+    this._itemRenderer = this.createItemRenderer();
     this._groupRenderer = this.createGroupRenderer();
 
-    this._cellRenderer.addListener("created", this._onWidgetCreated, this);
+    this._itemRenderer.addListener("created", this._onWidgetCreated, this);
     this._list.addListener("changeDelegate", this._onChangeDelegate, this);
   },
 
 
   members :
   {
-    /** {qx.ui.virtual.cell.WidgetCell} the used cell renderer */
-    _cellRenderer : null,
+    /** {qx.ui.virtual.cell.WidgetCell} the used item renderer */
+    _itemRenderer : null,
 
 
     /** {qx.ui.virtual.cell.WidgetCell} the used group renderer */
@@ -79,7 +79,7 @@
 
       if (!this._list._isGroup(row))
       {
-        widget = this._cellRenderer.getCellWidget();
+        widget = this._itemRenderer.getCellWidget();
         widget.setUserData("cell.type", "item");
         this._bindItem(widget, this._list._lookup(row));
 
@@ -107,7 +107,7 @@
       this._removeBindingsFrom(widget);
 
       if (widget.getUserData("cell.type") == "item") {
-        this._cellRenderer.pool(widget);
+        this._itemRenderer.pool(widget);
       } else if (widget.getUserData("cell.type") == "header") {
         this._groupRenderer.pool(widget);
       }
@@ -255,9 +255,9 @@
      */
     _onChangeDelegate : function(event)
     {
-      this._cellRenderer.dispose();
-      this._cellRenderer = this.createItemRenderer();
-      this._cellRenderer.addListener("created", this._onWidgetCreated, this);
+      this._itemRenderer.dispose();
+      this._itemRenderer = this.createItemRenderer();
+      this._itemRenderer.addListener("created", this._onWidgetCreated, this);
       this.removeBindings();
       this._list.getPane().fullUpdate();
     },
@@ -293,15 +293,15 @@
         return;
       }
 
-      this._cellRenderer.updateStates(widget, states);
+      this._itemRenderer.updateStates(widget, states);
     }
   },
 
 
   destruct : function()
   {
-    this._cellRenderer.dispose();
+    this._itemRenderer.dispose();
     this._groupRenderer.dispose();
-    this._cellRenderer = this._groupRenderer = null;
+    this._itemRenderer = this._groupRenderer = null;
   }
 });
\ No newline at end of file


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.