Bugs item #2080891, was opened at 2008-08-28 20:14
Message generated for change (Comment added) made by kpouer
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100588&aid=2080891&group_id=588
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: text area and syntax packages
Group: normal bug
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Kevin Hunter (hunteke)
Assigned to: Nobody/Anonymous (nobody)
Summary: shellscript.xml: Escaped quote still marked as LITERAL1
Initial Comment:
prepend() { [ -d "$2" ] && eval $1=\"$2\$\{$1:+':'\$$1\}\" && export $1 ; }
Stuff immediately following this line in a shellscript gets marked incorrectly as LITERAL1 token types.
$ svn up
At revision 13445.
Attached is test case, and explanation.
Also attached is a patch.
----------------------------------------------------------------------
>Comment By: Matthieu Casanova (kpouer)
Date: 2008-09-07 01:09
Message:
Logged In: YES
user_id=285591
Originator: NO
Hi, thank you for this patch it is applied in the trunk
----------------------------------------------------------------------
Comment By: Kevin Hunter (hunteke)
Date: 2008-08-28 20:18
Message:
Logged In: YES
user_id=1271235
Originator: YES
In the test case, I've marked 4 spots.
The attached patch fixes 1, 2, and 3, and makes the comments get marked as
comments.
Spot 4 is no longer marked as a LITERAL1, but is now marked as KEYWORD2,
following the MARK_FOLLOWING directive on line 28, I think. Not sure how
to correct that, but this is an improvement.
File Added: shellscript.xml.patch
----------------------------------------------------------------------
Comment By: Kevin Hunter (hunteke)
Date: 2008-08-28 20:18
Message:
Logged In: YES
user_id=1271235
Originator: YES
In the test case, I've marked 4 spots.
The attached patch fixes 1, 2, and 3, and makes the comments get marked as
comments.
Spot 4 is no longer marked as a LITERAL1, but is now marked as KEYWORD2,
following the MARK_FOLLOWING directive on line 28, I think. Not sure how
to correct that, but this is an improvement.
File Added: shellscript.xml.patch
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100588&aid=2080891&group_id=588
|
