Patches item #1192753, was opened at 2005-04-29 14:48
Message generated for change (Comment added) made by dtremenak
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=303248&aid=1192753&group_id=3248
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Out of Date
Priority: 5
Submitted By: Raymond Martineau (mart0258)
Assigned to: Daniel Remenak (dtremenak)
Summary: Visual C++ Project file patch
Initial Comment:
This is a minor (but necessairy) patch in order to
allow the game to compile under VC++ 6.0. The patch is
based from the most recent package (but should still be
functional under the latest CVS as no changes appear to
have been made recently.) The patch only covers
project files -- It doesn't fix the problem in
bzfs/commands.cxx using find_if instead of std::find_if.
FYI, the .DSP files all need to use a CR-LF combination
for them to be recognized by VC 6.0. This patch does
not fix the problem, but any decent editor should be
able to make these kinds of changes for you.
----------------------------------------------------------------------
>Comment By: Daniel Remenak (dtremenak)
Date: 2006-07-16 14:30
Message:
Logged In: YES
user_id=553378
Out of date. Visual C++ 6 support was removed from head for
standards compliance reasons.
----------------------------------------------------------------------
Comment By: Raymond Martineau (mart0258)
Date: 2005-05-01 21:40
Message:
Logged In: YES
user_id=905795
I've made the requested changes. It should be fully
functional (and this time, not include changes I don't
remember making, as well as unrelated changes). The diff
patch also includes cares.dsp appended, and assumes that
there's a blank file of the same name in the CVS tree.
(Don't yet know how to get CVS to include new files in the
patch.)
One last thing - I've encountered a bug while recreating the
patch - it seems BZFlag is unable to run on a standalone
computer. The patch for BZFlag involves removing the exit
statement from AresHandler::AresHandler. However, this
uncovers a bug with the C-ares library in ares_process.c
where it produces an access violation in process_timeouts()
- it calls next_server(), which in turn calls end_query()
that deallocates memory structures that need to get used.
This patch does not include fixing the newly uncovered
problem, as I do not yet have a proper fix. (My current
workaround may cause resource leaks.)
----------------------------------------------------------------------
Comment By: Daniel Remenak (dtremenak)
Date: 2005-05-01 13:42
Message:
Logged In: YES
user_id=553378
Most of this looks good. A few comments though:
1. "+SOURCE=..\..\include\curl\easy.h" - Don't do that, we
don't distribute the curl headers.
2. "+SOURCE=..\..\src\net\udpnetwork.cxx" - This is not
necessary, actually. As of about 30 seconds ago, the file
has been removed from CVS because we don't use it anymore;
thanks for bringing it to our attention ;) Likewise the
header if you had that somewhere in this patch.
And this whole chunk "diff U3b
E:\work\cvs\bzflag\src\net\udpnetwork.cxx
E:\work\bzflag\src\net\udpnetwork.cxx" is unnecessary for
the same reason.
FYI, socklen_t is defined in VC6, in one of the winsock headers.
3. "+ register int i;" - Don't use the register keyword,
it's not used anywhere else in BZFlag. Compilers can figure
out what needs to go in the cpu registers and what doesn't
on thier own.
4. You'll need to add the c-ares project to bzflag.dsw in
order for it to actually build in sequence. Net should
depend on it.
5. Please remove the adig and ahost source files from the
c-ares project, we don't need to build them. adig probably
doesn't build anyway.
----------------------------------------------------------------------
Comment By: Raymond Martineau (mart0258)
Date: 2005-04-30 08:26
Message:
Logged In: YES
user_id=905795
An upodated patch. Note that there are changes beyond the
project file, some of which may make compilation
incompatable with gcc (untested.)
The worst problem would be the lack of definition of
socklen_t under VC++ 6.0. Everything else shouldn't be
worrysome.
----------------------------------------------------------------------
Comment By: Raymond Martineau (mart0258)
Date: 2005-04-29 19:31
Message:
Logged In: YES
user_id=905795
At the time I've uploaded the file (I'm currently on
dial-up), I noticed that the CVS has a few more files. I'll
have a new patch a bit later...
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=303248&aid=1192753&group_id=3248
|
