On Tue, Sep 13, 2011 at 11:09 AM, Dan Kegel <dank@...> wrote:
> On Sun, Sep 4, 2011 at 8:59 AM, Dustin J. Mitchell <dustin@...> wrote:
>> On Sun, Sep 4, 2011 at 10:06 AM, Dustin J. Mitchell <dustin@...> wrote:
>>> It's not available in 0.8.4 (documented in /current/), but indeed, it
>>> is missing from /latest/ too.
>> Oops, it *is* available in 0.8.4. At any rate, I added documentation
>> for that parameter. Thanks for pointing it out!
> Aw, foo. When you use a Dependent scheduler, the patch comment
> gets replaced by "downstream", so it sounds like I'm going to have
> to use --properties=comment= (as well as --comment) if I want
> the comment to remain visible in downstream builds.
I'm not sure what this means - the Dependent scheduler doesn't edit
the sourcestamp. It does set the BuildSet reason to "downstream".
There are a *lot* of places in Buildbot that could be informally
described as "comment", but only one is truly called "comment" - that
comes with the patch. You've also added a comment property, which
begins some confusion. Don't add more confusion by referring to other
things as comments :)