perfmon2

Patch applied.
Please pull and verifies that it works for you.
Thanks.

On Wed, Mar 14, 2012 at 9:21 PM, William Cohen <wcohen@...> wrote:
> Hi,
>
> I took a look at the rpm spec file for libpfm in the libpfm-4.2.0.tar.gz. Attached is the revised version:
>
> -Allow the python support to be include or excluded from rpmbuild
> -change spec file name to libpfm.spec (no need for the '4' in there)
> -adjust summary and line lengths (no '.' and limit length of lines)
> -allow parallel makes of libpfm
> -avoid having libpfm-devel own man3 directory
> -proper version information in changelog
>
> -Will
>
> ------------------------------------------------------------------------------
> Virtualization & Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> _______________________________________________
> perfmon2-devel mailing list
> perfmon2-devel@...
> https://lists.sourceforge.net/lists/listinfo/perfmon2-devel
>

On 03/15/2012 12:51 PM, stephane eranian wrote:
> Patch applied.
> Please pull and verifies that it works for you.
> Thanks.
> 
> On Wed, Mar 14, 2012 at 9:21 PM, William Cohen <wcohen@...> wrote:
>> Hi,
>>
>> I took a look at the rpm spec file for libpfm in the libpfm-4.2.0.tar.gz. Attached is the revised version:
>>
>> -Allow the python support to be include or excluded from rpmbuild
>> -change spec file name to libpfm.spec (no need for the '4' in there)
>> -adjust summary and line lengths (no '.' and limit length of lines)
>> -allow parallel makes of libpfm
>> -avoid having libpfm-devel own man3 directory
>> -proper version information in changelog
>>
>> -Will

Hi Stephane,

The spec file change works fine.  I was able to build the rpms with:

git archive --prefix=libpfm-4.2.0/ --format=tar HEAD | gzip > libpfm-4.2.0.tar.gz
rpmbuild -ta libpfm-4.2.0.tar.gz


-Will

On 03/15/2012 02:37 PM, William Cohen wrote:
> On 03/15/2012 12:51 PM, stephane eranian wrote:
>> Patch applied.
>> Please pull and verifies that it works for you.
>> Thanks.
>>
>> On Wed, Mar 14, 2012 at 9:21 PM, William Cohen <wcohen@...> wrote:
>>> Hi,
>>>
>>> I took a look at the rpm spec file for libpfm in the libpfm-4.2.0.tar.gz. Attached is the revised version:
>>>
>>> -Allow the python support to be include or excluded from rpmbuild
>>> -change spec file name to libpfm.spec (no need for the '4' in there)
>>> -adjust summary and line lengths (no '.' and limit length of lines)
>>> -allow parallel makes of libpfm
>>> -avoid having libpfm-devel own man3 directory
>>> -proper version information in changelog
>>>
>>> -Will
> 
> Hi Stephane,
> 
> The spec file change works fine.  I was able to build the rpms with:
> 
> git archive --prefix=libpfm-4.2.0/ --format=tar HEAD | gzip > libpfm-4.2.0.tar.gz
> rpmbuild -ta libpfm-4.2.0.tar.gz
> 
> 
> -Will

Hi Stephane,

I submitted a Fedora bugzilla to review the spec file:

https://bugzilla.redhat.com/show_bug.cgi?id=804666

Some additional suggestions for libpfm.spec file were made. I have updated the libpfm.spec file to address those comments.

When running rpmlint on the resulting rpm there were a couple issues with the python code were flagged:

libpfm-python.x86_64: E: non-executable-script /usr/lib64/python2.6/site-packages/perfmon/pmu.py 0644L /usr/bin/env
libpfm-python.x86_64: E: non-executable-script /usr/lib64/python2.6/site-packages/perfmon/session.py 0644L /usr/bin/env

Should those .py files in libpfm-4.2.0/python/src  be executable or should the /usr/bin/env be removed from them?

-Will

On Wed, Mar 28, 2012 at 1:56 PM, William Cohen <wcohen@...> wrote:
> libpfm-python.x86_64: E: non-executable-script /usr/lib64/python2.6/site-packages/perfmon/pmu.py 0644L /usr/bin/env
> libpfm-python.x86_64: E: non-executable-script /usr/lib64/python2.6/site-packages/perfmon/session.py 0644L /usr/bin/env
>
> Should those .py files in libpfm-4.2.0/python/src  be executable or should the /usr/bin/env be removed from them?

session.py should not be executable.

pmu.py can be a useful script - we should probably move the "if
__name__ == '__main__':" hunk into a script of its own if you decide
to make it executable.

 -Arun

Arun, Will,

Please submit a patch to fix these Python issues.
thanks.

On Fri, Apr 20, 2012 at 2:41 AM, Arun Sharma <arun@...> wrote:
> On Wed, Mar 28, 2012 at 1:56 PM, William Cohen <wcohen@...> wrote:
>> libpfm-python.x86_64: E: non-executable-script /usr/lib64/python2.6/site-packages/perfmon/pmu.py 0644L /usr/bin/env
>> libpfm-python.x86_64: E: non-executable-script /usr/lib64/python2.6/site-packages/perfmon/session.py 0644L /usr/bin/env
>>
>> Should those .py files in libpfm-4.2.0/python/src  be executable or should the /usr/bin/env be removed from them?
>
> session.py should not be executable.
>
> pmu.py can be a useful script - we should probably move the "if
> __name__ == '__main__':" hunk into a script of its own if you decide
> to make it executable.
>
>  -Arun
>
> ------------------------------------------------------------------------------
> For Developers, A Lot Can Happen In A Second.
> Boundary is the first to Know...and Tell You.
> Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
> http://p.sf.net/sfu/Boundary-d2dvs2
> _______________________________________________
> perfmon2-devel mailing list
> perfmon2-devel@...
> https://lists.sourceforge.net/lists/listinfo/perfmon2-devel

On 04/19/2012 08:41 PM, Arun Sharma wrote:
> On Wed, Mar 28, 2012 at 1:56 PM, William Cohen <wcohen@...> wrote:
>> libpfm-python.x86_64: E: non-executable-script /usr/lib64/python2.6/site-packages/perfmon/pmu.py 0644L /usr/bin/env
>> libpfm-python.x86_64: E: non-executable-script /usr/lib64/python2.6/site-packages/perfmon/session.py 0644L /usr/bin/env
>>
>> Should those .py files in libpfm-4.2.0/python/src  be executable or should the /usr/bin/env be removed from them?
> 
> session.py should not be executable.
> 
> pmu.py can be a useful script - we should probably move the "if
> __name__ == '__main__':" hunk into a script of its own if you decide
> to make it executable.
> 
>  -Arun

Hi Arun,

I don't have much experience with python and I am not that familiar with how these scripts are suppose to be used.  Is there some description how these are suppose to be used?

-Will

On Tue, Apr 24, 2012 at 6:51 AM, William Cohen <wcohen@...> wrote:
> Hi Arun,
>
> I don't have much experience with python and I am not that familiar with how these scripts are suppose to be used.  Is there some description how these are suppose to be used?

If everything works fine, you should be able to run:

cd python
./setup.py install
./self.py -> self counting
./sys.py  -> system wide counting

These are counting-only interfaces to perf_event_open() syscall, with
libpfm4 being used to fill up perf_event_attr.

Arnaldo (acme@...) has also been working on a python interface
to perf (tools/perf/python/twatch.py in the kernel git tree). That is
a higher level interface, but doesn't lookup libpfm4.

 -Arun