On Fri, Dec 28, 2012 at 9:44 PM, Zdenek Styblik
> On Fri, Dec 28, 2012 at 4:39 PM, <Jordan_Hargrave@...> wrote:
>> Why change the ordering of the arguments in getsysinfo/setsysinfo?
>> I like it the way it was originally since intf/param/block/set are part of the input ipmi command and the data/length are the returned data.
>> --jordan hargrave
>> Dell Enterprise Linux Engineering
> My reasoning behind the change is:
> * give these functions same order of common arguments since they're
> likely to be used together - easier to remember(?)
> * it seemed like a common way, at least within ipmitool
I would like to commit this one way or another and move to other
issues(there are plenty). In other words, I would like to reach some
conclusion over these changes.
Thanks and happy New Year,
>> From: Zdenek Styblik [zdenek.styblik@...]
>> Sent: Thursday, December 27, 2012 2:35 PM
>> To: Hargrave, Jordan
>> Cc: Jim Mank; ipmitool-devel
>> Subject: Code review/changes - 'mc getsysinfo|setsysinfo' - IDs #3598203, #3597782, #3597781
>> Hello Jordan,
>> attached is a diff set I'm going to commit sooner or later. This patch
>> changes some code around 'mc getsysinfo' and 'mc setsysinfo' you've
>> This e-mail is meant as a heads-up and also an opportunity for
>> questions and comments.
>> * https://sourceforge.net/tracker/?func=detail&aid=3597781&group_id=95200&atid=610550
>> * https://sourceforge.net/tracker/?func=detail&aid=3597782&group_id=95200&atid=610550
>> * https://sourceforge.net/tracker/?func=detail&aid=3598203&group_id=95200&atid=610550
>> Best regards,
>> Zdenek Styblik
>> email: zdenek.styblik@...
>> jabber: zdenek.styblik@...