I'm gonna ask one more thing. Could you update the changelog.txt accordingly?
It looks like you did a fork after v0.5.0.
The addon in the repo was at version 1.0.2. You should not remove the
old entries in the changelog.txt and should add your changes on top.
We should see v2.0.0 there.
Thanks for your patience.
And don't forget to reply to the list.
On Wed, Dec 5, 2012 at 11:41 PM, Robert Drake <rfdrake@...> wrote:
> I got in touch with Krill and he is okay with me taking it over.
> Consequently I'm adopting the old addonid. I've updated the code to
> use plugin.video.day9. Here is the new revision:
> *addon - plugin.video.day9
> *version - 2.0.0
> *url - https://github.com/rfdrake/xbmc-plugin-day9tv
> *revision - 82b3899a2f6a6accbd908532aa8345703747593f
> *xbmc version - eden, frodo
> On Mon, Dec 3, 2012 at 12:08 PM, Benjamin Bertrand
> <beenje@...> wrote:
>> Have you tried contacting the original author?
>> If he has no interest in supporting the plugin, you could take over
>> and replace his addon (keep the same addon id).
>> I don't really want to have 2 addons in the repo for the same website
>> (with one maybe not working).
>> On Fri, Nov 30, 2012 at 11:57 PM, Robert Drake <rfdrake@...> wrote:
>>> Thank you for the feedback. I changed the addon id to not conflict
>>> with the existing plugin since I wasn't the original author and didn't
>>> want to overlap with his work if he ever started releasing again. It
>>> looks like they haven't updated it in a long time though. I was using
>>> a/b/c for minor regex changes and low version numbers for .. just
>>> habit I guess. I've changed it to 2.0.0 as you suggested.
>>> *addon - plugin.video.day9tv
>>> *version - 2.0.0
>>> *url - https://github.com/rfdrake/xbmc-plugin-day9tv
>>> *revision -29da0cc6fc3a82416d8cfc8cbdf29187c88eb90e
>>> *xbmc version - eden, frodo
>>> On Fri, Nov 30, 2012 at 5:04 PM, Benjamin Bertrand
>>> <beenje@...> wrote:
>>>> 1. In your pull request, the "*addon" should be the addon id, not the
>>>> addon name.
>>>> 2. If you want to "replace" your previous addon (keep the addon id),
>>>> you need a higher version number.
>>>> It looks like a major upgrade, so I would suggest 2.0.0.
>>>> 3. Don't put a "c" in your version number. 3 numbers should give you
>>>> enough liberty (and we only take stable addon in the repo).
>>>> 4. For eden and frodo, xbmc.python shall be 2.0
>>>> 5. You need a language tag in your addon.xml. See