Gtk2Hs - A GUI Library for Haskell

Hi Peter,

On 11.07.2012, at 13:56, Peter Davies wrote:

> This has two consequences:
> * socketHasPlug is no longer supported before GTK+ 2.14
> * socketHasPlug follows GTK+ documentation and works after GTK+ 3
>

> I hope you don't mind the breakage for ancient Gtk+ versions.

It's reasonable to break a few modules on old versions of Gtk. But  
occasionally, there are some Solaris or users of old Linuxes that are  
suddenly faced with Gtk installations that are a few years old. It  
would be good if the core functionality for those still exist. At the  
moment, we only check that gtk+-2.0 is installed before we  
courageously start compiling gtk2hs.

Axel

>
> Peter,
> <move-sockethasplug-to-socket_chs-and-remove- 
> embedding_hsc 
> .dpatch 
> > 
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond.  
> Discussions
> will include endpoint security, mobile security and the latest in  
> malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/_______________________________________________
> Gtk2hs-devel mailing list
> Gtk2hs-devel@...
> https://lists.sourceforge.net/lists/listinfo/gtk2hs-devel

> It's reasonable to break a few modules on old versions of Gtk. But
> occasionally, there are some Solaris or users of old Linuxes that are
> suddenly faced with Gtk installations that are a few years old. It would be
> good if the core functionality for those still exist. At the moment, we only
> check that gtk+-2.0 is installed before we courageously start compiling
> gtk2hs.

OK,  I hope that particular patch is acceptable. It is an extreme case.

Peter,

Quoting Peter Davies <ultratwo@...>:

>> It's reasonable to break a few modules on old versions of Gtk. But
>> occasionally, there are some Solaris or users of old Linuxes that are
>> suddenly faced with Gtk installations that are a few years old. It would be
>> good if the core functionality for those still exist. At the moment, we only
>> check that gtk+-2.0 is installed before we courageously start compiling
>> gtk2hs.
>
> OK,  I hope that particular patch is acceptable. It is an extreme case.

Is it really impossible to support the older versions? What happened  
that breaks things? I see the old (removed) code has some #ifdef's; is  
there something stopping us from copying those over to the new location?

~d

On 11 July 2012 16:25,  <wagnerdm@...> wrote:
> Quoting Peter Davies <ultratwo@...>:
>> OK,  I hope that particular patch is acceptable. It is an extreme case.
>
> Is it really impossible to support the older versions? What happened
> that breaks things? I see the old (removed) code has some #ifdef's; is
> there something stopping us from copying those over to the new location?

I probably wasn't clear, this only breaks stuff if you have a program
that uses 'socketHasPlug' on a gtk version less than 2.14.

The old definition in Embedding.hsc 'peek'ed inside GtkSocket to see
if a pointer was NULL. This does not work in Gtk3. The Gtk2
documentation says you should call gtk_socket_get_plug_window() and
see if it returns NULL. So I moved socketHasPlug to Socket.chs and
used the recommended definition. I then removed Embedding.hsc, because
it was empty. Since gtk_socket_get_plug_window() was added in 2.14,
socketHasPlug only works after that version.

Peter,