On 11 July 2012 16:25, <wagnerdm@...> wrote:
> Quoting Peter Davies <ultratwo@...>:
>> OK, I hope that particular patch is acceptable. It is an extreme case.
> Is it really impossible to support the older versions? What happened
> that breaks things? I see the old (removed) code has some #ifdef's; is
> there something stopping us from copying those over to the new location?
I probably wasn't clear, this only breaks stuff if you have a program
that uses 'socketHasPlug' on a gtk version less than 2.14.
The old definition in Embedding.hsc 'peek'ed inside GtkSocket to see
if a pointer was NULL. This does not work in Gtk3. The Gtk2
documentation says you should call gtk_socket_get_plug_window() and
see if it returns NULL. So I moved socketHasPlug to Socket.chs and
used the recommended definition. I then removed Embedding.hsc, because
it was empty. Since gtk_socket_get_plug_window() was added in 2.14,
socketHasPlug only works after that version.