Unfortunately, I'm not always clear on what is meant to be private in
elisp code.
For defensive coding I could add boundp checks to make sure the mark
rings are there. Either that or create a separate mark ring, and
commands that are alternatives to C-*.
Aside from semantic-ia, where else do we need to keep track of jump
history? I seem to recall there was also senator. However, isn't
senator deprecated?
On Mon, Mar 19, 2012 at 4:51 AM, Eric M. Ludlam <ericludlam@...> wrote:
> Hi Brendan,
>
> Thanks for the patch. Sorry I was late responding.
>
> This reminds me of when I was looking up how to do this. I think I paused
> before doing something similar because I was wary of modifying variables
> that appeared to be private to etags. If Emacs were to modify how they
> handled tags, CEDET would break, or just not work quite right, and I wasn't
> sure how to handle the detection.
>
> Anyway, I agree with the principle of this patch. Since there are other
> locations in CEDET that do tag jumping, this logic will need to be
> formalized, and have some defensive coding around it.
>
> Eric
>
>
> On 03/14/2012 07:28 PM, Brendan Miller wrote:
>>
>> Woops, some unrelated stuff got picked up in that patch... I'm
>> actually not sure why, as I haven't modified anything but
>> semantic-ia.el.
>>
>> Here's a version with the extraneous stuff deleted.
>>
>> On Wed, Mar 14, 2012 at 4:25 PM, Brendan Miller<catphive@...>
>> wrote:
>>>
>>> Here's a short patch for semantic-ia.el to support the GNU Emacs etags
>>> tag ring. With this patch, you can jump backwards from points jumped
>>> to with semantic-ia-fast-jump with C-* in the same way you can with
>>> etags.
>>>
>>> This won't work on xemacs since it has a different tag mechanism. I
>>> remember asking about this quite a while ago, and it sounded like
>>> xemacs is no longer supported anyway? I removed the xemacs specific
>>> push-tag-mark code for that reason.
>>>
>>> If you wanted to make it work with both GNU emacs and xemacs, it would
>>> be a matter of adding fbound checks to the ring-insert functions,
>>> which are GNU emacs specific.
>>>
>>> Brendan Miller
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> This SF email is sponsosred by:
>>> Try Windows Azure free for 90 days Click Here
>>> http://p.sf.net/sfu/sfd2d-msazure
>>>
>>>
>>> _______________________________________________
>>> Cedet-devel mailing list
>>> Cedet-devel@...
>>> https://lists.sourceforge.net/lists/listinfo/cedet-devel
|