Home / Browse / Inkscape / Mail / Archive

Donate

Inkscape

Email Archive: inkscape-devel (read-only)

2003:	_Jan	_Feb	_Mar	_Apr	_May	_Jun	_Jul	_Aug	_Sep	_Oct (24)	_Nov (524)	_Dec (655)
2004:	_Jan (515)	_Feb (624)	_Mar (407)	_Apr (593)	_May (422)	_Jun (529)	_Jul (737)	_Aug (448)	_Sep (343)	_Oct (503)	_Nov (593)	_Dec (474)
2005:	_Jan (771)	_Feb (602)	_Mar (588)	_Apr (488)	_May (218)	_Jun (544)	_Jul (889)	_Aug (657)	_Sep (781)	_Oct (486)	_Nov (750)	_Dec (409)
2006:	_Jan (442)	_Feb (242)	_Mar (303)	_Apr (617)	_May (811)	_Jun (525)	_Jul (367)	_Aug (318)	_Sep (202)	_Oct (395)	_Nov (260)	_Dec (185)
2007:	_Jan (525)	_Feb (554)	_Mar (494)	_Apr (344)	_May (168)	_Jun (295)	_Jul (459)	_Aug (468)	_Sep (390)	_Oct (558)	_Nov (351)	_Dec (487)
2008:	_Jan (583)	_Feb (471)	_Mar (979)	_Apr (436)	_May (335)	_Jun (368)	_Jul (281)	_Aug (239)	_Sep (243)	_Oct (338)	_Nov (248)	_Dec (149)
2009:	_Jan (465)	_Feb (349)	_Mar (388)	_Apr (415)	_May (211)	_Jun (226)	_Jul (262)	_Aug (376)	_Sep (419)	_Oct (370)	_Nov (257)	_Dec (449)
2010:	_Jan (377)	_Feb (268)	_Mar (345)	_Apr (281)	_May (73)	_Jun (192)	_Jul (336)	_Aug (201)	_Sep (328)	_Oct (131)	_Nov (162)	_Dec (248)
2011:	_Jan (138)	_Feb (182)	_Mar (241)	_Apr (174)	_May (64)	_Jun (321)	_Jul (220)	_Aug (139)	_Sep (214)	_Oct (174)	_Nov (91)	_Dec (119)
2012:	_Jan (182)	_Feb (260)	_Mar (207)	_Apr (119)	_May (118)	_Jun (150)	_Jul (72)	_Aug (125)	_Sep (137)	_Oct (187)	_Nov (122)	_Dec (131)
2013:	_Jan (151)	_Feb (128)	_Mar (290)	_Apr (236)	_May (113)	_Jun	_Jul	_Aug	_Sep	_Oct	_Nov	_Dec

Re: [Inkscape-devel] [Inkscape-cvs] SF.net SVN: inkscape: [15827] inkscape/trunk/src/ui/dialog

From: <joel@ai...> - 2007-08-19 09:48

Attachments: Message as HTML

I figured out what the problem was now. In my version, I made changes in fi=
le.cpp, which I managed to miss comitting. I'm very sorry for all the incon=
venience. I assumed you were asleep, and I was hoping to slip the change in=
 quickly before you woke up - well that worked out just great!=0D=0A=0D=0AO=
n the subject of file.cpp, the line in the current SVN version=0D=0A     ex=
portDialogInstance =3D Inkscape::UI::Dialog::FileExportToOCALDialog::create=
(=0D=0Awas=0D=0A     exportDialogInstance =3D new Inkscape::UI::Dialog::Fil=
eExportToOCALDialog(=0D=0Ain my version.=0D=0A=0D=0ACan I suggest that you =
do the same, when you're ready? There's no need to have separate dialog and=
 impl classes in this case. If possible I suggest you begin to merge the fu=
nctionality of the two classes, do away with the class factory, and just ex=
pose the constructor directly. This sounds like a big deal, but actually it=
 only took me about 10 minutes to do.=0D=0A=0D=0AHope that helps=0D=0A=0D=
=0ABest Regards=0D=0AJoel=0D=0A=0D=0A--------------------------------------=
--=0D=0AFrom: "Bruno Dilly" <bruno.dilly@...: Sunday, Augu=
st 19, 2007 10:09 AM=0D=0ATo: joel@...: Re: [I=
nkscape-devel] [Inkscape-cvs] SF.net SVN: inkscape: [15827] inkscape/trunk/=
src/ui/dialog =0D=0A=0D=0ABut I think I didn't erased any modification.=0D=
=0A=0D=0AI just included in the file.cpp you have commited the following it=
ens:=0D=0A - an #include "ui/dialog/ocaldialogs.h"=0D=0A - the password ver=
ification inside the export to ocal function=0D=0A=0D=0ABut if you think is=
 necessary to revert, do it, and I will fix it=0D=0Alater, if necessary.=0D=
=0A=0D=0AOn 8/19/07, joel@...  wrote:=0D=0A> Well it's good=
 that you fixed it. I'm confused though, because I tested and=0D=0A> compil=
ed my revised version *several* times. Did you guys try running=0D=0A> ./au=
togen ? Now file.cpp needs to be reverted, as my version did away with=0D=
=0A> the class factories.=0D=0A>=0D=0A> ________________________________=0D=
=0A> From: Jon Phillips =0D=0A> Sent: Sunday, August 19, 2007 6:30 AM=0D=0A=
> To: Bruno Dilly =0D=0A> Subject: Re: [Inkscape-devel] [Inkscape-cvs] SF.n=
et SVN: inkscape: [15827]=0D=0A> inkscape/trunk/src/ui/dialog=0D=0A>=0D=0A>=
 On Sun, 2007-08-19 at 02:11 -0300, Bruno Dilly wrote:=0D=0A> > I was doing=
 the same thing as Joel, and I was including the login=0D=0A> > dialog used=
 to export to ocal.=0D=0A> >=0D=0A> > So I commited my ocaldialogs.ccp and =
ocaldialogs.h, and now things look=0D=0A> fine.=0D=0A>=0D=0A> Whoa, you guy=
s gotta inter-communi-kate ;)=0D=0A>=0D=0A> Jon=0D=0A>=0D=0A> > On 8/19/07,=
 MenTaLguY wrote:=0D=0A> > > Joel, your recent commit appears to have broke=
n the build.=0D=0A> > >=0D=0A> > > Please fix it so we can get back to work=
.=0D=0A> > >=0D=0A> > > Thanks,=0D=0A> > >=0D=0A> > > -mental=0D=0A> > >=0D=
=0A> > > On Sat, 2007-08-18 at 17:29 -0700,=0D=0A> joelholdsworth@...=
rceforge.net=0D=0A> > > wrote:=0D=0A> > > > Revision: 15827=0D=0A> > > >=0D=
=0A> http://inkscape.svn.sourceforge.net/inkscape/?rev=3D15827&view=3Drev=
=0D=0A> > > > Author: joelholdsworth=0D=0A> > > > Date: 2007-08-18 17:29:36=
 -0700 (Sat, 18 Aug 2007)=0D=0A> > > >=0D=0A> > > > Log Message:=0D=0A> > >=
 > -----------=0D=0A> > > > Separated the OCAL import and export dialogs in=
to their own source=0D=0A> file - ocaldialogs.cpp and ocaldialogs.h=0D=0A> =
> > >=0D=0A> > > > Modified Paths:=0D=0A> > > > --------------=0D=0A> > > >=
 inkscape/trunk/src/ui/dialog/Makefile_insert=0D=0A> > > > inkscape/trunk/s=
rc/ui/dialog/filedialog.cpp=0D=0A> > > > inkscape/trunk/src/ui/dialog/filed=
ialog.h=0D=0A> > > > inkscape/trunk/src/ui/dialog/filedialogimpl-gtkmm.cpp=
=0D=0A> > > > inkscape/trunk/src/ui/dialog/filedialogimpl-gtkmm.h=0D=0A> > =
> >=0D=0A> > > > Added Paths:=0D=0A> > > > -----------=0D=0A> > > > inkscap=
e/trunk/src/ui/dialog/ocaldialogs.cpp=0D=0A> > > > inkscape/trunk/src/ui/di=
alog/ocaldialogs.h=0D=0A> > > >=0D=0A> > > >=0D=0A> > > > This was sent by =
the SourceForge.net collaborative development=0D=0A> platform, the world's =
largest Open Source development site.=0D=0A> > > >=0D=0A> > > >=0D=0A> ----=
---------------------------------------------------------------------=0D=0A=
> > > > This SF.net email is sponsored by: Splunk Inc.=0D=0A> > > > Still g=
repping through log files to find problems? Stop.=0D=0A> > > > Now Search l=
og events and configuration files using AJAX and a=0D=0A> browser.=0D=0A> >=
 > > Download your FREE copy of Splunk now >> http://get.splunk.com/=0D=0A>=
 > > > _______________________________________________=0D=0A> > > > Inkscap=
e-cvs mailing list=0D=0A> > > > Inkscape-cvs@...> >=
 > >=0D=0A> https://lists.sourceforge.net/lists/listinfo/inkscape-cvs=0D=0A=
> > >=0D=0A> > >=0D=0A> ---------------------------------------------------=
----------------------=0D=0A> > > This SF.net email is sponsored by: Splunk=
 Inc.=0D=0A> > > Still grepping through log files to find problems? Stop.=
=0D=0A> > > Now Search log events and configuration files using AJAX and a =
browser.=0D=0A> > > Download your FREE copy of Splunk now >> http://get.spl=
unk.com/=0D=0A> > > _______________________________________________=0D=0A> =
> > Inkscape-devel mailing list=0D=0A> > > Inkscape-devel@...=
.net=0D=0A> > >=0D=0A> https://lists.sourceforge.net/lists/listinfo/inkscap=
e-devel=0D=0A> > >=0D=0A> > >=0D=0A> > >=0D=0A> >=0D=0A> >=0D=0A> ---------=
----------------------------------------------------------------=0D=0A> > T=
his SF.net email is sponsored by: Splunk Inc.=0D=0A> > Still grepping throu=
gh log files to find problems? Stop.=0D=0A> > Now Search log events and con=
figuration files using AJAX and a browser.=0D=0A> > Download your FREE copy=
 of Splunk now >> http://get.splunk.com/=0D=0A> > _________________________=
______________________=0D=0A> > Inkscape-devel mailing list=0D=0A> > Inksca=
pe-devel@...> >=0D=0A> https://lists.sourceforge.ne=
t/lists/listinfo/inkscape-devel=0D=0A> --=0D=0A> Jon Phillips=0D=0A>=0D=0A>=
 San Francisco, CA=0D=0A> USA PH 510.499.0894=0D=0A> jon@...> h=
ttp://www.rejon.org=0D=0A>=0D=0A> MSN, AIM, Yahoo Chat: kidproto=0D=0A> Jab=
ber Chat: rejon@...> IRC: rejon@...=
>=0D=0A> ------------------------------------------------------------------=
-------=0D=0A> This SF.net email is sponsored by: Splunk Inc.=0D=0A> Still =
grepping through log files to find problems? Stop.=0D=0A> Now Search log ev=
ents and configuration files using AJAX and a browser.=0D=0A> Download your=
 FREE copy of Splunk now >> http://get.splunk.com/=0D=0A> _________________=
______________________________=0D=0A> Inkscape-devel mailing list=0D=0A> In=
kscape-devel@...> https://lists.sourceforge.net/lis=
ts/listinfo/inkscape-devel=0D=0A>=0D=0A>=0D=0A>=0D=0A> --------------------=
-----------------------------------------------------=0D=0A> This SF.net em=
ail is sponsored by: Splunk Inc.=0D=0A> Still grepping through log files to=
 find problems?  Stop.=0D=0A> Now Search log events and configuration files=
 using AJAX and a browser.=0D=0A> Download your FREE copy of Splunk now >> =
 http://get.splunk.com/=0D=0A> ____________________________________________=
___=0D=0A> Inkscape-devel mailing list=0D=0A> Inkscape-devel@...=
rge.net=0D=0A> https://lists.sourceforge.net/lists/listinfo/inkscape-devel=
=0D=0A>=0D=0A>=0D=0A=0D=0A

Re: [Inkscape-devel] [Inkscape-cvs] SF.net SVN: inkscape: [15827] inkscape/trunk/src/ui/dialog

From: Bruno Dilly <bruno.dilly@gm...> - 2007-08-19 09:54

OK Joel, I will do it soon. Thanks for the help  =)

On 8/19/07, joel@... <joel@...> wrote:
> I figured out what the problem was now. In my version, I made changes in
> file.cpp, which I managed to miss comitting. I'm very sorry for all the
> inconvenience. I assumed you were asleep, and I was hoping to slip the
> change in quickly before you woke up - well that worked out just great!
>
> On the subject of file.cpp, the line in the current SVN version
>      exportDialogInstance =
> Inkscape::UI::Dialog::FileExportToOCALDialog::create(
> was
>      exportDialogInstance = new
> Inkscape::UI::Dialog::FileExportToOCALDialog(
> in my version.
>
> Can I suggest that you do the same, when you're ready? There's no need to
> have separate dialog and impl classes in this case. If possible I suggest
> you begin to merge the functionality of the two classes, do away with the
> class factory, and just expose the constructor directly. This sounds like a
> big deal, but actually it only took me about 10 minutes to do.
>
> Hope that helps
>
> Best Regards
> Joel
>
> ________________________________
> From: "Bruno Dilly" <bruno.dilly@...>
> Sent: Sunday, August 19, 2007 10:09 AM
> To: joel@...
> Subject: Re: [Inkscape-devel] [Inkscape-cvs] SF.net SVN: inkscape: [15827]
> inkscape/trunk/src/ui/dialog
>
> But I think I didn't erased any modification.
>
> I just included in the file.cpp you have commited the following itens:
>  - an #include "ui/dialog/ocaldialogs.h"
>  - the password verification inside the export to ocal function
>
> But if you think is necessary to revert, do it, and I will fix it
> later, if necessary.
>
> On 8/19/07, joel@... wrote:
> > Well it's good that you fixed it. I'm confused though, because I tested
> and
> > compiled my revised version *several* times. Did you guys try running
> > ./autogen ? Now file.cpp needs to be reverted, as my version did away with
> > the class factories.
> >
> > ________________________________
> > From: Jon Phillips
> > Sent: Sunday, August 19, 2007 6:30 AM
> > To: Bruno Dilly
> > Subject: Re: [Inkscape-devel] [Inkscape-cvs] SF.net SVN: inkscape: [15827]
> > inkscape/trunk/src/ui/dialog
> >
> > On Sun, 2007-08-19 at 02:11 -0300, Bruno Dilly wrote:
> > > I was doing the same thing as Joel, and I was including the login
> > > dialog used to export to ocal.
> > >
> > > So I commited my ocaldialogs.ccp and ocaldialogs.h, and now things look
> > fine.
> >
> > Whoa, you guys gotta inter-communi-kate ;)
> >
> > Jon
> >
> > > On 8/19/07, MenTaLguY wrote:
> > > > Joel, your recent commit appears to have broken the build.
> > > >
> > > > Please fix it so we can get back to work.
> > > >
> > > > Thanks,
> > > >
> > > > -mental
> > > >
> > > > On Sat, 2007-08-18 at 17:29 -0700,
> > joelholdsworth@...
> > > > wrote:
> > > > > Revision: 15827
> > > > >
> >
> http://inkscape.svn.sourceforge.net/inkscape/?rev=15827&view=rev
> > > > > Author: joelholdsworth
> > > > > Date: 2007-08-18 17:29:36 -0700 (Sat, 18 Aug 2007)
> > > > >
> > > > > Log Message:
> > > > > -----------
> > > > > Separated the OCAL import and export dialogs into their own source
> > file - ocaldialogs.cpp and ocaldialogs.h
> > > > >
> > > > > Modified Paths:
> > > > > --------------
> > > > > inkscape/trunk/src/ui/dialog/Makefile_insert
> > > > > inkscape/trunk/src/ui/dialog/filedialog.cpp
> > > > > inkscape/trunk/src/ui/dialog/filedialog.h
> > > > >
> inkscape/trunk/src/ui/dialog/filedialogimpl-gtkmm.cpp
> > > > > inkscape/trunk/src/ui/dialog/filedialogimpl-gtkmm.h
> > > > >
> > > > > Added Paths:
> > > > > -----------
> > > > > inkscape/trunk/src/ui/dialog/ocaldialogs.cpp
> > > > > inkscape/trunk/src/ui/dialog/ocaldialogs.h
> > > > >
> > > > >
> > > > > This was sent by the SourceForge.net collaborative development
> > platform, the world's largest Open Source development site.
> > > > >
> > > > >
> >
> -------------------------------------------------------------------------
> > > > > This SF.net email is sponsored by: Splunk Inc.
> > > > > Still grepping through log files to find problems? Stop.
> > > > > Now Search log events and configuration files using AJAX and a
> > browser.
> > > > > Download your FREE copy of Splunk now >> http://get.splunk.com/
> > > > > _______________________________________________
> > > > > Inkscape-cvs mailing list
> > > > > Inkscape-cvs@...
> > > > >
> > https://lists.sourceforge.net/lists/listinfo/inkscape-cvs
> > > >
> > > >
> >
> -------------------------------------------------------------------------
> > > > This SF.net email is sponsored by: Splunk Inc.
> > > > Still grepping through log files to find problems? Stop.
> > > > Now Search log events and configuration files using AJAX and a
> browser.
> > > > Download your FREE copy of Splunk now >> http://get.splunk.com/
> > > > _______________________________________________
> > > > Inkscape-devel mailing list
> > > > Inkscape-devel@...
> > > >
> >
> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
> > > >
> > > >
> > > >
> > >
> > >
> >
> -------------------------------------------------------------------------
> > > This SF.net email is sponsored by: Splunk Inc.
> > > Still grepping through log files to find problems? Stop.
> > > Now Search log events and configuration files using AJAX and a browser.
> > > Download your FREE copy of Splunk now >> http://get.splunk.com/
> > > _______________________________________________
> > > Inkscape-devel mailing list
> > > Inkscape-devel@...
> > >
> >
> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
> > --
> > Jon Phillips
> >
> > San Francisco, CA
> > USA PH 510.499.0894
> > jon@...
> > http://www.rejon.org
> >
> > MSN, AIM, Yahoo Chat: kidproto
> > Jabber Chat: rejon@...
> > IRC: rejon@...
> >
> >
> >
> -------------------------------------------------------------------------
> > This SF.net email is sponsored by: Splunk Inc.
> > Still grepping through log files to find problems? Stop.
> > Now Search log events and configuration files using AJAX and a browser.
> > Download your FREE copy of Splunk now >> http://get.splunk.com/
> > _______________________________________________
> > Inkscape-devel mailing list
> > Inkscape-devel@...
> >
> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
> >
> >
> >
> >
> -------------------------------------------------------------------------
> > This SF.net email is sponsored by: Splunk Inc.
> > Still grepping through log files to find problems? Stop.
> > Now Search log events and configuration files using AJAX and a browser.
> > Download your FREE copy of Splunk now >> http://get.splunk.com/
> > _______________________________________________
> > Inkscape-devel mailing list
> > Inkscape-devel@...
> >
> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
> >
> >
>
>

Re: [Inkscape-devel] [Inkscape-cvs] SF.net SVN: inkscape: [15827] inkscape/trunk/src/ui/dialog

From: <joel@ai...> - 2007-08-19 10:11

Attachments: Message as HTML

Great, and I just noticed one other thing. =0D=0A=0D=0AIn ocaldialogs.h you=
 have the line  =0D=0A     FileDialogOCALBase(const Glib::ustring &title) :=
 Gtk::Dialog(title,true)=0D=0A=0D=0Awhere you call the constructor of Gtk::=
Dialog. Can you use instead the three parameter=0D=0Aversion where the pare=
nt window is specified as the second parameter? Like this...=0D=0A=0D=0A   =
  FileDialogOCALBase(const Glib::ustring &title, Gtk::Window& parent) : Gtk=
::Dialog(title, parent, true)  =0D=0A=0D=0AThis should be pretty easy consi=
dering the OCAL classes already get a reference=0D=0Ato the parent window f=
rom file.cpp. The advantage of doing this for Windows users, is =0D=0Athat =
it stops your dialogs sinking down behind the inkscape desktop if someone c=
licks=0D=0Aon it.=0D=0A Best regards=0D=0AJoel=0D=0A=0D=0A-----------------=
-----------------------=0D=0AFrom: "Bruno Dilly" <bruno.dilly@...=
=0ASent: 19 August 2007 10:54=0D=0ATo: joel@...=
t: Re: [Inkscape-devel] [Inkscape-cvs] SF.net SVN: inkscape: [15827] inksca=
pe/trunk/src/ui/dialog =0D=0A=0D=0AOK Joel, I will do it soon. Thanks for t=
he help  =3D)=0D=0A=0D=0AOn 8/19/07, joel@...  wrote:=0D=0A=
> I figured out what the problem was now. In my version, I made changes in=
=0D=0A> file.cpp, which I managed to miss comitting. I'm very sorry for all=
 the=0D=0A> inconvenience. I assumed you were asleep, and I was hoping to s=
lip the=0D=0A> change in quickly before you woke up - well that worked out =
just great!=0D=0A>=0D=0A> On the subject of file.cpp, the line in the curre=
nt SVN version=0D=0A>      exportDialogInstance =3D=0D=0A> Inkscape::UI::Di=
alog::FileExportToOCALDialog::create(=0D=0A> was=0D=0A>      exportDialogIn=
stance =3D new=0D=0A> Inkscape::UI::Dialog::FileExportToOCALDialog(=0D=0A> =
in my version.=0D=0A>=0D=0A> Can I suggest that you do the same, when you'r=
e ready? There's no need to=0D=0A> have separate dialog and impl classes in=
 this case. If possible I suggest=0D=0A> you begin to merge the functionali=
ty of the two classes, do away with the=0D=0A> class factory, and just expo=
se the constructor directly. This sounds like a=0D=0A> big deal, but actual=
ly it only took me about 10 minutes to do.=0D=0A>=0D=0A> Hope that helps=0D=
=0A>=0D=0A> Best Regards=0D=0A> Joel=0D=0A>=0D=0A> ________________________=
________=0D=0A> From: "Bruno Dilly" =0D=0A> Sent: Sunday, August 19, 2007 1=
0:09 AM=0D=0A> To: joel@...> Subject: Re: [Inkscape-d=
evel] [Inkscape-cvs] SF.net SVN: inkscape: [15827]=0D=0A> inkscape/trunk/sr=
c/ui/dialog=0D=0A>=0D=0A> But I think I didn't erased any modification.=0D=
=0A>=0D=0A> I just included in the file.cpp you have commited the following=
 itens:=0D=0A>  - an #include "ui/dialog/ocaldialogs.h"=0D=0A>  - the passw=
ord verification inside the export to ocal function=0D=0A>=0D=0A> But if yo=
u think is necessary to revert, do it, and I will fix it=0D=0A> later, if n=
ecessary.=0D=0A>=0D=0A> On 8/19/07, joel@... wrote:=0D=0A> =
> Well it's good that you fixed it. I'm confused though, because I tested=
=0D=0A> and=0D=0A> > compiled my revised version *several* times. Did you g=
uys try running=0D=0A> > ./autogen ? Now file.cpp needs to be reverted, as =
my version did away with=0D=0A> > the class factories.=0D=0A> >=0D=0A> > __=
______________________________=0D=0A> > From: Jon Phillips=0D=0A> > Sent: S=
unday, August 19, 2007 6:30 AM=0D=0A> > To: Bruno Dilly=0D=0A> > Subject: R=
e: [Inkscape-devel] [Inkscape-cvs] SF.net SVN: inkscape: [15827]=0D=0A> > i=
nkscape/trunk/src/ui/dialog=0D=0A> >=0D=0A> > On Sun, 2007-08-19 at 02:11 -=
0300, Bruno Dilly wrote:=0D=0A> > > I was doing the same thing as Joel, and=
 I was including the login=0D=0A> > > dialog used to export to ocal.=0D=0A>=
 > >=0D=0A> > > So I commited my ocaldialogs.ccp and ocaldialogs.h, and now=
 things look=0D=0A> > fine.=0D=0A> >=0D=0A> > Whoa, you guys gotta inter-co=
mmuni-kate ;)=0D=0A> >=0D=0A> > Jon=0D=0A> >=0D=0A> > > On 8/19/07, MenTaLg=
uY wrote:=0D=0A> > > > Joel, your recent commit appears to have broken the =
build.=0D=0A> > > >=0D=0A> > > > Please fix it so we can get back to work.=
=0D=0A> > > >=0D=0A> > > > Thanks,=0D=0A> > > >=0D=0A> > > > -mental=0D=0A>=
 > > >=0D=0A> > > > On Sat, 2007-08-18 at 17:29 -0700,=0D=0A> > joelholdswo=
rth@...> > > > wrote:=0D=0A> > > > > Revision: 1582=
7=0D=0A> > > > >=0D=0A> >=0D=0A> http://inkscape.svn.sourceforge.net/inksca=
pe/?rev=3D15827&view=3Drev=0D=0A> > > > > Author: joelholdsworth=0D=0A> > >=
 > > Date: 2007-08-18 17:29:36 -0700 (Sat, 18 Aug 2007)=0D=0A> > > > >=0D=
=0A> > > > > Log Message:=0D=0A> > > > > -----------=0D=0A> > > > > Separat=
ed the OCAL import and export dialogs into their own source=0D=0A> > file -=
 ocaldialogs.cpp and ocaldialogs.h=0D=0A> > > > >=0D=0A> > > > > Modified P=
aths:=0D=0A> > > > > --------------=0D=0A> > > > > inkscape/trunk/src/ui/di=
alog/Makefile_insert=0D=0A> > > > > inkscape/trunk/src/ui/dialog/filedialog=
.cpp=0D=0A> > > > > inkscape/trunk/src/ui/dialog/filedialog.h=0D=0A> > > > =
>=0D=0A> inkscape/trunk/src/ui/dialog/filedialogimpl-gtkmm.cpp=0D=0A> > > >=
 > inkscape/trunk/src/ui/dialog/filedialogimpl-gtkmm.h=0D=0A> > > > >=0D=0A=
> > > > > Added Paths:=0D=0A> > > > > -----------=0D=0A> > > > > inkscape/t=
runk/src/ui/dialog/ocaldialogs.cpp=0D=0A> > > > > inkscape/trunk/src/ui/dia=
log/ocaldialogs.h=0D=0A> > > > >=0D=0A> > > > >=0D=0A> > > > > This was sen=
t by the SourceForge.net collaborative development=0D=0A> > platform, the w=
orld's largest Open Source development site.=0D=0A> > > > >=0D=0A> > > > >=
=0D=0A> >=0D=0A> ----------------------------------------------------------=
---------------=0D=0A> > > > > This SF.net email is sponsored by: Splunk In=
c.=0D=0A> > > > > Still grepping through log files to find problems? Stop.=
=0D=0A> > > > > Now Search log events and configuration files using AJAX an=
d a=0D=0A> > browser.=0D=0A> > > > > Download your FREE copy of Splunk now =
>> http://get.splunk.com/=0D=0A> > > > > __________________________________=
_____________=0D=0A> > > > > Inkscape-cvs mailing list=0D=0A> > > > > Inksc=
ape-cvs@...> > > > >=0D=0A> > https://lists.sourcef=
orge.net/lists/listinfo/inkscape-cvs=0D=0A> > > >=0D=0A> > > >=0D=0A> >=0D=
=0A> ----------------------------------------------------------------------=
---=0D=0A> > > > This SF.net email is sponsored by: Splunk Inc.=0D=0A> > > =
> Still grepping through log files to find problems? Stop.=0D=0A> > > > Now=
 Search log events and configuration files using AJAX and a=0D=0A> browser.=
=0D=0A> > > > Download your FREE copy of Splunk now >> http://get.splunk.co=
m/=0D=0A> > > > _______________________________________________=0D=0A> > > =
> Inkscape-devel mailing list=0D=0A> > > > Inkscape-devel@...=
.net=0D=0A> > > >=0D=0A> >=0D=0A> https://lists.sourceforge.net/lists/listi=
nfo/inkscape-devel=0D=0A> > > >=0D=0A> > > >=0D=0A> > > >=0D=0A> > >=0D=0A>=
 > >=0D=0A> >=0D=0A> ------------------------------------------------------=
-------------------=0D=0A> > > This SF.net email is sponsored by: Splunk In=
c.=0D=0A> > > Still grepping through log files to find problems? Stop.=0D=
=0A> > > Now Search log events and configuration files using AJAX and a bro=
wser.=0D=0A> > > Download your FREE copy of Splunk now >> http://get.splunk=
.com/=0D=0A> > > _______________________________________________=0D=0A> > >=
 Inkscape-devel mailing list=0D=0A> > > Inkscape-devel@...=
t=0D=0A> > >=0D=0A> >=0D=0A> https://lists.sourceforge.net/lists/listinfo/i=
nkscape-devel=0D=0A> > --=0D=0A> > Jon Phillips=0D=0A> >=0D=0A> > San Franc=
isco, CA=0D=0A> > USA PH 510.499.0894=0D=0A> > jon@...> > http:=
//www.rejon.org=0D=0A> >=0D=0A> > MSN, AIM, Yahoo Chat: kidproto=0D=0A> > J=
abber Chat: rejon@...> > IRC: rejon@...> >=
=0D=0A> >=0D=0A> >=0D=0A> -------------------------------------------------=
------------------------=0D=0A> > This SF.net email is sponsored by: Splunk=
 Inc.=0D=0A> > Still grepping through log files to find problems? Stop.=0D=
=0A> > Now Search log events and configuration files using AJAX and a brows=
er.=0D=0A> > Download your FREE copy of Splunk now >> http://get.splunk.com=
/=0D=0A> > _______________________________________________=0D=0A> > Inkscap=
e-devel mailing list=0D=0A> > Inkscape-devel@...> >=
=0D=0A> https://lists.sourceforge.net/lists/listinfo/inkscape-devel=0D=0A> =
>=0D=0A> >=0D=0A> >=0D=0A> >=0D=0A> ---------------------------------------=
----------------------------------=0D=0A> > This SF.net email is sponsored =
by: Splunk Inc.=0D=0A> > Still grepping through log files to find problems?=
 Stop.=0D=0A> > Now Search log events and configuration files using AJAX an=
d a browser.=0D=0A> > Download your FREE copy of Splunk now >> http://get.s=
plunk.com/=0D=0A> > _______________________________________________=0D=0A> =
> Inkscape-devel mailing list=0D=0A> > Inkscape-devel@...=
=0D=0A> >=0D=0A> https://lists.sourceforge.net/lists/listinfo/inkscape-deve=
l=0D=0A> >=0D=0A> >=0D=0A>=0D=0A>=0D=0A=0D=0A

Re: [Inkscape-devel] [Inkscape-cvs] SF.net SVN: inkscape: [15827] inkscape/trunk/src/ui/dialog

From: <joel@ai...> - 2007-08-19 10:25

Attachments: Message as HTML

Yeah, this actually is my policy. However let's say you have three files A.=
cpp B.cpp and C.cpp. If you commit the first two, but not the third, you'll=
 break the build, even though "svn up" says you're up to date. This is why =
I've now installed a GUI SVN client, which highlights modified files in red=
! :-)=0D=0A=0D=0A----------------------------------------=0D=0AFrom: Bob Ja=
mison <rwjj@...: Sunday, August 19, 2007 10:46 AM=0D=
=0ATo: inkscape-devel@...: Re: [Inkscape-dev=
el] [Inkscape-cvs] SF.net SVN: inkscape: [15827] inkscape/trunk/src/ui/dial=
og =0D=0A=0D=0AA good rule of thumb is to do an svn update just before doin=
g=0D=0Aan svn commit, just to make sure that there are no conflicts.=0D=0A=
=0D=0Abob=0D=0A=0D=0ABruno Dilly wrote:=0D=0A> But I think I didn't erased =
any modification.=0D=0A>=0D=0A> I just included in the file.cpp you have co=
mmited the following itens:=0D=0A>  - an #include "ui/dialog/ocaldialogs.h"=
=0D=0A>  - the password verification inside the export to ocal function=0D=
=0A>=0D=0A> But if you think is necessary to revert, do it, and I will fix =
it=0D=0A> later, if necessary.=0D=0A>=0D=0A> On 8/19/07, joel@....=
org.uk  wrote:=0D=0A>   =0D=0A>> Well it's good that you fixed it. I'm conf=
used though, because I tested and=0D=0A>> compiled my revised version *seve=
ral* times. Did you guys try running=0D=0A>> ./autogen ? Now file.cpp needs=
 to be reverted, as my version did away with=0D=0A>> the class factories.=
=0D=0A>>=0D=0A>> ________________________________=0D=0A>> From: Jon Phillip=
s =0D=0A>> Sent: Sunday, August 19, 2007 6:30 AM=0D=0A>> To: Bruno Dilly =
=0D=0A>> Subject: Re: [Inkscape-devel] [Inkscape-cvs] SF.net SVN: inkscape:=
 [15827]=0D=0A>> inkscape/trunk/src/ui/dialog=0D=0A>>=0D=0A>> On Sun, 2007-=
08-19 at 02:11 -0300, Bruno Dilly wrote:=0D=0A>>     =0D=0A>>> I was doing =
the same thing as Joel, and I was including the login=0D=0A>>> dialog used =
to export to ocal.=0D=0A>>>=0D=0A>>> So I commited my ocaldialogs.ccp and o=
caldialogs.h, and now things look=0D=0A>>>       =0D=0A>> fine.=0D=0A>>=0D=
=0A>> Whoa, you guys gotta inter-communi-kate ;)=0D=0A>>=0D=0A>> Jon=0D=0A>=
>=0D=0A>>     =0D=0A>>> On 8/19/07, MenTaLguY wrote:=0D=0A>>>       =0D=0A>=
>>> Joel, your recent commit appears to have broken the build.=0D=0A>>>>=0D=
=0A>>>> Please fix it so we can get back to work.=0D=0A>>>>=0D=0A>>>> Thank=
s,=0D=0A>>>>=0D=0A>>>> -mental=0D=0A>>>>=0D=0A>>>> On Sat, 2007-08-18 at 17=
:29 -0700,=0D=0A>>>>         =0D=0A>> joelholdsworth@...=
=0D=0A>>     =0D=0A>>>> wrote:=0D=0A>>>>         =0D=0A>>>>> Revision: 1582=
7=0D=0A>>>>>=0D=0A>>>>>           =0D=0A>> http://inkscape.svn.sourceforge.=
net/inkscape/?rev=3D15827&view=3Drev=0D=0A>>     =0D=0A>>>>> Author: joelho=
ldsworth=0D=0A>>>>> Date: 2007-08-18 17:29:36 -0700 (Sat, 18 Aug 2007)=0D=
=0A>>>>>=0D=0A>>>>> Log Message:=0D=0A>>>>> -----------=0D=0A>>>>> Separate=
d the OCAL import and export dialogs into their own source=0D=0A>>>>>      =
     =0D=0A>> file - ocaldialogs.cpp and ocaldialogs.h=0D=0A>>     =0D=0A>>=
>>> Modified Paths:=0D=0A>>>>> --------------=0D=0A>>>>> inkscape/trunk/src=
/ui/dialog/Makefile_insert=0D=0A>>>>> inkscape/trunk/src/ui/dialog/filedial=
og.cpp=0D=0A>>>>> inkscape/trunk/src/ui/dialog/filedialog.h=0D=0A>>>>> inks=
cape/trunk/src/ui/dialog/filedialogimpl-gtkmm.cpp=0D=0A>>>>> inkscape/trunk=
/src/ui/dialog/filedialogimpl-gtkmm.h=0D=0A>>>>>=0D=0A>>>>> Added Paths:=0D=
=0A>>>>> -----------=0D=0A>>>>> inkscape/trunk/src/ui/dialog/ocaldialogs.cp=
p=0D=0A>>>>> inkscape/trunk/src/ui/dialog/ocaldialogs.h=0D=0A>>>>>=0D=0A>>>=
>>=0D=0A>>>>> This was sent by the SourceForge.net collaborative developmen=
t=0D=0A>>>>>           =0D=0A>> platform, the world's largest Open Source d=
evelopment site.=0D=0A>>     =0D=0A>>>>>           =0D=0A>> ---------------=
----------------------------------------------------------=0D=0A>>     =0D=
=0A>>>>> This SF.net email is sponsored by: Splunk Inc.=0D=0A>>>>> Still gr=
epping through log files to find problems? Stop.=0D=0A>>>>> Now Search log =
events and configuration files using AJAX and a=0D=0A>>>>>           =0D=0A=
>> browser.=0D=0A>>     =0D=0A>>>>> Download your FREE copy of Splunk now >=
> http://get.splunk.com/=0D=0A>>>>> _______________________________________=
________=0D=0A>>>>> Inkscape-cvs mailing list=0D=0A>>>>> Inkscape-cvs@...=
.sourceforge.net=0D=0A>>>>>=0D=0A>>>>>           =0D=0A>> https://lists.sou=
rceforge.net/lists/listinfo/inkscape-cvs=0D=0A>>     =0D=0A>>>>         =0D=
=0A>> ---------------------------------------------------------------------=
----=0D=0A>>     =0D=0A>>>> This SF.net email is sponsored by: Splunk Inc.=
=0D=0A>>>> Still grepping through log files to find problems? Stop.=0D=0A>>=
>> Now Search log events and configuration files using AJAX and a browser.=
=0D=0A>>>> Download your FREE copy of Splunk now >> http://get.splunk.com/=
=0D=0A>>>> _______________________________________________=0D=0A>>>> Inksca=
pe-devel mailing list=0D=0A>>>> Inkscape-devel@...>=
>>>=0D=0A>>>>         =0D=0A>> https://lists.sourceforge.net/lists/listinfo=
/inkscape-devel=0D=0A>>     =0D=0A>>>>=0D=0A>>>>         =0D=0A>>>       =
=0D=0A>> ------------------------------------------------------------------=
-------=0D=0A>>     =0D=0A>>> This SF.net email is sponsored by: Splunk Inc=
.=0D=0A>>> Still grepping through log files to find problems? Stop.=0D=0A>>=
> Now Search log events and configuration files using AJAX and a browser.=
=0D=0A>>> Download your FREE copy of Splunk now >> http://get.splunk.com/=
=0D=0A>>> _______________________________________________=0D=0A>>> Inkscape=
-devel mailing list=0D=0A>>> Inkscape-devel@...>>>=
=0D=0A>>>       =0D=0A>> https://lists.sourceforge.net/lists/listinfo/inksc=
ape-devel=0D=0A>> --=0D=0A>> Jon Phillips=0D=0A>>=0D=0A>> San Francisco, CA=
=0D=0A>> USA PH 510.499.0894=0D=0A>> jon@...>> http://www.rejon=
.org=0D=0A>>=0D=0A>> MSN, AIM, Yahoo Chat: kidproto=0D=0A>> Jabber Chat: re=
jon@...>> IRC: rejon@...>>=
 -------------------------------------------------------------------------=
=0D=0A>> This SF.net email is sponsored by: Splunk Inc.=0D=0A>> Still grepp=
ing through log files to find problems? Stop.=0D=0A>> Now Search log events=
 and configuration files using AJAX and a browser.=0D=0A>> Download your FR=
EE copy of Splunk now >> http://get.splunk.com/=0D=0A>> ___________________=
____________________________=0D=0A>> Inkscape-devel mailing list=0D=0A>> In=
kscape-devel@...>> https://lists.sourceforge.net/li=
sts/listinfo/inkscape-devel=0D=0A>>=0D=0A>>=0D=0A>>=0D=0A>> ---------------=
----------------------------------------------------------=0D=0A>> This SF.=
net email is sponsored by: Splunk Inc.=0D=0A>> Still grepping through log f=
iles to find problems?  Stop.=0D=0A>> Now Search log events and configurati=
on files using AJAX and a browser.=0D=0A>> Download your FREE copy of Splun=
k now >>  http://get.splunk.com/=0D=0A>> __________________________________=
_____________=0D=0A>> Inkscape-devel mailing list=0D=0A>> Inkscape-devel@...=
sts.sourceforge.net=0D=0A>> https://lists.sourceforge.net/lists/listinfo/in=
kscape-devel=0D=0A>>=0D=0A>>=0D=0A>>     =0D=0A>=0D=0A> -------------------=
------------------------------------------------------=0D=0A> This SF.net e=
mail is sponsored by: Splunk Inc.=0D=0A> Still grepping through log files t=
o find problems?  Stop.=0D=0A> Now Search log events and configuration file=
s using AJAX and a browser.=0D=0A> Download your FREE copy of Splunk now >>=
  http://get.splunk.com/=0D=0A> ___________________________________________=
____=0D=0A> Inkscape-devel mailing list=0D=0A> Inkscape-devel@...=
orge.net=0D=0A> https://lists.sourceforge.net/lists/listinfo/inkscape-devel=
=0D=0A>=0D=0A>   =0D=0A=0D=0A----------------------------------------------=
---------------------------=0D=0AThis SF.net email is sponsored by: Splunk =
Inc.=0D=0AStill grepping through log files to find problems?  Stop.=0D=0ANo=
w Search log events and configuration files using AJAX and a browser.=0D=0A=
Download your FREE copy of Splunk now >>  http://get.splunk.com/=0D=0A_____=
__________________________________________=0D=0AInkscape-devel mailing list=
=0D=0AInkscape-devel@... href="0Ahttps://lists.sourceforge.n=" target="_new">0Ahttps://lists.sourceforge.n=
et/lists/listinfo/inkscape-devel=0D=0A=0D=0A

Re: [Inkscape-devel] [Inkscape-cvs] SF.net SVN: inkscape: [15827] inkscape/trunk/src/ui/dialog

From: Bruno Dilly <bruno.dilly@gm...> - 2007-08-20 04:14

Hey Joel,

I made the changes you've suggested. Thanks by the support.

On 8/19/07, joel@... <joel@...> wrote:
> Great, and I just noticed one other thing.
>
> In ocaldialogs.h you have the line
>      FileDialogOCALBase(const Glib::ustring &title) :
> Gtk::Dialog(title,true)
>
> where you call the constructor of Gtk::Dialog. Can you use instead the three
> parameter
> version where the parent window is specified as the second parameter? Like
> this...
>
>      FileDialogOCALBase(const Glib::ustring &title, Gtk::Window& parent) :
> Gtk::Dialog(title, parent, true)
>
> This should be pretty easy considering the OCAL classes already get a
> reference
> to the parent window from file.cpp. The advantage of doing this for Windows
> users, is
> that it stops your dialogs sinking down behind the inkscape desktop if
> someone clicks
> on it.
>
> Best regards
> Joel
>
> ________________________________
> From: "Bruno Dilly" <bruno.dilly@...>
> Sent: 19 August 2007 10:54
> To: joel@...
> Subject: Re: [Inkscape-devel] [Inkscape-cvs] SF.net SVN: inkscape: [15827]
> inkscape/trunk/src/ui/dialog
>
> OK Joel, I will do it soon. Thanks for the help =)
>
> On 8/19/07, joel@... wrote:
> > I figured out what the problem was now. In my version, I made changes in
> > file.cpp, which I managed to miss comitting. I'm very sorry for all the
> > inconvenience. I assumed you were asleep, and I was hoping to slip the
> > change in quickly before you woke up - well that worked out just great!
> >
> > On the subject of file.cpp, the line in the current SVN version
> > exportDialogInstance =
> > Inkscape::UI::Dialog::FileExportToOCALDialog::create(
> > was
> > exportDialogInstance = new
> > Inkscape::UI::Dialog::FileExportToOCALDialog(
> > in my version.
> >
> > Can I suggest that you do the same, when you're ready? There's no need to
> > have separate dialog and impl classes in this case. If possible I suggest
> > you begin to merge the functionality of the two classes, do away with the
> > class factory, and just expose the constructor directly. This sounds like
> a
> > big deal, but actually it only took me about 10 minutes to do.
> >
> > Hope that helps
> >
> > Best Regards
> > Joel
> >
> > ________________________________
> > From: "Bruno Dilly"
> > Sent: Sunday, August 19, 2007 10:09 AM
> > To: joel@...
> > Subject: Re: [Inkscape-devel] [Inkscape-cvs] SF.net SVN: inkscape: [15827]
> > inkscape/trunk/src/ui/dialog
> >
> > But I think I didn't erased any modification.
> >
> > I just included in the file.cpp you have commited the following itens:
> > - an #include "ui/dialog/ocaldialogs.h"
> > - the password verification inside the export to ocal function
> >
> > But if you think is necessary to revert, do it, and I will fix it
> > later, if necessary.
> >
> > On 8/19/07, joel@... wrote:
> > > Well it's good that you fixed it. I'm confused though, because I tested
> > and
> > > compiled my revised version *several* times. Did you guys try running
> > > ./autogen ? Now file.cpp needs to be reverted, as my version did away
> with
> > > the class factories.
> > >
> > > ________________________________
> > > From: Jon Phillips
> > > Sent: Sunday, August 19, 2007 6:30 AM
> > > To: Bruno Dilly
> > > Subject: Re: [Inkscape-devel] [Inkscape-cvs] SF.net SVN: inkscape:
> [15827]
> > > inkscape/trunk/src/ui/dialog
> > >
> > > On Sun, 2007-08-19 at 02:11 -0300, Bruno Dilly wrote:
> > > > I was doing the same thing as Joel, and I was including the login
> > > > dialog used to export to ocal.
> > > >
> > > > So I commited my ocaldialogs.ccp and ocaldialogs.h, and now things
> look
> > > fine.
> > >
> > > Whoa, you guys gotta inter-communi-kate ;)
> > >
> > > Jon
> > >
> > > > On 8/19/07, MenTaLguY wrote:
> > > > > Joel, your recent commit appears to have broken the build.
> > > > >
> > > > > Please fix it so we can get back to work.
> > > > >
> > > > > Thanks,
> > > > >
> > > > > -mental
> > > > >
> > > > > On Sat, 2007-08-18 at 17:29 -0700,
> > > joelholdsworth@...
> > > > > wrote:
> > > > > > Revision: 15827
> > > > > >
> > >
> >
> http://inkscape.svn.sourceforge.net/inkscape/?rev=15827&view=rev
> > > > > > Author: joelholdsworth
> > > > > > Date: 2007-08-18 17:29:36 -0700 (Sat, 18 Aug 2007)
> > > > > >
> > > > > > Log Message:
> > > > > > -----------
> > > > > > Separated the OCAL import and export dialogs into their own source
> > > file - ocaldialogs.cpp and ocaldialogs.h
> > > > > >
> > > > > > Modified Paths:
> > > > > > --------------
> > > > > > inkscape/trunk/src/ui/dialog/Makefile_insert
> > > > > > inkscape/trunk/src/ui/dialog/filedialog.cpp
> > > > > > inkscape/trunk/src/ui/dialog/filedialog.h
> > > > > >
> > inkscape/trunk/src/ui/dialog/filedialogimpl-gtkmm.cpp
> > > > > >
> inkscape/trunk/src/ui/dialog/filedialogimpl-gtkmm.h
> > > > > >
> > > > > > Added Paths:
> > > > > > -----------
> > > > > > inkscape/trunk/src/ui/dialog/ocaldialogs.cpp
> > > > > > inkscape/trunk/src/ui/dialog/ocaldialogs.h
> > > > > >
> > > > > >
> > > > > > This was sent by the SourceForge.net collaborative development
> > > platform, the world's largest Open Source development site.
> > > > > >
> > > > > >
> > >
> >
> -------------------------------------------------------------------------
> > > > > > This SF.net email is sponsored by: Splunk Inc.
> > > > > > Still grepping through log files to find problems? Stop.
> > > > > > Now Search log events and configuration files using AJAX and a
> > > browser.
> > > > > > Download your FREE copy of Splunk now >> http://get.splunk.com/
> > > > > > _______________________________________________
> > > > > > Inkscape-cvs mailing list
> > > > > > Inkscape-cvs@...
> > > > > >
> > >
> https://lists.sourceforge.net/lists/listinfo/inkscape-cvs
> > > > >
> > > > >
> > >
> >
> -------------------------------------------------------------------------
> > > > > This SF.net email is sponsored by: Splunk Inc.
> > > > > Still grepping through log files to find problems? Stop.
> > > > > Now Search log events and configuration files using AJAX and a
> > browser.
> > > > > Download your FREE copy of Splunk now >> http://get.splunk.com/
> > > > > _______________________________________________
> > > > > Inkscape-devel mailing list
> > > > > Inkscape-devel@...
> > > > >
> > >
> >
> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > >
> >
> -------------------------------------------------------------------------
> > > > This SF.net email is sponsored by: Splunk Inc.
> > > > Still grepping through log files to find problems? Stop.
> > > > Now Search log events and configuration files using AJAX and a
> browser.
> > > > Download your FREE copy of Splunk now >> http://get.splunk.com/
> > > > _______________________________________________
> > > > Inkscape-devel mailing list
> > > > Inkscape-devel@...
> > > >
> > >
> >
> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
> > > --
> > > Jon Phillips
> > >
> > > San Francisco, CA
> > > USA PH 510.499.0894
> > > jon@...
> > > http://www.rejon.org
> > >
> > > MSN, AIM, Yahoo Chat: kidproto
> > > Jabber Chat: rejon@...
> > > IRC: rejon@...
> > >
> > >
> > >
> >
> -------------------------------------------------------------------------
> > > This SF.net email is sponsored by: Splunk Inc.
> > > Still grepping through log files to find problems? Stop.
> > > Now Search log events and configuration files using AJAX and a browser.
> > > Download your FREE copy of Splunk now >> http://get.splunk.com/
> > > _______________________________________________
> > > Inkscape-devel mailing list
> > > Inkscape-devel@...
> > >
> >
> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
> > >
> > >
> > >
> > >
> >
> -------------------------------------------------------------------------
> > > This SF.net email is sponsored by: Splunk Inc.
> > > Still grepping through log files to find problems? Stop.
> > > Now Search log events and configuration files using AJAX and a browser.
> > > Download your FREE copy of Splunk now >> http://get.splunk.com/
> > > _______________________________________________
> > > Inkscape-devel mailing list
> > > Inkscape-devel@...
> > >
> >
> https://lists.sourceforge.net/lists/listinfo/inkscape-devel
> > >
> > >
> >
> >
>
>

Re: [Inkscape-devel] [Inkscape-cvs] SF.net SVN: inkscape: [15827] inkscape/trunk/src/ui/dialog

From: <joel@ai...> - 2007-08-20 08:22

Attachments: Message as HTML

Oh good work; well done!=0D=0A=0D=0A---------------------------------------=
-=0D=0AFrom: "Bruno Dilly" <bruno.dilly@...: 20 August 200=
7 05:15=0D=0ATo: joel@...: Re: [Inkscape-devel=
] [Inkscape-cvs] SF.net SVN: inkscape: [15827] inkscape/trunk/src/ui/dialog=
 =0D=0A=0D=0AHey Joel,=0D=0A=0D=0AI made the changes you've suggested. Than=
ks by the support.=0D=0A=0D=0AOn 8/19/07, joel@...  wrote:=
=0D=0A> Great, and I just noticed one other thing.=0D=0A>=0D=0A> In ocaldia=
logs.h you have the line=0D=0A>      FileDialogOCALBase(const Glib::ustring=
 &title) :=0D=0A> Gtk::Dialog(title,true)=0D=0A>=0D=0A> where you call the =
constructor of Gtk::Dialog. Can you use instead the three=0D=0A> parameter=
=0D=0A> version where the parent window is specified as the second paramete=
r? Like=0D=0A> this...=0D=0A>=0D=0A>      FileDialogOCALBase(const Glib::us=
tring &title, Gtk::Window& parent) :=0D=0A> Gtk::Dialog(title, parent, true=
)=0D=0A>=0D=0A> This should be pretty easy considering the OCAL classes alr=
eady get a=0D=0A> reference=0D=0A> to the parent window from file.cpp. The =
advantage of doing this for Windows=0D=0A> users, is=0D=0A> that it stops y=
our dialogs sinking down behind the inkscape desktop if=0D=0A> someone clic=
ks=0D=0A> on it.=0D=0A>=0D=0A> Best regards=0D=0A> Joel=0D=0A>=0D=0A> _____=
___________________________=0D=0A> From: "Bruno Dilly" =0D=0A> Sent: 19 Aug=
ust 2007 10:54=0D=0A> To: joel@...> Subject: Re: [Ink=
scape-devel] [Inkscape-cvs] SF.net SVN: inkscape: [15827]=0D=0A> inkscape/t=
runk/src/ui/dialog=0D=0A>=0D=0A> OK Joel, I will do it soon. Thanks for the=
 help =3D)=0D=0A>=0D=0A> On 8/19/07, joel@... wrote:=0D=0A>=
 > I figured out what the problem was now. In my version, I made changes in=
=0D=0A> > file.cpp, which I managed to miss comitting. I'm very sorry for a=
ll the=0D=0A> > inconvenience. I assumed you were asleep, and I was hoping =
to slip the=0D=0A> > change in quickly before you woke up - well that worke=
d out just great!=0D=0A> >=0D=0A> > On the subject of file.cpp, the line in=
 the current SVN version=0D=0A> > exportDialogInstance =3D=0D=0A> > Inkscap=
e::UI::Dialog::FileExportToOCALDialog::create(=0D=0A> > was=0D=0A> > export=
DialogInstance =3D new=0D=0A> > Inkscape::UI::Dialog::FileExportToOCALDialo=
g(=0D=0A> > in my version.=0D=0A> >=0D=0A> > Can I suggest that you do the =
same, when you're ready? There's no need to=0D=0A> > have separate dialog a=
nd impl classes in this case. If possible I suggest=0D=0A> > you begin to m=
erge the functionality of the two classes, do away with the=0D=0A> > class =
factory, and just expose the constructor directly. This sounds like=0D=0A> =
a=0D=0A> > big deal, but actually it only took me about 10 minutes to do.=
=0D=0A> >=0D=0A> > Hope that helps=0D=0A> >=0D=0A> > Best Regards=0D=0A> > =
Joel=0D=0A> >=0D=0A> > ________________________________=0D=0A> > From: "Bru=
no Dilly"=0D=0A> > Sent: Sunday, August 19, 2007 10:09 AM=0D=0A> > To: joel=
@airwebreathe.org.uk=0D=0A> > Subject: Re: [Inkscape-devel] [Inkscape-cvs] =
SF.net SVN: inkscape: [15827]=0D=0A> > inkscape/trunk/src/ui/dialog=0D=0A> =
>=0D=0A> > But I think I didn't erased any modification.=0D=0A> >=0D=0A> > =
I just included in the file.cpp you have commited the following itens:=0D=
=0A> > - an #include "ui/dialog/ocaldialogs.h"=0D=0A> > - the password veri=
fication inside the export to ocal function=0D=0A> >=0D=0A> > But if you th=
ink is necessary to revert, do it, and I will fix it=0D=0A> > later, if nec=
essary.=0D=0A> >=0D=0A> > On 8/19/07, joel@... wrote:=0D=0A=
> > > Well it's good that you fixed it. I'm confused though, because I test=
ed=0D=0A> > and=0D=0A> > > compiled my revised version *several* times. Did=
 you guys try running=0D=0A> > > ./autogen ? Now file.cpp needs to be rever=
ted, as my version did away=0D=0A> with=0D=0A> > > the class factories.=0D=
=0A> > >=0D=0A> > > ________________________________=0D=0A> > > From: Jon P=
hillips=0D=0A> > > Sent: Sunday, August 19, 2007 6:30 AM=0D=0A> > > To: Bru=
no Dilly=0D=0A> > > Subject: Re: [Inkscape-devel] [Inkscape-cvs] SF.net SVN=
: inkscape:=0D=0A> [15827]=0D=0A> > > inkscape/trunk/src/ui/dialog=0D=0A> >=
 >=0D=0A> > > On Sun, 2007-08-19 at 02:11 -0300, Bruno Dilly wrote:=0D=0A> =
> > > I was doing the same thing as Joel, and I was including the login=0D=
=0A> > > > dialog used to export to ocal.=0D=0A> > > >=0D=0A> > > > So I co=
mmited my ocaldialogs.ccp and ocaldialogs.h, and now things=0D=0A> look=0D=
=0A> > > fine.=0D=0A> > >=0D=0A> > > Whoa, you guys gotta inter-communi-kat=
e ;)=0D=0A> > >=0D=0A> > > Jon=0D=0A> > >=0D=0A> > > > On 8/19/07, MenTaLgu=
Y wrote:=0D=0A> > > > > Joel, your recent commit appears to have broken the=
 build.=0D=0A> > > > >=0D=0A> > > > > Please fix it so we can get back to w=
ork.=0D=0A> > > > >=0D=0A> > > > > Thanks,=0D=0A> > > > >=0D=0A> > > > > -m=
ental=0D=0A> > > > >=0D=0A> > > > > On Sat, 2007-08-18 at 17:29 -0700,=0D=
=0A> > > joelholdsworth@...> > > > > wrote:=0D=0A> =
> > > > > Revision: 15827=0D=0A> > > > > >=0D=0A> > >=0D=0A> >=0D=0A> http:=
//inkscape.svn.sourceforge.net/inkscape/?rev=3D15827&view=3Drev=0D=0A> > > =
> > > Author: joelholdsworth=0D=0A> > > > > > Date: 2007-08-18 17:29:36 -07=
00 (Sat, 18 Aug 2007)=0D=0A> > > > > >=0D=0A> > > > > > Log Message:=0D=0A>=
 > > > > > -----------=0D=0A> > > > > > Separated the OCAL import and expor=
t dialogs into their own source=0D=0A> > > file - ocaldialogs.cpp and ocald=
ialogs.h=0D=0A> > > > > >=0D=0A> > > > > > Modified Paths:=0D=0A> > > > > >=
 --------------=0D=0A> > > > > > inkscape/trunk/src/ui/dialog/Makefile_inse=
rt=0D=0A> > > > > > inkscape/trunk/src/ui/dialog/filedialog.cpp=0D=0A> > > =
> > > inkscape/trunk/src/ui/dialog/filedialog.h=0D=0A> > > > > >=0D=0A> > i=
nkscape/trunk/src/ui/dialog/filedialogimpl-gtkmm.cpp=0D=0A> > > > > >=0D=0A=
> inkscape/trunk/src/ui/dialog/filedialogimpl-gtkmm.h=0D=0A> > > > > >=0D=
=0A> > > > > > Added Paths:=0D=0A> > > > > > -----------=0D=0A> > > > > > i=
nkscape/trunk/src/ui/dialog/ocaldialogs.cpp=0D=0A> > > > > > inkscape/trunk=
/src/ui/dialog/ocaldialogs.h=0D=0A> > > > > >=0D=0A> > > > > >=0D=0A> > > >=
 > > This was sent by the SourceForge.net collaborative development=0D=0A> =
> > platform, the world's largest Open Source development site.=0D=0A> > > =
> > >=0D=0A> > > > > >=0D=0A> > >=0D=0A> >=0D=0A> -------------------------=
------------------------------------------------=0D=0A> > > > > > This SF.n=
et email is sponsored by: Splunk Inc.=0D=0A> > > > > > Still grepping throu=
gh log files to find problems? Stop.=0D=0A> > > > > > Now Search log events=
 and configuration files using AJAX and a=0D=0A> > > browser.=0D=0A> > > > =
> > Download your FREE copy of Splunk now >> http://get.splunk.com/=0D=0A> =
> > > > > _______________________________________________=0D=0A> > > > > > =
Inkscape-cvs mailing list=0D=0A> > > > > > Inkscape-cvs@...=
et=0D=0A> > > > > >=0D=0A> > >=0D=0A> https://lists.sourceforge.net/lists/l=
istinfo/inkscape-cvs=0D=0A> > > > >=0D=0A> > > > >=0D=0A> > >=0D=0A> >=0D=
=0A> ----------------------------------------------------------------------=
---=0D=0A> > > > > This SF.net email is sponsored by: Splunk Inc.=0D=0A> > =
> > > Still grepping through log files to find problems? Stop.=0D=0A> > > >=
 > Now Search log events and configuration files using AJAX and a=0D=0A> > =
browser.=0D=0A> > > > > Download your FREE copy of Splunk now >> http://get=
.splunk.com/=0D=0A> > > > > _______________________________________________=
=0D=0A> > > > > Inkscape-devel mailing list=0D=0A> > > > > Inkscape-devel@...=
ists.sourceforge.net=0D=0A> > > > >=0D=0A> > >=0D=0A> >=0D=0A> https://list=
s.sourceforge.net/lists/listinfo/inkscape-devel=0D=0A> > > > >=0D=0A> > > >=
 >=0D=0A> > > > >=0D=0A> > > >=0D=0A> > > >=0D=0A> > >=0D=0A> >=0D=0A> ----=
---------------------------------------------------------------------=0D=0A=
> > > > This SF.net email is sponsored by: Splunk Inc.=0D=0A> > > > Still g=
repping through log files to find problems? Stop.=0D=0A> > > > Now Search l=
og events and configuration files using AJAX and a=0D=0A> browser.=0D=0A> >=
 > > Download your FREE copy of Splunk now >> http://get.splunk.com/=0D=0A>=
 > > > _______________________________________________=0D=0A> > > > Inkscap=
e-devel mailing list=0D=0A> > > > Inkscape-devel@...=
=0A> > > >=0D=0A> > >=0D=0A> >=0D=0A> https://lists.sourceforge.net/lists/l=
istinfo/inkscape-devel=0D=0A> > > --=0D=0A> > > Jon Phillips=0D=0A> > >=0D=
=0A> > > San Francisco, CA=0D=0A> > > USA PH 510.499.0894=0D=0A> > > jon@...=
jon.org=0D=0A> > > http://www.rejon.org=0D=0A> > >=0D=0A> > > MSN, AIM, Yah=
oo Chat: kidproto=0D=0A> > > Jabber Chat: rejon@...> > > IRC:=
 rejon@...> > >=0D=0A> > >=0D=0A> > >=0D=0A> >=0D=0A> --=
-----------------------------------------------------------------------=0D=
=0A> > > This SF.net email is sponsored by: Splunk Inc.=0D=0A> > > Still gr=
epping through log files to find problems? Stop.=0D=0A> > > Now Search log =
events and configuration files using AJAX and a browser.=0D=0A> > > Downloa=
d your FREE copy of Splunk now >> http://get.splunk.com/=0D=0A> > > _______=
________________________________________=0D=0A> > > Inkscape-devel mailing =
list=0D=0A> > > Inkscape-devel@...> > >=0D=0A> >=0D=
=0A> https://lists.sourceforge.net/lists/listinfo/inkscape-devel=0D=0A> > >=
=0D=0A> > >=0D=0A> > >=0D=0A> > >=0D=0A> >=0D=0A> -------------------------=
------------------------------------------------=0D=0A> > > This SF.net ema=
il is sponsored by: Splunk Inc.=0D=0A> > > Still grepping through log files=
 to find problems? Stop.=0D=0A> > > Now Search log events and configuration=
 files using AJAX and a browser.=0D=0A> > > Download your FREE copy of Splu=
nk now >> http://get.splunk.com/=0D=0A> > > _______________________________=
________________=0D=0A> > > Inkscape-devel mailing list=0D=0A> > > Inkscape=
-devel@...> > >=0D=0A> >=0D=0A> https://lists.sourc=
eforge.net/lists/listinfo/inkscape-devel=0D=0A> > >=0D=0A> > >=0D=0A> >=0D=
=0A> >=0D=0A>=0D=0A>=0D=0A=0D=0A

1 message has been excluded from this view by a project administrator.