On Fri, 2006-06-23 at 15:51 +0200, Radoslaw Korzeniewski wrote:
> > -----Original Message-----
> > From: sweep-devel-bounces@...
> > [mailto:sweep-devel-bounces@...] On Behalf
> > Of Steve Harris
> > Sent: Tuesday, June 20, 2006 11:55 AM
> > To: sweep-devel@...
> > Subject: Re: [sweep-devel] Two patches - one new, one old :)
> > OK, FWIW, the sample display function should use the sinc()
> > function to give you a correct impression of what the sampled
> > waveform looks like at over 1:1 magnification.
> Hi, You are right. I'll implement this interpolation in near future, so
> stay tuned :).
> I think about implementing sample display cache mechanism which will
> speedup drawing sample data and my new scrollbar panel.
it's probably a good idea if you create trac tickets for things that
you intend to implement, add an overview and then branch trunk
to work on it. (this is what i do for significant features. mainly
because that way, if it doesn't work out or Conrad doesn't want it
going in for some reason, it doesn't spanner up the works)
although keeping branches in sync with trunk changes can be a PITA,
i think it's worth it.
i assumed that no one else was working on sweep to any degree else
i would have been more vocal on the list about what i was doing.
as it is, we have both undertaken a navigation bar (scrollbar panel)
and we probably would have benefited from some collaboration there.
but, we took different approaches to it and as yours is further
along, i think it's best to go with that.
it looks like Conrad has added your info for SVN access and
given that we now have a means to deal with trac spam, the permissions
on that have been relaxed again so, i guess you are are good to go :)
drop me a line if you need anything from me though.
sorry if i didn't get back to you about your sample-display
patch btw. i was under the impression that i had for some reason. :|
i didn't commit it because i had some objections but what we really
want (imho) is something in line with what Steve mentioned.
which should get us nice sub sample curves that makes individual sample
editing at high zoom levels much more intuitive too.
still, perhaps you could do a poll on here and the sweep-users
list asking if people prefer your patch with it's horizontal sample
representation or the usual vertical one. (link a side by side
screenshot?) i prefer the existing method right now. partly
due to the noise your patch adds to some zoom levels (caused by
the relief drawing code bookending the line iirc)
if more people prefer your patched display then perhaps it should