> I realize that the icons are not essential, but I added them=20
> to see my=20
> DVD's from VHS tapes at a glance. Yes, the other icons I=20
> found are not=20
> great, which is why I didn't push them into the db. As for the owner=20
> names on the list, I needed it at this point because all=20
> records for all=20
> users show on the default list page. As I I said in my=20
> original mail to=20
> Andi, I am creating a shared library among friends so we need=20
> to see who=20
> owns what. At first I was going to make a sub-navigation=20
> option near the=20
> top of the page to allow people to filter the list by owner,=20
> but it was=20
> easier to modify the main query as opposed to introducing a=20
> new query of=20
> users and passing that to the template.
I understand your reasons for implementing it for yourself, all I was =
questioning
was whether the CVS would want it implemented as a standard ;)
Personally I like the owner there (not sure bout media type because all =
my media is DVD).
> I thought I had put a check for the icon in the show=20
> template... In any=20
> case, thanks a bunch for reviewing and committing my work. I should=20
> probably get setup with the CVS if I am going to make more changes.
You didnt put a check for the icon, just {$video.mediatype}.
Only Andi can commit, but it looks good to me tho ;) But its down to =
whether videodb needs these changes in the CVS...maybe an option to turn =
on/off this would be needed? Im not sure, see what Andi thinks ;)
Good work tho, more people add features to videodb, the better it =
becomes! :)
> All for now,
> Jay
Mike
> Mike Clark wrote:
>=20
> >Well i have implemented the .patch file and looks pretty good.
> >Im not 100% convinced the changes are exactly needed, its a=20
> matter of taste really.
> >
> >Personally I quite like the icons instead of DVD-R etc. But=20
> we need some
> >new icons done if this is the case, there are 3 very good=20
> ones included, but the others
> >aren't exactly ideal.
> >
> >Another part is on list.tpl it shows the mediatype and=20
> owner...this im not sure of. Its handy to know, but if=20
> someone was interested in the movie, would they not click on=20
> it to show all these details?
> >So Andi, upto u m8 on that one ;) its a matter of choice,=20
> his code is fine and works.
> >
> >He mentioned that he added code to make the edit/del buttons=20
> remove automatically when you do not own the movie...this was=20
> already implemented a few weeks ago so not needed.
> >
> >I changed a couple o' things:
> >
> >* Added medialogos into a subdir of images called: 'medialogos'
> > As such the path has been renamed in the 2 templates=20
> (show.tpl and list.tpl to reflect /images/medialogs/{$video.mediaimg})
> >
> >* Added in show.tpl:
> >I replaced:
> ><img src=3D"images/medialogos/{$video.mediaimg}"=20
> alt=3D"{$video.mediatype}" title=3D"{$video.mediatype}" border=3D"0">
> >
> >with
> >
> >{if $video.mediaimg !=3D=3D null}<img=20
> src=3D"images/medialogos/{$video.mediaimg}"=20
> alt=3D"{$video.mediatype}" title=3D"{$video.mediatype}"=20
> border=3D"0">{else}{$video.mediatype}{/if}
> >
> >This was so that if there wasnt a logo for the specified=20
> type (ie custom user created type) it would still give you a=20
> mediatype.
> >
> >Mike
> >
> > =20
> >
> >>-----Original Message-----
> >>From: Mike Clark=20
> >>Sent: 05 December 2003 09:40
> >>To: videodb-devel@...
> >>Subject: RE: [videodb-devel] Fw: videodb changes
> >>
> >>
> >> =20
> >>
> >>>I just forward some contributions I got per mail but have=20
> no time to
> >>>look at...
> >>> =20
> >>>
> >>I'll take a look.
> >>
> >>First impressions are that its quite a nice addition, but I=20
> >>dont think everyone would want images for DVD/DVDR/VHS etc,=20
> >>so maybe a config option would be better (tho do we want to=20
> >>keep adding to the config?)
> >>
> >>The edit/del template changes were already done from what I=20
> >>understood?
> >>
> >>As for the screen size, i'll check it out.
> >>
> >>Mike
> >>
> >> =20
> >>
> >>>Andi
> >>>
> >>>Begin forwarded message:
> >>>
> >>>Date: Wed, 03 Dec 2003 23:37:04 -0500
> >>>From: Jay Brown <jay@...>
> >>>To: Andreas Gohr <a.gohr@...>
> >>>Subject: videodb changes
> >>>
> >>>
> >>>Hello Andi.
> >>>
> >>>I've been using your program for a while now, and at least=20
> >>>once I wrote=20
> >>>you to hinting that I might implement a multi-user function. =20
> >>>Obviously=20
> >>>someone has beat me to it with your recent version. Since=20
> >>>they got the=20
> >>>ball rollling, I figured I should send you my improvements too.
> >>>
> >>>My two main additions involve a new custom function for=20
> >>> =20
> >>>
> >>choosing the=20
> >> =20
> >>
> >>>aspect ratio of the video (i.e. widescreen vs full frame) and=20
> >>>icons for=20
> >>>the mediatypes. I changed a few PHP pages and a couple "modern"=20
> >>>templates to show the media type icon, as well as the owner=20
> >>>in the list.
> >>>
> >>>I also adjusted the "list" template to restrict edit/del to their=20
> >>>owners, and the "show" template to display custom fields=20
> >>> =20
> >>>
> >>even if the=20
> >> =20
> >>
> >>>entry doesn't have a filename.
> >>>
> >>>You will find all of my changed in the attached tar file. I have=20
> >>>included the three icons I am using (icon_*.gif), as well as=20
> >>>some others
> >>>
> >>>graphics I found that may need to be resized. The other image is a=20
> >>>screen caption of my index page with the icon and owner=20
> >>> =20
> >>>
> >>name (both of=20
> >> =20
> >>
> >>>which are links to searches). There is a patch file generated=20
> >>>by 'diff'=20
> >>>for all the code changes, and an SQL file to add a column to the=20
> >>>'mediatypes' table and populate the icon names. My code=20
> >>>assumes that the
> >>>
> >>>icons are in the main 'images' directory.
> >>>
> >>>Sorry I didn't commit them to CVS directly, but this is my=20
> >>>first step. I
> >>>
> >>>hope this works for you. You said you are busy on the devel=20
> >>> =20
> >>>
> >>list, but=20
> >> =20
> >>
> >>>hopefully you'll get a chance to test and decide on these changes.=20
> >>>Please let me know what you think of them, or if you'd like=20
> >>> =20
> >>>
> >>a change.
> >> =20
> >>
> >>>Thanks for all your work. It's a neat little app, and I'm=20
> >>>about to allow
> >>>
> >>>my friends to create their own accounts so we can share among=20
> >>>our group.
> >>>
> >>>All for now.
> >>>Jay in Ottawa, Canada
> >>>
> >>>
> >>>
> >>>
> >>>--=20
> >>>http://www.splitbrain.org
> >>>
> >>> =20
> >>>
> >>-------------------------------------------------------
> >>This SF.net email is sponsored by: SF.net Giveback Program.
> >>Does SourceForge.net help you be more productive? Does it
> >>help you create better code? SHARE THE LOVE, and help us help
> >>YOU! Click Here: http://sourceforge.net/donate/
> >>_______________________________________________
> >>videodb-devel mailing list
> >>videodb-devel@...
> >>https://lists.sourceforge.net/lists/listinfo/videodb-devel
> >>
> >> =20
> >>
> >
> >
> >-------------------------------------------------------
> >This SF.net email is sponsored by: SF.net Giveback Program.
> >Does SourceForge.net help you be more productive? Does it
> >help you create better code? SHARE THE LOVE, and help us help
> >YOU! Click Here: http://sourceforge.net/donate/
> >_______________________________________________
> >videodb-devel mailing list
> >videodb-devel@...
> >https://lists.sourceforge.net/lists/listinfo/videodb-devel
> >
> > =20
> >
>=20
>=20
>=20
> -------------------------------------------------------
> This SF.net email is sponsored by: SF.net Giveback Program.
> Does SourceForge.net help you be more productive? Does it
> help you create better code? SHARE THE LOVE, and help us help
> YOU! Click Here: http://sourceforge.net/donate/
> _______________________________________________
> videodb-devel mailing list
> videodb-devel@...
> https://lists.sourceforge.net/lists/listinfo/videodb-devel
>=20
|