ArmedBear / J

patch to print.lisp

(defun output-ugly-object (object stream)
   (cond ((consp object)
          (output-list object stream))
         ((and (vectorp object)
               (not (stringp object))
               (not (bit-vector-p object)))
          (output-vector object stream))
         ((structure-object-p object)
          (print-object object stream))
;; patch
         ((typep object 'standard-object)
          (print-object object stream))
;; end patch
         ((xp::xp-structure-p stream)
          (let ((s (sys::%write-to-string object)))
            (xp::write-string++ s stream 0 (length s))))
         (t
          (%output-object object stream))))

-Alan

Re: [j-devel] print-object not called on instances From: Peter Graves <peter@ar...> - 2006-03-11 18:06 On Sun, 5 Mar 2006 at 23:57:10 -0500, Alan Ruttenberg wrote: > patch to print.lisp > > (defun output-ugly-object (object stream) > (cond ((consp object) > (output-list object stream)) > ((and (vectorp object) > (not (stringp object)) > (not (bit-vector-p object))) > (output-vector object stream)) > ((structure-object-p object) > (print-object object stream)) > ;; patch > ((typep object 'standard-object) > (print-object object stream)) > ;; end patch > ((xp::xp-structure-p stream) > (let ((s (sys::%write-to-string object))) > (xp::write-string++ s stream 0 (length s)))) > (t > (%output-object object stream)))) Applied. Thanks! -Peter

Re: [j-devel] print-object not called on instances From: Alan Ruttenberg <alanruttenberg@gm...> - 2006-03-21 21:14 My patch clobbers decent printing of error messages in the debugger. Don't have time to track it down now. Immediate symptoms can be prevented by changing ((typep object 'standard-object) to (and (typep object 'standard-object) (not (typep object 'condition))) -Alan On Mar 11, 2006, at 1:06 PM, Peter Graves wrote: > On Sun, 5 Mar 2006 at 23:57:10 -0500, Alan Ruttenberg wrote: >> patch to print.lisp >> >> (defun output-ugly-object (object stream) >> (cond ((consp object) >> (output-list object stream)) >> ((and (vectorp object) >> (not (stringp object)) >> (not (bit-vector-p object))) >> (output-vector object stream)) >> ((structure-object-p object) >> (print-object object stream)) >> ;; patch >> ((typep object 'standard-object) >> (print-object object stream)) >> ;; end patch >> ((xp::xp-structure-p stream) >> (let ((s (sys::%write-to-string object))) >> (xp::write-string++ s stream 0 (length s)))) >> (t >> (%output-object object stream)))) > > Applied. Thanks! > > -Peter

Re: [j-devel] print-object not called on instances From: Peter Graves <peter@ar...> - 2006-03-22 10:45 On Tue, 21 Mar 2006 at 16:13:18 -0500, Alan Ruttenberg wrote: > My patch clobbers decent printing of error messages in the debugger. > Don't have time to track it down now. Immediate symptoms can be > prevented by changing > > ((typep object 'standard-object) > > to > > (and (typep object 'standard-object) (not (typep object 'condition))) Yeah, I noticed that too, when I was first looking at your patch, so I tracked it down for the specific case I noticed and fixed it. The problem, loosely speaking, is that the Java code to initialize the condition object doesn't always follow the MAKE-INSTANCE initialization protocol closely enough. Unfortunately, there's no single place to fix this. Most likely you've run into another specific case that needs fixing. If you let me know the details (i.e. the specific types of the conditions that don't print right), I'll try to clean things up. I know this can be avoided by special-casing condition objects in OUTPUT-UGLY-OBJECT, but I'd much rather fix the underlying brokenness. Thanks. -Peter

3 messages have been excluded from this view by a project administrator.