Andrew Welch wrote:
> On 8/6/07, Florent Georges wrote:
> can I ask that you only commit code after all the tests
> pass (for example by running Test Project).
Yes, for sure. Actually I didn't run the whole test suite
after having add files in the xml directory (only the test
suite I worked on). My fault.
> Currently a few of the tests fail - one because of the
> addition of "invalid.xml", and another because the test
> expects the wrong behaviour.
About KernowTest and the addition of invalid.xml, I
suggest to change the tested directory from "test/xml" to
About SchemaValidatorTest's testValidateDirectoryInvalid()
and testValidateDirectoryPartiallyValid(), I thought that
was a bug in Kernow. I asked the ML about this behaviour.
But you are right, I should have wait the answer before
Do you confirm SchemaValidator.validateDirectory() must
return true if some documents in the directory failed, or
even if all documents failed? Related comments at:
> Also can I ask that code conforms to Sun's standard - this
> can be achieved by using "reformat code" be committing if
> you don't like actually coding it that way (but I would
> recommend it as its pretty standard in most companies)
Yes. Actually the only changes I saw are that the empty
lines are now "indented" (spaces were added in front of
> So please always ensure all the tests pass before
Sure. You shouldn't have to ask me, that is my fault I
didn't run the whole project's tests before committing :-(
Sorry for the inconvenience.
About DirectoryTransformer: I'm writing a test suite for
this class as it is, before adapting it to Source & Result.
I think this is better to first write a test suite for a
class (if it doesn't have one yet) before refactoring it.
There is less chance to have mistake in the tests themselves
Do you agree? If yes, I will commit the tests (once all
tests pass ;-)) before doing any change in the class itself.
Ne gardez plus qu'une seule adresse mail ! Copiez vos mails vers Yahoo! Mail