On 5/11/08, Brian Matherly <brian@...> wrote:
> > After r10703 whatever was imported from
> > GrampsWidgets.py module should
> > be imported from the widgets package. In fact there
> > is one exception:
> > the PlaceEntry class. I've put PlaceEntry and the
> > other (actually
> > unused) ObjectEntry classes in the objectentries.py
> > module under src/,
> Isn't ObjEntry inherited by PlaceEntry? So it is used,
> right? It appears to be the base class for all the
> *Entry classes. It looks like a couple of the entry
> classes are not used. It is up to you if you want to
> keep them. It seems to me that they could be useful in
> the future.
Yes, this is what I meant, the ObjEntry subclasses are not used. I'll
leave them there for the future.
> > otherwise there was a circular dependency between
> > the widgets and
> > Editors package. The objectentries.py module was
> > meant to be a
> > temporary location. Any better idea??
> I support the concept of removing the circular
> dependency if possible. My first impression is that
> the PlaceEntry is only used by the editors. So I think
> the entire file could be moved to "src/Editors".
Agreed. Moved in r10710.
> > There were some other unused widgets in
> > GrampsWidgets.py, which are
> > now in widgets/unused.py module. Were these widgets
> > planned to be
> > used, or they could be deleted?
> If I had to guess, I predict that they were used
> previously, and were never cleaned out. It should be
> safe to remove those two classes. If they are needed
> in the future, they are small enough that it won't be
> difficult to recreate them.
I think I'll leave them for a while. It's called 'unused', so we'll
not forget about it.
> Did you add the copyright: "# Copyright (C) 2007-2008
> The Gramps Developers"? That doesn't make any sense.
> When you edit a file, you should put YOUR NAME in the
> copyright statement at the top of the file.
I removed "The Gramps Developers", though I put my name only in the
files, which I created. So the ones, which I just copy/pasted from
GrampsWidgets still have Don as copyright owner, at least until 2006.
This is the case actually with most of the files in general, so since
2007 there's no copyright holder for them.
Honestly, I don't know how this copyright issue works.