SquirrelMail

Hi

I received a mail with a encoded subject, wich was not decoded:
Subject: =?windows-1252?Q?Nikon Information 06-04: Photokina 2004?=

I changed the file functions/mime.php and added support for 
mb_decode_mimeheader if the function is available. if not, the old code 
is used. mb_decode_mimeheader is available since php 4.0.6.
This worked well, but i noticed, that when i reply to a mail, the mail 
was not correctly quoted. I then found some calls in src/compose.php 
where decodeHeader is called with data witch does not come from the 
header. This makes no sense for me, so i removed those calls and now 
everything works fine for me.

The patch with my changes for squirrelmail 1.4.3a is attached to this mail.

Best regards, Felix

Re: [SM-DEVEL] decodeHeader From: Tomas Kuliavas <tokul@us...> - 2004-09-17 13:37 > Hi > > I received a mail with a encoded subject, wich was not decoded: > Subject: =?windows-1252?Q?Nikon Information 06-04: Photokina 2004?= > > I changed the file functions/mime.php and added support for > mb_decode_mimeheader if the function is available. if not, the old code is > used. mb_decode_mimeheader is available since php 4.0.6. This worked well, > but i noticed, that when i reply to a mail, the mail was not correctly > quoted. I then found some calls in src/compose.php where decodeHeader is > called with data witch does not come from the header. This makes no sense > for me, so i removed those calls and now everything works fine for me. > > The patch with my changes for squirrelmail 1.4.3a is attached to this > mail. I suspect that you recieved email that violates rfc2045. That's why that header was not decoded. SquirrelMail 1.4.3a is able to read email headers written in windows-1252 charset. Check if that email contains MIME-Version header or show us rfc822 source of email. -- Tomas

Re: [SM-DEVEL] decodeHeader From: Felix Egli <fegli@go...> - 2004-09-17 14:00 Tomas Kuliavas wrote: >>Hi >> >>I received a mail with a encoded subject, wich was not decoded: >>Subject: =?windows-1252?Q?Nikon Information 06-04: Photokina 2004?= >> >>I changed the file functions/mime.php and added support for >>mb_decode_mimeheader if the function is available. if not, the old code is >>used. mb_decode_mimeheader is available since php 4.0.6. This worked well, >>but i noticed, that when i reply to a mail, the mail was not correctly >>quoted. I then found some calls in src/compose.php where decodeHeader is >>called with data witch does not come from the header. This makes no sense >>for me, so i removed those calls and now everything works fine for me. >> >>The patch with my changes for squirrelmail 1.4.3a is attached to this >>mail. > > > I suspect that you recieved email that violates rfc2045. That's why that > header was not decoded. SquirrelMail 1.4.3a is able to read email headers > written in windows-1252 charset. But the function decodeHeader does not decode encoded strings when there are blanks between =?windows-1252?Q? and ?=. I dont know, if blanks are allowed or not, but Mozilla-Mail displays the Subject correctly. > Check if that email contains MIME-Version header or show us rfc822 source > of email. This is the header of the mail: Return-Path: <nikon-newsletter@...> Received: from services190.intern.esitebuilder.ch (services190.esitebuilder.everyware.ch [212.71.96.19] (may be forged)) by goldnet.ch (8.12.9/8.12.9/Debian-3) with ESMTP id i8GEek7V030486 for <felix.egli@...>; Thu, 16 Sep 2004 16:40:46 +0200 Received: by services190.intern.esitebuilder.ch (Postfix, from userid 100) id F35A26725A; Thu, 16 Sep 2004 16:12:01 +0200 (CEST) From: "=?windows-1252?Q?nikon-newsletter@...?=" <nikon-newsletter@...> To: "=?windows-1252?Q?egli felix?=" <felix.egli@...> Content-Type: text/plain; charset=windows-1252 Subject: =?windows-1252?Q?Nikon Information 06-04: Photokina Wahnsinn 2004?= Message-Id: <20040916141201.F35A26725A@...> Date: Thu, 16 Sep 2004 16:12:01 +0200 (CEST)

Re: [SM-DEVEL] decodeHeader From: Tomas Kuliavas <tokul@us...> - 2004-09-17 14:00 > > I received a mail with a encoded subject, wich was not decoded: > Subject: =?windows-1252?Q?Nikon Information 06-04: Photokina 2004?= http://www.faqs.org/rfcs/rfc2047.html 2. Syntax of encoded-words ... IMPORTANT: 'encoded-word's are designed to be recognized as 'atom's by an RFC 822 parser. As a consequence, unencoded white space characters (such as SPACE and HTAB) are FORBIDDEN within an 'encoded-word'. For example, the character sequence =?iso-8859-1?q?this is some text?= would be parsed as four 'atom's, rather than as a single 'atom' (by an RFC 822 parser) or 'encoded-word' (by a parser which understands 'encoded-words'). The correct way to encode the string "this is some text" is to encode the SPACE characters as well, e.g. =?iso-8859-1?q?this=20is=20some=20text?= The characters which may appear in 'encoded-text' are further restricted by the rules in section 5. ... 4.2. The "Q" encoding ... 3.) 8-bit values which correspond to printable ASCII characters other than "=", "?", and "_" (underscore), MAY be represented as those characters. (But see section 5 for restrictions.) In particular, SPACE and TAB MUST NOT be represented as themselves within encoded words. -- Tomas

Re: [SM-DEVEL] decodeHeader From: Marc Groot Koerkamp <marc@sq...> - 2004-09-17 14:10 > Hi >=20 >=20 > I received a mail with a encoded subject, wich was not decoded: > Subject: =3D?windows-1252?Q?Nikon Information 06-04: Photokina 2004?=3D Probably the mail you received is sent by a mail client which didn't take= the rfc standards very strickt (rfc2047 in this case). An encoded string= may never contain spaces and the one you provided contains spaces. That'= s the reason squirrelmail doesn 't handle the subject string as an encode= d string. From the RFC: IMPORTANT: 'encoded-word's are designed to be recognized as 'atom's by an RFC 822 parser. As a consequence, unencoded white space characters (such as SPACE and HTAB) are FORBIDDEN within an 'encoded-word'. For example, the character sequence =3D?iso-8859-1?q?this is some text?=3D would be parsed as four 'atom's, rather than as a single 'atom' (by an RFC 822 parser) or 'encoded-word' (by a parser which understands 'encoded-words'). The correct way to encode the string "this is some text" is to encode the SPACE characters as well, e.g. =3D?iso-8859-1?q?this=3D20is=3D20some=3D20text?=3D The algoritme squirrelmail uses to decode encoded strings makes use of a = string split on space (explode) and after that uses regular expressions t= o detect if the strings are encoded strings. I think it's faster then do = a regex on large strings and be less strickt on encoded strings with spac= es in it (regular expressions on large strings are slow). That's the rea= son I personally don't care that we do not correct faulty mail client beh= aviour. Especially when we sort large mailboxes on subject with no server= sort enabled speed is very important. >=20 >=20 > I changed the file functions/mime.php and added support for > mb_decode_mimeheader if the function is available. if not, the old code > is used. mb_decode_mimeheader is available since php 4.0.6. > This worked well, but i noticed, that when i reply to a mail, the mail > was not correctly quoted. I then found some calls in src/compose.php > where decodeHeader is called with data witch does not come from the > header. This makes no sense for me, so i removed those calls and now > everything works fine for me. The function name decodeHeader is not a very good name. We use it in othe= r places as well. >=20 >=20 > The patch with my changes for squirrelmail 1.4.3a is attached to this > mail. >=20 >=20 Maybe our i18n guru Tomas can take a look at your patch. Regards, Marc Groot Koerkamp

Re: [SM-DEVEL] decodeHeader From: Marc Groot Koerkamp <marc@gr...> - 2004-09-17 14:28 Looks like the mailinglists are very slow. I quoted the same part in a re= ply that didn't arrived yet ;) Marc. >> I received a mail with a encoded subject, wich was not decoded: >> Subject: =3D?windows-1252?Q?Nikon Information 06-04: Photokina 2004?=3D >>=20 >=20 > http://www.faqs.org/rfcs/rfc2047.html >=20 >=20 > 2. Syntax of encoded-words > ... > IMPORTANT: 'encoded-word's are designed to be recognized as 'atom's > by an RFC 822 parser. As a consequence, unencoded white space > characters (such as SPACE and HTAB) are FORBIDDEN within an > 'encoded-word'. For example, the character sequence >=20 >=20 > =3D?iso-8859-1?q?this is some text?=3D >=20 >=20 > would be parsed as four 'atom's, rather than as a single 'atom' (by > an RFC 822 parser) or 'encoded-word' (by a parser which understands > 'encoded-words'). The correct way to encode the string "this is some > text" is to encode the SPACE characters as well, e.g. >=20 >=20 > =3D?iso-8859-1?q?this=3D20is=3D20some=3D20text?=3D >=20 >=20 > The characters which may appear in 'encoded-text' are further > restricted by the rules in section 5. > ... > 4.2. The "Q" encoding > ... > 3.) 8-bit values which correspond to printable ASCII characters other > than "=3D", "?", and "_" (underscore), MAY be represented as those > characters. (But see section 5 for restrictions.) In > particular, SPACE and TAB MUST NOT be represented as themselves > within encoded words. >=20 >=20 > -- > Tomas >=20 >=20 >=20 > ------------------------------------------------------- > This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 > Project Admins to receive an Apple iPod Mini FREE for your judgement on > who ports your project to Linux PPC the best. Sponsored by IBM. > Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php > -- > squirrelmail-devel mailing list > Posting Guidelines: > http://squirrelmail.org/wiki/wiki.php?MailingListPostingGuidelines > List Address: squirrelmail-devel@... > List Archives: > http://news.gmane.org/thread.php?group=3Dgmane.mail.squirrelmail.devel > List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=3D= 7139 > List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-de= vel >=20 >=20

1 message has been excluded from this view by a project administrator.