Direct Rendering Infrastructure

Email Archive: dri-devel (read-only)

1999:	_Jan	_Feb	_Mar	_Apr	_May	_Jun	_Jul	_Aug	_Sep	_Oct	_Nov	_Dec (115)
2000:	_Jan (143)	_Feb (177)	_Mar (390)	_Apr (285)	_May (316)	_Jun (241)	_Jul (303)	_Aug (504)	_Sep (322)	_Oct (368)	_Nov (398)	_Dec (474)
2001:	_Jan (734)	_Feb (712)	_Mar (736)	_Apr (358)	_May (403)	_Jun (317)	_Jul (286)	_Aug (299)	_Sep (304)	_Oct (398)	_Nov (169)	_Dec (313)
2002:	_Jan (406)	_Feb (506)	_Mar (520)	_Apr (629)	_May (714)	_Jun (711)	_Jul (761)	_Aug (665)	_Sep (542)	_Oct (713)	_Nov (641)	_Dec (639)
2003:	_Jan (468)	_Feb (748)	_Mar (781)	_Apr (812)	_May (789)	_Jun (731)	_Jul (567)	_Aug (579)	_Sep (624)	_Oct (647)	_Nov (387)	_Dec (422)
2004:	_Jan (592)	_Feb (630)	_Mar (514)	_Apr (457)	_May (647)	_Jun (388)	_Jul (276)	_Aug (528)	_Sep (840)	_Oct (831)	_Nov (350)	_Dec (458)
2005:	_Jan (584)	_Feb (654)	_Mar (706)	_Apr (229)	_May (411)	_Jun (594)	_Jul (341)	_Aug (435)	_Sep (251)	_Oct (297)	_Nov (196)	_Dec (286)
2006:	_Jan (295)	_Feb (378)	_Mar (300)	_Apr (204)	_May (241)	_Jun (316)	_Jul (256)	_Aug (346)	_Sep (338)	_Oct (352)	_Nov (288)	_Dec (272)
2007:	_Jan (194)	_Feb (242)	_Mar (329)	_Apr (357)	_May (254)	_Jun (309)	_Jul (291)	_Aug (370)	_Sep (279)	_Oct (336)	_Nov (357)	_Dec (465)
2008:	_Jan (396)	_Feb (370)	_Mar (407)	_Apr (350)	_May (337)	_Jun (339)	_Jul (352)	_Aug (314)	_Sep (338)	_Oct (299)	_Nov (279)	_Dec (365)
2009:	_Jan (596)	_Feb (601)	_Mar (588)	_Apr (542)	_May (731)	_Jun (701)	_Jul (673)	_Aug (1050)	_Sep (740)	_Oct (750)	_Nov (774)	_Dec (1044)
2010:	_Jan (835)	_Feb (431)	_Mar	_Apr	_May	_Jun	_Jul	_Aug	_Sep	_Oct	_Nov	_Dec

[Patch VIA UniChrome DRM][3/5 Ver1] Enhance DRM robustness

From: <BruceChang@vi...> - 2009-10-08 07:23

Hello All:
This is patch 3 of the 5 patches. It's based on 2.6.32-rc3+patch1+patch2. It enhance the DRM robustness,
such as memory check before release or content comparison.

3 files has been modified for this patch.

Sign-off by Bruce C. Chang <brucechang@via.com.tw>
diff -Nur linux-2.6.32-rc3-old/drivers/gpu/drm/via/via_dmablit.c linux-2.6.32-rc3-new/drivers/gpu/drm/via/via_dmablit.c
--- linux-2.6.32-rc3-old/drivers/gpu/drm/via/via_dmablit.c 2009-10-05 08:12:30.000000000 +0800
+++ linux-2.6.32-rc3-new/drivers/gpu/drm/via/via_dmablit.c 2009-10-08 10:18:08.000000000 +0800
@@ -195,8 +195,10 @@ /> default:
vsg->state = dr_via_sg_init;
}
- vfree(vsg->bounce_buffer);
- vsg->bounce_buffer = NULL;
+ if (vsg->bounce_buffer) {
+ vfree(vsg->bounce_buffer);
+ vsg->bounce_buffer = NULL;
+ }
vsg->free_on_sequence = 0;
}

diff -Nur linux-2.6.32-rc3-old/drivers/gpu/drm/via/via_irq.c linux-2.6.32-rc3-new/drivers/gpu/drm/via/via_irq.c
--- linux-2.6.32-rc3-old/drivers/gpu/drm/via/via_irq.c 2009-10-05 08:12:30.000000000 +0800
+++ linux-2.6.32-rc3-new/drivers/gpu/drm/via/via_irq.c 2009-10-08 10:18:08.000000000 +0800
@@ -357,6 +357,8 @@ /> drm_via_irq_t *cur_irq = dev_priv->via_irqs;
int force_sequence;

+ if (!dev->pdev->irq)
+ return -EINVAL;
if (irqwait->request.irq >= dev_priv->num_irqs) {
DRM_ERROR("Trying to wait on unknown irq %d\n",
irqwait->request.irq);
diff -Nur linux-2.6.32-rc3-old/drivers/gpu/drm/via/via_mm.c linux-2.6.32-rc3-new/drivers/gpu/drm/via/via_mm.c
--- linux-2.6.32-rc3-old/drivers/gpu/drm/via/via_mm.c 2009-10-08 10:17:39.000000000 +0800
+++ linux-2.6.32-rc3-new/drivers/gpu/drm/via/via_mm.c 2009-10-08 10:18:08.000000000 +0800
@@ -91,6 +91,17 @@ /> int via_final_context(struct drm_device *dev, int context)
{
drm_via_private_t *dev_priv = (drm_via_private_t *) dev->dev_private;
+ struct drm_ctx_list *pos, *n;
+ bool context_valid = 0;
+
+ list_for_each_entry_safe(pos, n, &dev->ctxlist, head)
+ if (pos->handle == context) {
+ context_valid = 1;
+ break;
+ }
+
+ if (!context_valid)
+ return 0;

via_release_futex(dev_priv, context);

@@ -98,7 +109,8 @@ /> /* Last context, perform cleanup */
if (dev->ctx_count == 1 && dev->dev_private) {
DRM_DEBUG("Last Context\n");
- drm_irq_uninstall(dev);
+ if (dev->pdev->irq)
+ drm_irq_uninstall(dev);
via_cleanup_futex(dev_priv);
via_do_cleanup_map(dev);
}

Thanks and Best regards
=================================================
Bruce C. Chang(張祖明)
VIA Technologies, Inc.
Address: 1F, 531, Chung-Cheng Road, Hsin-Tien, 231 Taipei
Tel: +886-2-22185452 Ext 7323
Mobile: +886-968343824
Fax: +886-2-22186282
Skype: Bruce.C.Chang
Email: BruceChang@via.com.tw

Re: [Patch VIA UniChrome DRM][3/5 Ver1] Enhance DRM robustness

From: Thomas Hellstrom <thomas@sh...> - 2009-10-08 13:23

Bruce,
This looks OK, except for one modification below. Could you comment on
that one?

BruceChang@via.com.tw wrote:
> diff -Nur linux-2.6.32-rc3-old/drivers/gpu/drm/via/via_mm.c linux-2.6.32-rc3-new/drivers/gpu/drm/via/via_mm.c
> --- linux-2.6.32-rc3-old/drivers/gpu/drm/via/via_mm.c 2009-10-08 10:17:39.000000000 +0800
> +++ linux-2.6.32-rc3-new/drivers/gpu/drm/via/via_mm.c 2009-10-08 10:18:08.000000000 +0800
> @@ -91,6 +91,17 @@ /> > int via_final_context(struct drm_device *dev, int context)
> {
> drm_via_private_t *dev_priv = (drm_via_private_t *) dev->dev_private;
> + struct drm_ctx_list *pos, *n;
> + bool context_valid = 0;
> +
> + list_for_each_entry_safe(pos, n, &dev->ctxlist, head)
> + if (pos->handle == context) {
> + context_valid = 1;
> + break;
> + }
> +
> + if (!context_valid)
> + return 0;
>
> via_release_futex(dev_priv, context);
>
When is this function called with an invalid context? Could you describe
what error you are seeing.

Thanks,

Thomas

RE: [Patch VIA UniChrome DRM][3/5 Ver1] Enhance DRM robustness

From: <BruceChang@vi...> - 2009-10-09 09:25

Hello Thomas
>> + if (!context_valid)
>> + return 0;
>>
>> via_release_futex(dev_priv, context);
> When is this function called with an invalid context? Could you describe
> what error you are seeing.

There are some bugs in the DDMPEG(a user mode library realizing decode driver) before, which destroy his context more than once, it was the behavior causes DRM segment fault. We add this patch for enhancing DRM robustness, although it is DDMPEG's fault.

Thanks and Best Regards
=================================================
Bruce C. Chang(張祖明)
VIA Technologies, Inc.
Address: 1F, 531, Chung-Cheng Road, Hsin-Tien, 231 Taipei
Tel: +886-2-22185452 Ext 7323
Mobile: +886-968343824
Fax: +886-2-22186282
Skype: Bruce.C.Chang
Email: BruceChang@via.com.tw

[Patch VIA UniChrome DRM][0/3 Ver2] Enhance DRM robustness

From: <BruceChang@vi...> - 2009-10-30 06:04

Hello Sirs:
Based on the comment for my vious submission for VIA UniChrome DRM, we modify our code as the following patch. They are
1. Add support for ACPI suspend/resume issue.
2. Add an interfaces for communication with ddmpeg and v4l.
3. Fix video hang issue caused by verification function.
These patches are based on 2.6.32-rc5.
Please kindly help to check. And please kindly integrate it into mainline if it's OK.

Thanks and Best Regards
=================================================
Bruce C. Chang(張祖明)
VIA Technologies, Inc.
Address: 1F, 531, Chung-Cheng Road, Hsin-Tien, 231 Taipei
Tel: +886-2-22185452 Ext 7323
Mobile: +886-968343824
Fax: +886-2-22186282
Skype: Bruce.C.Chang
Email: BruceChang@via.com.tw

RE: [Patch VIA UniChrome DRM][0/3 Ver2] Enhance DRM robustness

From: <BruceChang@vi...> - 2009-11-03 13:02