On Saturday 16 March 2013, Sam Roberts wrote:
> On Sat, Mar 16, 2013 at 1:01 PM, Stefanos Harhalakis <v13@...> wrote:
> > These patches are mine. Feel free to use them. It's much better if they
> > are included upstream and also makes the packaging work easier.
> > I'd like to have the fix-manpages and fix-samples patches included since
> > they are a bit big.
> fix-samples looks good.
> fix-manpages patches the doxygen generated output, what problem is it
> fixing? If the output is invalid, should this be a bug reported
> against doxygen's man page generator? Or is there something wrong with
> the markup its coming from?
Right! I forgot that they were auto-generated.
The biggest issue are the minus signs which should be represented as \-
-protocol tag value on success, -1 on error
+protocol tag value on success, \-1 on error
And there's also this:
-'reserved' was previously called 'code', which it is not, in any IGMP version.
+\&'reserved' was previously called 'code', which it is not, in any IGMP version.
(because ' at the beginning of a line has special meaning)
> > Regarding socklen_t, I believe that the standard approach nowdays with
> > autoconf is to use AC_CHECK_TYPE:
> Ok, I'll try when I've time early next week, unless Gilles takes a
> shot at it before me.
Great! Let me know if you need any help.
p.s. Have a look at the fix-return-value-ignore one as well. It's for -Wall
again in order not to complain about the ignored returned value.