On 01/21/2010 09:14 PM, Valdis.Kletnieks@... wrote:
> On Thu, 21 Jan 2010 23:26:27 +0100, Andi Kleen said:
>> Add Xeon 7500 series support to oprofile
>> Straight forward: it's the same as Core i7, so just detect
>> the model number. No user space changes needed.
>> Very simple patch, so it could be still merged for .33?
>> Signed-off-by: Andi Kleen<ak@...>
>> arch/x86/oprofile/nmi_int.c | 1 +
>> 1 file changed, 1 insertion(+)
>> Index: linux/arch/x86/oprofile/nmi_int.c
>> --- linux.orig/arch/x86/oprofile/nmi_int.c
>> +++ linux/arch/x86/oprofile/nmi_int.c
>> @@ -598,6 +598,7 @@ static int __init ppro_init(char **cpu_t
>> case 15: case 23:
>> *cpu_type = "i386/core_2";
>> + case 0x2e:
>> case 26:
>> spec =&op_arch_perfmon_spec;
>> *cpu_type = "i386/core_i7";
> I'll bite - why a hex constant rather than the decimal values nearby?
The hex constant 0x2e matches the numbering used in the new "Intel® 64 and IA-32
Architectures Software Developer’s Manual".
> Also, should we do something about *cpu_type so it isn't confusing on a 7500
> reporting itself as a i7?
According the table A-2 in "Intel® 64 and IA-32 Architectures Software
Developer’s Manual" 3b. the core performance events are the same with a few
additional events for 06_2eh.
However, the uncore events in table A-3 only apply to 06_1AH, 06_1EH, and 06_1FH
according to the paragraph at the end of A-2:
Intel Xeon processors with CPUID signature of DisplayFamily_DisplayModel 06_2EH
have a distinct uncore sub-system that is significantly different from the
uncore found in processors with CPUID signature 06_1AH, 06_1EH, and 06_1FH.
Non-architectural Performance monitoring events for its uncore will be available
in future documentation.