-----BEGIN PGP SIGNED MESSAGE-----
> On 11/7/07, Jon Angliss <jon@...> wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>> Cor mentioned that he was having issues with the special_mailbox hook
>> earlier, and when we took a look at it, the include_subs variable
>> wasn't being passed to the hook.
> Why does it need to go to the hook? The docs on that function
> (isSpecialMailbox()) seem to indicate that it is the plugin's
> responsibility to tag any subfolders as special if $include_subs is
> turned off; it seems to me that $include_subs was only meant for use
> in the core.
Okay, I've got a better understanding of what was causing Cor's issue.
I think the real bug is in the presentation of the folder list in
stable. It's a long standing bug that if you create a sub folder under
a special folder, it *should* be nested under that special folder in
the tree, regardless if the new folder itself is special or not. The
problem is, if you get a plugin that sets a special folder, say the
sent_subfolders for example, which marks INBOX.Spam as special,
but not INBOX.Spam.Test, the folder list ends up looking like this:
The core code handles this by setting the $include_subs to true, which
then marks all folders under the special folder as special. The
problem is, this var isn't passed down to the plugin that uses the
Now you're saying that the plugin author should mark a folder under
the subs as special. That's okay, if the intent is for all the sub
folders to be special, but in this case they're not. What this then
causes is the folder delete code won't let you touch this new "Test"
folder, because you've explicitly marked it as special. The
include_subs variable is passed down as "False" from the folders page,
but "True" from the left_main code for sorting.
If the plugin author's intent is for all folders of the special folder
to be "special", then they should code it that way, however if that
isn't there intent, they should be able to respect the include_subs
I believe this is a big of a workaround solution, until the folder
display code is reorganized, as this is where the real bug is located.
I still think, however, that the include_subs option should be passed
to the plugin.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
-----END PGP SIGNATURE-----