On Sun, Jan 4, 2009 at 12:23 PM, Lars Lindner <lars.lindner@...> wrote:
> On Mon, Dec 29, 2008 at 2:51 PM, Mathieu Leplatre
> <contact@...> wrote:
>> On Fri, Dec 26, 2008 at 9:57 PM, Lars Lindner <lars.lindner@...> wrote:
>>> On Fri, Dec 26, 2008 at 3:17 PM, Mathieu Leplatre <leplatre@...> wrote:
>>>> On Mon, Dec 22, 2008 at 10:48 PM, Emilio Pozuelo Monfort
>>>> <pochu@...> wrote:
>>>>> Lars Lindner wrote:
>>>>>> I believe this type of view (let's call it "reduced feed list") is a total
>>>>>> different one and to avoid the user trying "normal" actions in it and
>>>>>> thereby running into misunderstandings it would need to be an
>>>>>> explicitely different view, maybe a list-type view of feeds - which would
>>>>>> also solve the DnD problems.
>>>>> FWIW, Thunderbird as a similar view to this one, the "Unread folders" one. It
>>>>> shows all the folders with unread messages, without displaying any hierarchy.
>>>>> I'm a heavy user of the Unread Folders view in Thunderbird, and I'm sure I'd be
>>>>> a heavy user of an Unread Feeds view in Liferea if there was one. So count on me
>>>>> if you need testing or anything :)
>>>> Okay, I made some tries, and I now have a flat list with only unread feeds.
>>>> The lack of folders can be a drawback, but I understand the matter of
>>>> guiding the user.
>>>> I will now implement the view switching and send you a first version.
>>> Sounds great!
>> Here is a first implementation. (diff against trunk).
>> I added a toggle "Reduced feed list" in the View menu, and a treeview
>> visibility filter.
>> To switch between the flat view and tree view, I found easier to
>> remove and add the nodes again with NULL parent, instead of switching
>> between list store and tree store.
>> Lars, could you please have a look at the piece of code in ui_node to
>> remove/readd the nodes ? I may have missed existing bits of code...
> Hi Mathieu!
> Thanks for taking the time to write the patch. I just tried it and found
> the feed list reduction to be working properly. I think your code is ok.
> For inclusion we need to address the following issues:
> 1.) Auto-folder expansion on startup doesn't work with GtkTreeView filter
> (I believe this is why the earlier implementation did not use a filter
> when in unreduced mode). The is propably the reason for the following
> assertions given:
> (liferea:10691): Gtk-CRITICAL **: gtk_tree_model_filter_get_path:
> assertion `GTK_TREE_MODEL_FILTER (model)->priv->stamp == iter->stamp'
> (liferea:10691): Gtk-CRITICAL **: gtk_tree_view_row_expanded:
> assertion `path != NULL' failed
> 2.) Menu and DnD disabling. Right now the reduced mode does not
> prevent feed list modification options and drag&drop. To realize this
> there need to be changes in liferea_shell_update_feed_menu() and
> in ui_dnd.c for the drag_possible() callback.
> Do you have time to work on those points? If not I could look into it.
> With Best Regards,
I had a very little bit of time, and modified the patch (to apply the
filter only when view is reduced).
1) Expand folders : I may need your help on this point.
I cannot say exactly when the Gtk-CRITICAL are raised. I cannot always
It looks like folders are expanded on startup. (if they were on last
When I remove the filter, I guess I should call something to expand
them all like they were in their last state. You may know better than
2) I solved this with a one-liner :
gtk_tree_view_set_reorderable (GTK_TREE_VIEW(treeview), FALSE);
Here is the new patch again last svn.