On 06/14/2013 06:34 AM, Gilles Allard wrote:
> Hi Maynard
> On Thursday, June 13, 2013 08:48:44 AM you wrote:
>> On 06/13/2013 05:33 AM, Gilles Allard wrote:
>> Is this patch really related to "PATCH 1/2" or can it be handled
>> independently? If independent, then in future, please do not post multiple
>> independent patches as part of a patch set.
> I cannot say they are independent, even if they are not applied to the same
> feature, because line numbers in the 2nd ( "PATCH 2/2" ) depend on the fact
> that "PATCH 1/2" was applied first ( the same file is modified by both patches )
> After cloning the official Oprofile repository and creating a new branch, I
> commited the first modifications then, checking out again my private repository
> ( same branch ), I started the 2nd set of modification ( "PATCH 2/2" ).
> May be creating another new branch for the 2nd patch could make these 2
> patches totaly independent. Is this right ?
>> As for the patch itself, I haven't been able to reproduce the improper
>> behavior you describe. The whole window automatically widens to
>> accommodate a wider UM sub-window. I built with qt4/qt3Support. Maybe
>> there's a particular event/unit mask combination that exhibits the problem.
>> Your description says the "unit mask sub-window sometimes overlaps event
>> list" sub-window. Can you be more specific about when this happens?
> You can try this :
> - Select an event like "BSQ_CACHE_REFERENCE" with rather long "unit_mask"
> - Click "Save & Quit* button: this save config you entered in "daemonrc"
> - Run again "oprof_start": the default setting recorded at previous step will
> be used. Then you can see that "Unit mask" subwindow overlaps "Event list"
> one. Clicking twice on "BSQ_CACHE_REFERENCE" event will force a resize of the
> widget the appearance of which will be then correct.
> The problem I mentionned only occurs on "oprof_start" startup if default event
> recorded in "daemonrc" has long unit mask lines.
> The patch I posted yesterday fixes that problem on startup ( the "unit mask"
> subwindow is correctly resized ). But if, after startup, you select another
> event with shorter unit mask lines the "unit mask" subwindow is not shrinked.
> If oprof_start is built using Qt3, the behaviour is different: the 2 subwindows
> do not overlap but the "unit_mask" one is not resized ( the right side is not
> visible but no horizontal scroll bar is shown ).
> I hope all this will help you validate this patch. Thanks for any comment.
Thanks very much for that explanation. On my Intel Core 2 duo laptop, I saw slightly
different symptoms, but your patch works as expected. I committed your patch with
a commit message that adds the symptoms I saw, as well as the explanation you gave
for how to reproduce the problem.
> Gilles Allard