CEDET

Re: [CEDET-devel] Patch adding EDE simple integration for one of Java SRecode macros From: Eric M. Ludlam <eric@si...> - 2013-01-24 22:19 Attachments: srecode.args.el.patch      On 01/24/2013 11:15 AM, Vladimir Kazanov wrote: > Hi all! > > Recently I started using SRecode for smart templating. First thing I > noticed was that java empty file template does not try to use EDE to get > correct package name. Instead, it uses a simple heuristic: looks for > "src/" in buffer file, and uses it to extract package name for a Java class. > > The patch included leaves the heuristic, but first it checks if there > are any source paths specified for current project, and uses them for > package name generating. > > It would be nice, if someone could check the patch and consider adding > it into trunk. I believe my ELisp is still a bit... Clumsy. Both > comments and critic are welcome! I posted the below patch last week to add a :project argument available to templates. You could use it to improve your patch. I think a dilemma is that it only works if you have a project, so perhaps this needs to be updated to have a fallback value. Anyway, multiple languages seems to have its own "turn the file into a symbol". With two questions in the same month on the same topic, it probably makes sense to create an mode local function for it. I hadn't checked this in yet as I was still contemplating its value. I suspect there is something bigger here. In the meantime, you will probably like the way to calculate the relative path name in this patch. Eric

Re: [CEDET-devel] Patch adding EDE simple integration for one of Java SRecode macros From: Vladimir Kazanov <vkazanov@in...> - 2013-01-29 12:41 Attachments: Message as HTML      srecode.patch

Re: [CEDET-devel] Patch adding EDE simple integration for one of Java SRecode macros From: Eric M. Ludlam <eric@si...> - 2013-01-31 02:36 On 01/29/2013 07:41 AM, Vladimir Kazanov wrote: > Eric, > > I have reformatted/improved the original patch a bit (mostly cosmetic > changes, with one potential bug fixed), and added a fallback value to > the function you mentioned. I knew about the function calculating > relative file names, but it would not make the code cleaner or shorter > anyway. I used your patch to the java.el file. It seems fine to me. It made me realize that I don't have any java based integration tests, and thus couldn't test your change easily. This seems like a bit of a hole in the test infrastructure. The C based integration tests in the 'tests' sbuddirectory in the CEDET repository create C projects, uses srecode to create C code, compile it, parse it with Semantic, etc. I don't know what tools are installed in build bot for CEDET for compiling Java. We'd need to tune anything we develop to that tool chain. Thanks! Eric

Re: [CEDET-devel] Patch adding EDE simple integration for one of Java SRecode macros From: Vladimir Kazanov <vkazanov@in...> - 2013-01-31 16:58 Attachments: Message as HTML      Eric, I will try to extend Java unit test suite in future patches. Thanks! On Thu, Jan 31, 2013 at 9:36 AM, Eric M. Ludlam <eric@...: > On 01/29/2013 07:41 AM, Vladimir Kazanov wrote: > >> Eric, >> >> I have reformatted/improved the original patch a bit (mostly cosmetic >> changes, with one potential bug fixed), and added a fallback value to >> the function you mentioned. I knew about the function calculating >> relative file names, but it would not make the code cleaner or shorter >> anyway. >> > > I used your patch to the java.el file. It seems fine to me. It made me > realize that I don't have any java based integration tests, and thus > couldn't test your change easily. This seems like a bit of a hole in the > test infrastructure. > > The C based integration tests in the 'tests' sbuddirectory in the CEDET > repository create C projects, uses srecode to create C code, compile it, > parse it with Semantic, etc. I don't know what tools are installed in > build bot for CEDET for compiling Java. We'd need to tune anything we > develop to that tool chain. > > Thanks! > Eric > > -- Yours sincerely, Vladimir Kazanov -- С уважением, Владимир Казанов

Re: [CEDET-devel] Patch adding EDE simple integration for one of Java SRecode macros From: Eric M. Ludlam <eric@si...> - 2013-02-07 02:11 On 01/29/2013 07:41 AM, Vladimir Kazanov wrote: > I posted the below patch last week to add a :project argument > available to templates. > > You could use it to improve your patch. I think a dilemma is that > it only works if you have a project, so perhaps this needs to be > updated to have a fallback value. Hi Vladimir, WRT your srecode-semantic-handle-:project, I have checked in a similar change to what you had proposed. Sorry about the delay. Eric

1 message has been excluded from this view by a project administrator.