Webware for Python

On Friday 16 November 2001 08:05 am, Geoff Talvola wrote:
> I feel that install.py shouldn't modify any files that are under source
> control.  I'm fine with it creating _new_ files however.

I forget which files it modifies. Can you refresh my memory?

I plan on adding an --expand-docs=no option at some point. Perhaps that would solve your problem? If so, we can add it sooner rather than later.


> Either that or we shouldn't require running install.py.

I'm not likely to budge on that one.


> (In the meantime, I'll probably just fake it out by putting a
> "_installed" file into the Webware directory in Perforce.)

That was actually going to be my suggestion.


-Chuck

On Mon, Nov 19, 2001 at 07:37:35AM -0800, Chuck Esterbrook wrote:
> On Friday 16 November 2001 08:05 am, Geoff Talvola wrote:
> > I feel that install.py shouldn't modify any files that are under source
> > control. ?I'm fine with it creating _new_ files however.
> 
> I forget which files it modifies. Can you refresh my memory?

I missed the connection between this and whatever the original
problem was.  However, it *is* true that it's inconvenient to 
upgrade Webware or do a CVS update on it because that creates
conflicts in your configuration files.  One strategy I've seen
in other software is to not distribute the *config files but
instead distribute *config-dist files.  That way the user is
forced to copy and modify the files the first time, and when
she upgrades, she can at her leisure compare the current
default file with the previous and make changes to her
files.

-- 
-Mike (Iron) Orr, iron@...  (if mail problems: mso@...)
   http://iron.cx/     English * Esperanto * Russkiy * Deutsch * Espan~ol

At 07:37 AM 11/19/01 -0800, Chuck Esterbrook wrote:
>On Friday 16 November 2001 08:05 am, Geoff Talvola wrote:
> > I feel that install.py shouldn't modify any files that are under source
> > control.  I'm fine with it creating _new_ files however.
>
>I forget which files it modifies. Can you refresh my memory?

Here's the output I get:

Webware for Python 0.6b2
Installer

         Date: Mon Nov 19 11:25:29 2001
   Python ver: 2.1 (#15, Apr 16 2001, 18:25:49) [MSC 32 bit (Intel)]
       Op Sys: nt
     Platform: win32
      Cur dir: D:\gat\tools\Tools\Webware

Scanning for components...
    no bin          yes CGIWrapper
   yes COMKit        no Docs
    no DocSupport   yes MiddleKit
   yes MiscUtils    yes PSP
   yes TaskKit      yes UserKit
   yes WebKit       yes WebUtils

Propagating stylesheets...
Traceback (most recent call last):
   File "install.py", line 421, in ?
     Installer().run(verbose=verbose)
   File "install.py", line 55, in run
     self.installDocs()
   File "install.py", line 110, in installDocs
     self.propagateStyleSheet()
   File "install.py", line 125, in propagateStyleSheet
     open(target, 'wb').write(stylesheet)
IOError: [Errno 13] Permission denied: 'CGIWrapper\\Docs\\StyleSheet.css'


--

- Geoff Talvola
   gtalvola@...

On Monday 19 November 2001 07:58 am, Mike Orr wrote:
> I missed the connection between this and whatever the original
> problem was.  However, it *is* true that it's inconvenient to
> upgrade Webware or do a CVS update on it because that creates
> conflicts in your configuration files.  One strategy I've seen
> in other software is to not distribute the *config files but
> instead distribute *config-dist files.  That way the user is
> forced to copy and modify the files the first time, and when
> she upgrades, she can at her leisure compare the current
> default file with the previous and make changes to her
> files.

Good idea. I suppose we could have install.py do the copy instead.

This would also avoid developers checking in their customizations, which happens on occasion.

Right now install.py copies *.config to *.config.default. Seems that we just need to reverse this. Put *.default in the repository and copy to *.config.


I'll make the change if no one objects.

-Chuck

On Monday 19 November 2001 08:30 am, Geoff Talvola wrote:
> Propagating stylesheets...
> Traceback (most recent call last):
>    File "install.py", line 421, in ?
>      Installer().run(verbose=verbose)
>    File "install.py", line 55, in run
>      self.installDocs()
>    File "install.py", line 110, in installDocs
>      self.propagateStyleSheet()
>    File "install.py", line 125, in propagateStyleSheet
>      open(target, 'wb').write(stylesheet)
> IOError: [Errno 13] Permission denied:
> 'CGIWrapper\\Docs\\StyleSheet.css'

That's not a modification, it's an actual copy. Probably your Docs/ directory is not writable either.

In any case, my original --expand-docs=no idea should help.


-Chuck

At 10:34 AM 11/19/01 -0800, Chuck Esterbrook wrote:
>On Monday 19 November 2001 08:30 am, Geoff Talvola wrote:
> > Propagating stylesheets...
> > Traceback (most recent call last):
> >    File "install.py", line 421, in ?
> >      Installer().run(verbose=verbose)
> >    File "install.py", line 55, in run
> >      self.installDocs()
> >    File "install.py", line 110, in installDocs
> >      self.propagateStyleSheet()
> >    File "install.py", line 125, in propagateStyleSheet
> >      open(target, 'wb').write(stylesheet)
> > IOError: [Errno 13] Permission denied:
> > 'CGIWrapper\\Docs\\StyleSheet.css'
>
>That's not a modification, it's an actual copy. Probably your Docs/ 
>directory is not writable either.

Huh?  It's modifying the file by overwriting it.  I still consider that a 
modification :-)

All my directories are writable.  StyleSheet.css is NOT writable because 
it's part of the CVS repository and is therefore part of my Perforce depot, 
and is therefore read-only until I check it out.

If install.py is going to be overwriting StyleSheet.css in the 
CGIWrapper/Docs directory, then we should _remove_ 
CGIWrapper/Docs/StyleSheet.css from CVS.  It doesn't make any sense to have 
a file checked into CVS if it's going to be overwritten as soon as we run 
install.py.

>In any case, my original --expand-docs=no idea should help.

Actually, I don't mind having to run install.py as long as it only 
generates new files, and doesn't attempt to touch files that are part of 
the CVS repository.  Perhaps CGIWrapper/Docs/StyleSheet.css and other files 
that are overwritten by install.py just need to be deleted from CVS.


--

- Geoff Talvola
   gtalvola@...