On 6/1/06, Jeff Norton <jnorton@...> wrote:
> For now I just created bool.expose by plagerizing from int.expose. I
> presume you'd
> rather me create a baseint.expose that listed all the methods and have
> int.expose and bool.expose both do an "incl: baseint". I'll look at
> that next.
That would be good, though getting the stuff below to work would be a
higher priority. Just so you know, the work you are doing will target
a 2.3 release of Jython and not the upcoming 2.2 release. Having said
that, I think the length of time between the 2.2 release and the 2.3
release should be dramatically shorter than the 2.1->2.2 cycle (in
fact, much of 2.3's behavior is already present in 2.2.)
> So far I've created PyBoolean and gotten it to pass the simple gorrilla
> (e.g. bool, type(True), type(False), isinstance(True, bool), etc. return
> the right answers).
> I think the problem is that I changed Py.newBoolean to return a
> rather than a PyInteger, but many tests still use Py.One, and Py.Zero,
> than my new Py.True, and Py.False.
There are many, many calls to Py.One and Py.Zero in the codebase...
> I tried leaving Py.newBoolean alone but this caused simpler things like
> isinstance(True, bool) to fail. So it seems if I'm in for a penny, I'm
> in for a pound.
Yes, I'm afraid this change will likely ripple through the whole thing.
> P.S. gexpose seems to write to stdout rather than modifying the file in
Hmmm. The single argument gexpose is supposed to write to stout, but
the 2 arg version *should* modify the file in place. Having said
that, you are probably the first person other than myself to try the 2
> P.P.S. your instructions for gderived and gexpose had the path
> ../../jython/src/org/python/... When I did checked out the python
> module there
> was no src directory. So my path is ../../jython/org/python/... I
> that's OK.
That is fine as long as you get the path to the file you expect to
modify. But -- you are checking the code out from subversion and not
from cvs correct? The cvs version is now historical, new development
is happening on subversion.