Home / Browse / Shinken / Mail / Archive

Shinken

Email Archive: shinken-devel (read-only)

2010:	_Jan (24)	_Feb (10)	_Mar (5)	_Apr	_May (19)	_Jun (32)	_Jul (78)	_Aug (69)	_Sep (50)	_Oct (45)	_Nov (74)	_Dec (137)
2011:	_Jan (205)	_Feb (177)	_Mar (59)	_Apr (58)	_May (167)	_Jun (71)	_Jul (28)	_Aug (45)	_Sep (80)	_Oct (52)	_Nov (26)	_Dec (10)
2012:	_Jan (5)	_Feb (7)	_Mar (10)	_Apr (13)	_May (8)	_Jun (11)	_Jul (47)	_Aug (40)	_Sep (33)	_Oct (23)	_Nov (12)	_Dec (1)
2013:	_Jan (15)	_Feb (30)	_Mar (30)	_Apr (19)	_May (26)	_Jun	_Jul	_Aug	_Sep	_Oct	_Nov	_Dec

[Shinken-devel] How to test code quality prior to commit?

From: Hartmut Goebel <h.goebel@go...> - 2012-07-06 11:47

Attachments: smime.p7s

Hi,

I wonder how I should check code-quality prior to commit.

Issue #373 is talking about pylint but the is no documentation about how
the project decided to call it.

test/pass_pep8-sh is using some tool called `pep8`, which I did not find
yet.

So please: How can I check code quality (and work on it)?.

-- 
Schönen Gruß
Hartmut Goebel
Dipl.-Informatiker (univ), CISSP, CSSLP

Goebel Consult
http://www.goebel-consult.de

Monatliche Kolumne:
http://www.cissp-gefluester.de/2011-10-aus-der-schublade-in-die-koepfe
Blog: http://www.goebel-consult.de/blog/20060215

Goebel Consult ist Mitglied bei http://www.7-it.de/

Re: [Shinken-devel] How to test code quality prior to commit?

From: Sébastien Coavoux <s.coavoux@fr...> - 2012-07-06 12:50

Attachments: Message as HTML

Hi,

I've created the test/pass_pep8.sh and modified the pass_pylint.sh

pep8 is a small program which is available on most repositories. You can
install it with you package manager or easy_install.

Basically pep8 checks the syntax in order to ensure a pep8 coding style. It
is a bit different from pylint actually because pylint checks deeper.

If you want to check code quality just run test/pass_pep8.sh or
test/pass_pylint.sh

Re: [Shinken-devel] How to test code quality prior to commit?

From: Hartmut Goebel <h.goebel@go...> - 2012-07-07 10:52

Attachments: smime.p7s

Hi,
> I've created the test/pass_pep8.sh and modified the pass_pylint.sh

I did not see the pylint_pass.sh. (I think we should clean up the tests
directory.)
>
> pep8 is a small program which is available on most repositories. You
> can install it with you package manager or easy_install.

Thanks.


-- 
Schönen Gruß
Hartmut Goebel
Dipl.-Informatiker (univ), CISSP, CSSLP

Goebel Consult
http://www.goebel-consult.de

Monatliche Kolumne:
http://www.cissp-gefluester.de/2011-09-kommerz-uber-recht-fdp-die-gefaellt-mir-partei

Blog: http://www.goebel-consult.de/blog/20050620

Goebel Consult ist Mitglied bei http://www.7-it.de/