IPMItool

On Fri, May 11, 2012 at 10:16 AM, Jon Bamber <Jon_Bamber@...> wrote:
> Hi
>
>   There is code in ipmi_sel.c line 1070 introduce 7 years ago in 1.39  which
> excludes writing the sensor number out in the sel list output when the
> sensor number is zero.
>
> i.e
>           if (evt->sel_type.standard_type.sensor_num != 0)
>                          printf(" #0x%02x",
> evt->sel_type.standard_type.sensor_num);
>
> I cannot see the purpose of this check as it modifies my output from
>
> 23 | Pre-Init |0000000055| Drive Slot #0x00 | Drive Present | Asserted
>
> 24 | Pre-Init |0000000055| Drive Slot #0x01 | Drive Present | Asserted
>
> to
>
> 23 | Pre-Init |0000000055| Drive Slot | Drive Present | Asserted
>
> 24 | Pre-Init |0000000055| Drive Slot #0x01 | Drive Present | Asserted
>
> Does anyone have an explanation for this or could this condition  be
> removed?
>
> Thanks
>
> Jon
>

Hello Jon,

I don't have an explanation, but I agree it is pretty weird. And I
agree this could/should be removed, if that's all in that condition.
It looks to me as a bit of inconsistent output.

My $0.02.

--Duncan

Jon,

I can't see any real reason for the special case to avoid printing zero and
I don't have any problem with removing it.

Does anyone have any objection to making this change?

-- Jim Mankovich | jmank@... --


On 5/11/2012 4:16 AM, Jon Bamber wrote:
>
> Hi
>
>   There is code in ipmi_sel.c line 1070 introduce 7 years ago in 1.39  which excludes writing the sensor number out in the sel list output when the sensor number is zero.
>
> i.e
>
>           if (evt->sel_type.standard_type.sensor_num != 0)
>
>                          printf(" #0x%02x", evt->sel_type.standard_type.sensor_num);
>
> I cannot see the purpose of this check as it modifies my output from
>
> 23 | Pre-Init |0000000055| Drive Slot #0x00 | Drive Present | Asserted
>
> 24 | Pre-Init |0000000055| Drive Slot #0x01 | Drive Present | Asserted
>
> to
>
> 23 | Pre-Init |0000000055| Drive Slot | Drive Present | Asserted
>
> 24 | Pre-Init |0000000055| Drive Slot #0x01 | Drive Present | Asserted
>
> Does anyone have an explanation for this or could this condition  be removed?
>
> Thanks
>
> Jon
>
> ______________________________________________________________________
> This email may contain privileged or confidential information, which should only be used for the purpose for which it was sent by Xyratex. No further rights or licenses are granted to use such information. If you are not the intended recipient of this message, please notify the sender by return and delete it. You may not use, copy, disclose or rely on the information contained in it.
>
> Internet email is susceptible to data corruption, interception and unauthorised amendment for which Xyratex does not accept liability. While we have taken reasonable precautions to ensure that this email is free of viruses, Xyratex does not accept liability for the presence of any computer viruses in this email, nor for any losses caused as a result of viruses.
>
> Xyratex Technology Limited (03134912), Registered in England&  Wales, Registered Office, Langstone Road, Havant, Hampshire, PO9 1SA.
>
> The Xyratex group of companies also includes, Xyratex Ltd, registered in Bermuda, Xyratex International Inc, registered in California, Xyratex (Malaysia) Sdn Bhd registered in Malaysia, Xyratex Technology (Wuxi) Co Ltd registered in The People's Republic of China and Xyratex Japan Limited registered in Japan.
> ______________________________________________________________________
>
>
>
>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>
>
> _______________________________________________
> Ipmitool-devel mailing list
> Ipmitool-devel@...
> https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
>
>