Hi all,
I just uploaded a couple of Mercurial bundles addressing three issues
(all raised by me, so it's only fair that I address them):
- #3008044: ${SCRATCH} and filename retargeting mangling paths twice
- #3056006: Benchmark reads external configuration file
- #3056019: Benchmark attempts to use external font cache
The first bundle (for #3008044) essentially removes custom file name
mangling logic in favour of the ${SCRATCH} mechanism already in place.
Several Benchmark subclasses become a whole lot simpler this way.
The other two bundles (for #3056006 and #3056019) put a new mechanism in
place so that Benchmark subclasses can ensure that the system properties
set externally don't affect the actual benchmark iteration: by
overriding Benchmark.augmentSystemProperties(Properties). So far, this
is done for avrora and fop only; I still have to analyze the other
benchmarks' use of System.getProperty and friends.
At any rate, can someone please review the changes and then
unbundle/merge them into the trunk? Thanks.
Best wishes,
Andreas
|