Home / Browse / Tux Paint / Mail / Archive

Tux Paint

Email Archive: tuxpaint-devel (read-only)

2005:	_Jan	_Feb	_Mar (15)	_Apr (5)	_May (12)	_Jun (15)	_Jul (21)	_Aug (2)	_Sep (14)	_Oct (32)	_Nov (47)	_Dec (39)
2006:	_Jan (33)	_Feb (59)	_Mar (17)	_Apr (5)	_May	_Jun (6)	_Jul (7)	_Aug (19)	_Sep (64)	_Oct (161)	_Nov (9)	_Dec (23)
2007:	_Jan (6)	_Feb (46)	_Mar (55)	_Apr (41)	_May (43)	_Jun (44)	_Jul (46)	_Aug (25)	_Sep (16)	_Oct (29)	_Nov (50)	_Dec (64)
2008:	_Jan (11)	_Feb (18)	_Mar (52)	_Apr (37)	_May (40)	_Jun (78)	_Jul (85)	_Aug (31)	_Sep (23)	_Oct (13)	_Nov (19)	_Dec (37)
2009:	_Jan (36)	_Feb (24)	_Mar (86)	_Apr (43)	_May (36)	_Jun (151)	_Jul (23)	_Aug (40)	_Sep (11)	_Oct (91)	_Nov (68)	_Dec (27)
2010:	_Jan	_Feb (11)	_Mar (79)	_Apr (50)	_May (26)	_Jun (44)	_Jul (31)	_Aug (6)	_Sep (2)	_Oct (16)	_Nov (11)	_Dec (4)
2011:	_Jan (14)	_Feb (5)	_Mar (22)	_Apr (1)	_May (5)	_Jun (5)	_Jul (13)	_Aug (1)	_Sep (3)	_Oct (18)	_Nov (15)	_Dec (25)
2012:	_Jan (1)	_Feb (9)	_Mar (41)	_Apr (32)	_May	_Jun (2)	_Jul (5)	_Aug (2)	_Sep	_Oct	_Nov	_Dec (2)
2013:	_Jan	_Feb (5)	_Mar (16)	_Apr (21)	_May (3)	_Jun	_Jul	_Aug	_Sep	_Oct	_Nov	_Dec

[Tuxpaint-devel] Fwd: Bug#652175: tuxpaint-config: FTBFS: src/tuxpaint-config2.cxx:1385:54: error: format not a string literal and no format arguments [-Werror=format-security]

From: Ben Armstrong <synrg@sa...> - 2011-12-15 16:44

Hi,

If you know how to fix this, I'd like to get it patched and uploaded
ASAP. Looks like the compiler may just be pickier than it used to be?

Thanks,
Ben

-------- Original Message --------
Subject: Bug#652175: tuxpaint-config: FTBFS:
src/tuxpaint-config2.cxx:1385:54: error: format not a string literal and
no format arguments [-Werror=format-security]
Resent-Date: Thu, 15 Dec 2011 11:09:02 +0000
Resent-From: Mònica Ramírez Arceda <monica@...>
Resent-To: debian-bugs-dist@...
Resent-CC: Ben Armstrong <synrg@...>
Date: Thu, 15 Dec 2011 11:18:10 +0100
From: Mònica Ramírez Arceda <monica@...>
Reply-To: Mònica Ramírez Arceda <monica@...>, 652175@...
To: submit@...

Source: tuxpaint-config
Version: 0.0.12-2
Severity: serious
Tags: wheezy sid
User: debian-qa@...
Usertags: qa-ftbfs-20111210 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
> g++ -Wall -g -O2 `fltk-config --cxxflags` -DDATA_PREFIX=\"/usr/share/tuxpaint-config/\" -D__SOUND -DDOC_PREFIX=\"/usr/share/doc/tuxpaint-config/\" -DLOCALEDIR=\"/usr/share/locale/\" -DCONFDIR=\"/etc/tuxpaint\" -DVER_VERSION=\"0.0.12\" -DVER_DATE=\"`date +"%Y-%m-%d"`\" -c src/tuxpaint-config2.cxx -o obj/tuxpaint-config2.o
> src/tuxpaint-config2.cxx: In function 'void cb_CHOICE_settings(Fl_Choice*, void*)':
> src/tuxpaint-config2.cxx:1385:54: error: format not a string literal and no format arguments [-Werror=format-security]
> cc1plus: some warnings being treated as errors
> 
> make[1]: *** [obj/tuxpaint-config2.o] Error 1

The full build log is available from:

http://people.debian.org/~lucas/logs/2011/12/10/tuxpaint-config_0.0.12-2_lsid64.buildlog

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot.  Internet was not
accessible from the build systems.

Re: [Tuxpaint-devel] Fwd: Bug#652175: tuxpaint-config: FTBFS: src/tuxpaint-config2.cxx:1385:54: error: format not a string literal and no format arguments [-Werror=format-security]

From: Bill Kendrick <nbs@so...> - 2011-12-16 23:32

On Thu, Dec 15, 2011 at 12:13:51PM -0400, Ben Armstrong wrote:
> Hi,
> 
> If you know how to fix this, I'd like to get it patched and uploaded
> ASAP. Looks like the compiler may just be pickier than it used to be?

Here's a fix:

$ cvs diff src/tuxpaint-config2.cxx
Index: src/tuxpaint-config2.cxx
===================================================================
RCS file: /cvsroot/tuxpaint/tuxpaint-config/src/tuxpaint-config2.cxx,v
retrieving revision 1.106
diff -r1.106 tuxpaint-config2.cxx
1387d1386
<     char question[256];
1401,1403c1400,1401
<     snprintf(question, sizeof(question), gettext("Apply changes you made to %s?"), user);
<     if (fl_choice(gettext(question),
<                   gettext("No"), gettext("Yes"), NULL))
---
>     if (fl_choice(gettext("Apply changes you made to %s?"),
>                   gettext("No"), gettext("Yes"), NULL, user))


Helpful?

-bill!

Re: [Tuxpaint-devel] Fwd: Bug#652175: tuxpaint-config: FTBFS: src/tuxpaint-config2.cxx:1385:54: error: format not a string literal and no format arguments [-Werror=format-security]

From: Ben Armstrong <synrg@sa...> - 2011-12-19 10:05

On 16/12/11 07:32 PM, Bill Kendrick wrote:
> Here's a fix:
> 
> $ cvs diff src/tuxpaint-config2.cxx
> Index: src/tuxpaint-config2.cxx
> ===================================================================
> RCS file: /cvsroot/tuxpaint/tuxpaint-config/src/tuxpaint-config2.cxx,v
> retrieving revision 1.106
> diff -r1.106 tuxpaint-config2.cxx
> 1387d1386
> <     char question[256];
> 1401,1403c1400,1401
> <     snprintf(question, sizeof(question), gettext("Apply changes you made to %s?"), user);
> <     if (fl_choice(gettext(question),
> <                   gettext("No"), gettext("Yes"), NULL))
> ---
>>     if (fl_choice(gettext("Apply changes you made to %s?"),
>>                   gettext("No"), gettext("Yes"), NULL, user))
> 
> 
> Helpful?

Perfect. Thanks!

Ben