Music Player Daemon

Hi all!

I've seen you added support for embedded cue sheets in flac files.
Great!

Now I have a proposal how to go on from there. The cue sheet embedded in
a flac file doen't contain any information about track titles and
similar. There are three possibilities: Use an external cue sheet that
includes these information, use a tag CUESHEET with a cue sheet
including these information or use tags. I think the latter is the best
option and is already used by other projects.
Please find attached a patch that does the following:

Let's pretend we've got a flac file TheExamples/Whatever.flac with the
following tags:

ARTIST=The Examples
ALBUM=Whatever
DATE=2009
TITLE1=The Good
TITLE2=The Bad
TITLE3=The Ugly

This flac file will turn up in mpd's database as:

directory: TheExamples
mtime: 1237149906
begin: TheExamples
directory: Whatever.flac
mtime: 1237149850
begin: TheExamples/Whatever.flac
songList begin
key: track_001.flac
file: TheExamples/Whatever.flac/track_001.flac
Time: 98
Artist: The Examples
Album: Whatever
Date: 2009
Title: The Good
Track: 1
mtime: 1237149850
key: track_002.flac
file: TheExamples/Whatever.flac/track_002.flac
Time: 111
Artist: The Examples
Album: Whatever
Date: 2009
Title: The Bad
Track: 2
mtime: 1237149850
key: track_003.flac
file: TheExamples/Whatever.flac/track_003.flac
Time: 149
Artist: The Examples
Album: Whatever
Date: 2009
Title: The Ugly
Track: 3

What do you think about it?

cu

   Mario

PS
I'm not a programmer, so I'm not sure if I created the diff the right
way. I've run "git --no-pager diff > mario.diff" from inside the mpd
directory.

--
Rule One: Do not act incautiously when confronting little bald wrinkly
smiling men.

Re: [Musicpd-dev-team] embedded cue sheets in flac files (recently added to repository) From: Max Kellermann <max@du...> - 2009-03-16 18:40 On 2009/03/15 23:31, Mario Lenz <m@...> wrote: > Now I have a proposal how to go on from there. The cue sheet embedded in > a flac file doen't contain any information about track titles and > similar. There are three possibilities: Use an external cue sheet that > includes these information, use a tag CUESHEET with a cue sheet > including these information or use tags. I think the latter is the best > option and is already used by other projects. > Please find attached a patch that does the following: That's an interesting idea. I have merged your patch, it doesn't hurt to have it. There's one issue: if there is a TITLE tag before TITLE1, then MPD will use both. That can be fixed easily, I think. Which other projects do use this method? Is it documented somewhere? Max

Re: [Musicpd-dev-team] embedded cue sheets in flac files (recently added to repository) From: Mario Lenz <m@ri...> - 2009-03-16 21:07 On 2009/03/16 19:40, Max Kellermann <max@...> wrote: > There's one issue: if there is a TITLE tag before TITLE1, > then MPD will use both. Yep, I know. This is true for every other tag, too. But I thought a quick'n'dirty hack *now* would be better than a proper solution some vague time in the future :-) > Which other projects do use this method? I've just started to archive some of my music this way, that is one big flac file with an embedded cue sheet per CD. When I was looking for a tagging scheme, I found one with the track number directly attached (TITLE1) and one written like an array (TITLE[1]). Now that I'm looking for it, I can't find the scheme I've used. Probably it's been used by some project that isn't active any more :-/ Anyway, the $TAGNAME[$TRACKNUMBER] scheme seems to be supported by at least two relatively well-known programs, foobar2000 and SlimServer. If you want me to, I'll send you another patch to make mpd support this scheme instead of the other one. > Is it documented somewhere? I havn't found any proper documentation, but have a look at this: http://forums.slimdevices.com/showpost.php?p=265545&postcount=6 http://www.mail-archive.com/discuss@...> cu Mario -- Strong people don't need strong leaders.

Re: [Musicpd-dev-team] embedded cue sheets in flac files (recently added to repository) From: Max Kellermann <max@du...> - 2009-03-17 08:02 On 2009/03/16 22:06, Mario Lenz <m@...> wrote: > On 2009/03/16 19:40, Max Kellermann <max@...> wrote: > > > There's one issue: if there is a TITLE tag before TITLE1, > > then MPD will use both. > > Yep, I know. This is true for every other tag, too. But I thought a > quick'n'dirty hack *now* would be better than a proper solution some > vague time in the future :-) Agree. Your patch is an improvement, and this problem is not a regression - it will not break older setups. > > Which other projects do use this method? > > I've just started to archive some of my music this way, that is one big > flac file with an embedded cue sheet per CD. When I was looking for a > tagging scheme, I found one with the track number directly attached > (TITLE1) and one written like an array (TITLE[1]). > > Now that I'm looking for it, I can't find the scheme I've used. Probably > it's been used by some project that isn't active any more :-/ > > Anyway, the $TAGNAME[$TRACKNUMBER] scheme seems to be supported by at > least two relatively well-known programs, foobar2000 and SlimServer. > If you want me to, I'll send you another patch to make mpd support this > scheme instead of the other one. There doesn't seem to be an "official" standard. I'd say: search for TITLE[1] first (the most explicit form), then TITLE1, and finally fall back to TITLE. This makes sure MPD supports every possible standard, without breaking. Max

Re: [Musicpd-dev-team] embedded cue sheets in flac files (recently added to repository) From: Mario Lenz <m@ri...> - 2009-03-17 11:36 Attachments: mario2.diff      On 2009/03/17 Max Kellermann<max@...> wrote: > There doesn't seem to be an "official" standard. I'd say: search for > TITLE[1] first (the most explicit form), then TITLE1, and finally fall > back to TITLE. This makes sure MPD supports every possible standard, > without breaking. I've also added some additional checks to make sure entry is long enough. cu Mario -- In a world without walls and fences, who needs Windows and Gates?

Re: [Musicpd-dev-team] embedded cue sheets in flac files (recently added to repository) From: Jochen Keil <jochen.keil@gm...> - 2009-03-17 11:41 Attachments: signature.asc      Hi, Mario Lenz wrote: > includes these information, use a tag CUESHEET with a cue sheet That's what i'm doing at the moment. The cuesheet parser is done and it can parse strings as well. There's also the code for tagging the flac-sub-tracks after the cuesheet info. > including these information or use tags. I think the latter is the best > option and is already used by other projects. Embedding track infos as vorbis comments would look like the example below. I'm taking here the metaflac program as a reference since it gets shipped with libflac. There is no standard defined and we will get lost in adding every possible way of tagging this stuff. Examples: (This is a completely untagged flac file) $ metaflac --list some.flac METADATA block #0 type: 0 (STREAMINFO) is last: false length: 34 minimum blocksize: 4608 samples maximum blocksize: 4608 samples minimum framesize: 16 bytes maximum framesize: 15750 bytes sample_rate: 44100 Hz channels: 2 bits-per-sample: 16 total samples: 71210916 MD5 signature: 46314ee64963fed05b57c73c846b244b METADATA block #1 type: 1 (PADDING) is last: true length: 57035 (Now i'm using the import-tags-from feature of metaflac) $ cat sometags.txt GENRE=somegenre DATE=1992 PERFORMER="someperformer" TITLE="sometitle" TRACK01=title1 TRACK02=title2 SOMELOVELYTAG=yeahrightheregoesinwhateveryouwant $ metaflac --import-tags-from=sometags.txt some.flac $ metaflac --list some.flac METADATA block #0 [..] METADATA block #1 type: 4 (VORBIS_COMMENT) is last: false length: 210 vendor string: reference libFLAC 1.2.1 20070917 comments: 7 comment[0]: GENRE=somegenre comment[1]: DATE=1992 comment[2]: PERFORMER="someperformer" comment[3]: TITLE="sometitle" comment[4]: TRACK01=title1 comment[5]: TRACK02=title2 comment[6]: SOMELOVELYTAG=yeahrightheregoesinwhateveryouwant METADATA block #2 [..] So i'd say let's got for the cuesheet option as it is at least "defined" (though there is no real standard too). If you want do it like Max proposed, i'd recommend writing a parser using lex/yacc. That's what i had in mind on the long run. What will be there the next few days though is support for embedded cuesheets with cdtext info. metaflac --import-cuesheet-from=file will not only import the seekpoints but also add the the whole cuesheet with cdtext infos as CUESHEET=file vorbis comment. Regards, Jochen

Re: [Musicpd-dev-team] embedded cue sheets in flac files (recently added to repository) From: Mario Lenz <m@ri...> - 2009-03-17 13:20 Jochen Keil wrote: > So i'd say let's got for the cuesheet option as it is at least > "defined" (though there is no real standard too). So a non- standard solution involving a complex task like developing a cuesheet parser is superior to another non- standard solution that simply changes a handfull of lines in your code? > What will be there the next few days though is support for embedded > cuesheets with cdtext info. Talking about getting "lost in adding every possible way of tagging this stuff": What other players support parsing this CUESHEET tag? The $TAGNAME[$TRACKNUMBER] scheme seems to be supported by at least SqueezeCenter (formerly SlimServer) and foobar2000. > metaflac --import-cuesheet-from=file will not only import the > seekpoints but also add the whole cuesheet with cdtext infos as > CUESHEET=file vorbis comment. metaflac 1.2.1 doesn't. Anyway: My changes shouldn't break anything, so I would like to see them stay there. However, since I didn't find any other player using the $TAGNAME$TRACKNUMBER scheme I suggested first, I don't object to removing it. cu Mario -- In a world without walls and fences, who needs Windows and Gates?

Re: [Musicpd-dev-team] embedded cue sheets in flac files (recently added to repository) From: Max Kellermann <max@du...> - 2009-03-17 13:38 On 2009/03/17 14:20, Mario Lenz <m@...> wrote: > Jochen Keil wrote: > > > So i'd say let's got for the cuesheet option as it is at least > > "defined" (though there is no real standard too). > > So a non- standard solution involving a complex task like developing a > cuesheet parser is superior to another non- standard solution that > simply changes a handfull of lines in your code? Yes, definitely. Only standards guarantee good interoperability. And I'm not talking about interoperability with software which doesn't follow the standard. I don't care much about that. > Anyway: My changes shouldn't break anything That's important. Until we have full cuesheet support, I don't object having a hack (which is supported by at least one other major media player). Mario, your patch is useful for some people, this is why I merged it. But since it's non-standard, we may decide to remove it at any time, when we have a better solution. Max

Re: [Musicpd-dev-team] embedded cue sheets in flac files (recently added to repository) From: Jochen Keil <jochen.keil@gm...> - 2009-03-17 13:42 Attachments: signature.asc      Hi Mario Lenz wrote: > So a non- standard solution involving a complex task like developing a > cuesheet parser is superior to another non- standard solution that > simply changes a handfull of lines in your code? If you consider this a complex task than this must not mean that it's a difficult job for someone else. Writing a parser in lex/yacc is far superior and easier to do than a bunch of strcmp's nested in if statements. Despite that you might want to take a look at this: http://digitalx.org/cuesheetsyntax.php and http://developer.berlios.de/docman/display_doc.php?docid=517&group_id=2130 This may not be a defined standard but it's well documented, on a common base and everybody sticks to it. > What other players support parsing this CUESHEET tag? foobar2000 > metaflac 1.2.1 doesn't. $ metaflac --version metaflac 1.2.1 You should check your installation. Regards, Jochen

Re: [Musicpd-dev-team] embedded cue sheets in flac files (recently added to repository) From: Mario Lenz <m@ri...> - 2009-03-17 16:44 Max Kellermann wrote: > On 2009/03/17 14:20, Mario Lenz <m@...> wrote: > > Jochen Keil wrote: > > > > > So i'd say let's got for the cuesheet option as it is at least > > > "defined" (though there is no real standard too). > > > > So a non- standard solution involving a complex task like developing a > > cuesheet parser is superior to another non- standard solution that > > simply changes a handfull of lines in your code? > > Yes, definitely. Only standards guarantee good interoperability. And > I'm not talking about interoperability with software which doesn't > follow the standard. I totally agree with you about standards! The problem is: There isn't any. Cuesheets are a (de-facto) standard. Storing them in a CUESHEET tag isn't afaik. > Mario, your patch is useful for some people, this is why I merged it. > But since it's non-standard, we may decide to remove it at any time, > when we have a better solution. I was looking for a solution to tag a multi track flac. If other players support your way, I'm fine with it. I'll give it a try as soon as Jochen merged his solution. cu Mario -- One truth of computing is that the crapness of a product is proportional to how high up in the organisation they start to market it.

Re: [Musicpd-dev-team] embedded cue sheets in flac files (recently added to repository) From: Mario Lenz <m@ri...> - 2009-03-17 16:47 Jochen Keil wrote: > This may not be a defined standard but it's well documented, on a common > base and everybody sticks to it. Cuesheets are well documented, but storing one in a CUESHEET tag isn't afaik. But I might be wrong there. > > What other players support parsing this CUESHEET tag? > foobar2000 Oh, ok. When I was looking for a tagging scheme fit for multi track flacs I didn't find any player supporting a cuesheet inside a CUESHEET tag. Embedded cuesheets, yes. But with the song titles in tags. If there are other players doing it your way... >> metaflac 1.2.1 doesn't. > $ metaflac --version > metaflac 1.2.1 > > You should check your installation. Well, I did. Are you sure you meant > metaflac --import-cuesheet-from=file and not metaflac --set-tag-from-file="CUESHEET=file" --import-cuesheet-from=file cu Mario -- o L_ OL This is Schäuble. Copy Schäuble into your signature to help him on his way to Überwachungsstaat.

Re: [Musicpd-dev-team] embedded cue sheets in flac files (recently added to repository) From: Jochen Keil <jochen.keil@gm...> - 2009-03-17 20:06 Attachments: signature.asc      Hi Mario, Mario Lenz wrote: >>> What other players support parsing this CUESHEET tag? >> foobar2000 > > Oh, ok. When I was looking for a tagging scheme fit for multi track > flacs I didn't find any player supporting a cuesheet inside a CUESHEET > tag. Embedded cuesheets, yes. But with the song titles in tags. > If there are other players doing it your way... That's a problem with flac files in general. The flac library gives you the option to store per-track-seekpoints but not per-track-comments. I just took a look at some of my flac files which i generated using foobar. They have indead a bunch of comments like this: comment[0]: CUE_TRACK02_album=Blues For The Red Sun comment[1]: CUE_TRACK02_artist=Kyuss comment[2]: CUE_TRACK02_comment=EAC 0.9beta4 / FLAC 1.1.0 q6 comment[3]: CUE_TRACK02_date=1992 comment[4]: CUE_TRACK02_genre=Other comment[5]: CUE_TRACK02_title=Green Machine comment[6]: CUE_TRACK02_totaltracks=14 comment[7]: CUE_TRACK02_tracknumber=2 and so on.. But this seems to be *very* player specific. If you go on and support that one player specific tagging scheme somebody will come up with some other player and we end up in supporting several tagging schemes which might change in future and so on.. That's why i say we should stick to that cuesheet block. Maybe there'll be a good per-track tagging scheme with libflac one day. Until then i think it's better to agree on the lowest common demoniator. > Well, I did. Are you sure you meant > >> metaflac --import-cuesheet-from=file > > and not > > metaflac --set-tag-from-file="CUESHEET=file" --import-cuesheet-from=file This will store a "file" in a vorbis comment called "CUESHEET" and add the seekpoints from "file". If you have a file that looks like this: GENRE=somegenre DATE=1992 PERFORMER="someperformer" TITLE="sometitle" TRACK01=title1 TRACK02=title2 SOMELOVELYTAG=yeahrightheregoesinwhateveryouwant you'll be able to store the single tags with --import-tags-from=file. Output should then look like this: comment[0]: GENRE=somegenre comment[1]: DATE=1992 comment[2]: PERFORMER="someperformer" comment[3]: TITLE="sometitle" comment[4]: TRACK01=title1 comment[5]: TRACK02=title2 comment[6]: SOMELOVELYTAG=yeahrightheregoesinwhateveryouwant Hope that helped and cleared things up a bit, Jochen

7 messages have been excluded from this view by a project administrator.