Patch looks OK to me. Only comment is that in the man page edits, the
word 'test' should be changed to 'check'. We use the word 'test' for
SMART self-tests, not for smartd polling checks.
Christian, if you agree can you please add the patch to CVS HEAD?
On Sat, 1 Nov 2008, Michal Hlavinka wrote:
> patch against today's CVS is attached (patch against 5.38 is also available if you want)
> works (N>0):
> -n something
> -n something,N
> -n something,N,q
> -n something,q
> produces error message:
> -n something,blah
> -n something,N (for N<=0)
> -n something,q,N (for any N)
> -n blah
> N means "skip at most N tests" = "if there was skipped N tests in a row, N+1 test will be performed no matter what powermode is"
> ----- Original Message -----
> From: Bruce Allen <ballen@...>
> To: Michal Hlavinka <mhlavink@...>
> Cc: smartmontools-support@...
> Sent: Fri, 31 Oct 2008 09:16:22 -0400 (EDT)
> Subject: Re: [smartmontools-support] feature: Skip at most x tests for -n something
>>>>> New option for -n will be very useful here. For example -n standby,10
>>>>> (skip at most 10 tests)
>>>>> What's your opinion?
>>>> I'd be happy to accept a code patch that does this, provided that:
>>>> -n standby and -n standby,0
>>>> reproduce the current behavior,
>>> You mean 0 for compatibility or disabling this feature or why?
>>> Because if -n something,N means skip at most N tests
>>> thus N=0 means skip 0 tests at most which seems to me as not so easy to
>> OK, you are right, this is confusing. Better to require that N be
>> positive, and generate a clean error message if N is negative OR zero.