-----BEGIN PGP SIGNED MESSAGE-----
>>> so what about just "GHOST_REPLAY" for the time being, until a usable version of it is
>>> there with GUI-support for that feature?
>> Well, we are discussing about 5 lines in configure.ac and a more
>> standardised name for the affected #ifdefs. The latter is purely cosmetic.
> dont get me wrong, i think its too much. if i (or anybody else) want to switch it
> on, i just put the -DGHOST_REPLAY to the makefile or to the vc-compiler-switches.
> i dont see any advantage, its just more maintainance..
> i would agree with you, if it was supposed to be in the final version, but its just temporary ..
That's what I meant in my previous email. So again: Just leave the
replay #ifdefs it the way they are, it will be gone in a few days (are
you feeling pressured Maik??? :) Take your time, seriously). Maik might
have finished it by now if he hadn't spent that much time writing emails
about it (ok, that's an exaggeration :) ).
>> This way we only have to add
>> #include "defines.hpp" in all other files, and if we add support for
>> another platform, we only have to modify one file.
>> (or is this actually what you meant???)
> yepp .. :)
> but i think its too much as well ;) why would we want to include header-files to all
> sourcefiles, which work fine right now .. i just dont see any advantage here too ..
> but i may be wrong .. ;)
I am happy with either build process - using config.h, or a long command
line. Doesn't matter, as long as it's not inconvenient for the user -
and neither one is. I thought you (Maik) was proposing that we
could/should use platform dependent config files. If we do, we should do
it the way I've described (and obviously not having that long #ifdef
statement everywhere). But otherwise, just leave it the way it is.
As a summary: If Robert is willing to config.h-ify the sources, fine
(and thanks) - go ahead. The new version should just not assume that
there is a config.h file (which it doesn't, so I am mentioning the
obvious here ;)) ). Leave the REPLAY the way it is, these #ifdef will
be gone soon, no sense to waste any time discussing this, let's indeed
focus on more features and bug fixes.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----