Timur Tabi wrote:
> Tolunay Orkun wrote:
>> This patch:
>> * Adds support for AMD command set Top Boot flash geometry reversal
>> * Adds support for displaying command set, manufacturer id and
>> device ids (flinfo)
>> * Makes flinfo output to be consistent when CFG_FLASH_EMPTY_INFO
>> * Removes outdated change history (refer to git log instead)
> This patch looks good, but I get this from flinfo:
> Bank # 1: CFI conformant FLASH (16 x 16) Size: 8 MB in 135 Sectors
> AMD Standard command set, Manufacturer ID: 0xFF, Device ID: 0xFF
> Erase timeout: 16384 ms, write timeout: 1 ms
> Are these the correct values for manufacturer ID and device ID?
Thanks for testing the patch. Not correct. It is cosmetic in your case
since your flash CFI is version 1.1 or later.
It looks like I cannot access JEDEC IDs while still in CFI Query mode in
AMD style flash (unlike Intel). Bummer :( I have to explicitly send the
autoselect command to read out and switch back to CFI Query mode again.
I will improve the patch. Also, while browsing Spansion web site, I came
across with 3 byte Device IDs. So, we have to improve on that as well.