On Apr 12, 2006, at 8:33 PM, Stu Tomlinson wrote:
> On Tue, 2006-04-11 at 21:04 -0400, Evan Schoenberg wrote:
>> On Apr 11, 2006, at 8:36 PM, Stu Tomlinson wrote:
>>>> Log Message:
>>>> Namespacing the msn prpl's utils.c and utils.h to msn-utils.c and
>>> Why was this necessary?
>> I was looking at a flat listing of the files under src (in my IDE)
>> had to click through multiple utils.* files to find the one I was
>> looking for...
> So you have a crap IDE and we should accommodate workarounds for it
I wasn't aware that this was a function of a crap IDE. I'll keep in
mind that others don't look at flat file listings in the future.
>> it seemed that with the newfound ease of clean renaming subversion
>> offers it made sense to make the names unique.
> ... "because we can, we should" ?
"because we can, we can." No implications on 'should', as this
conversation clearly demonstrates.
>> Did I overlook a reason not to do so?
> Yes, it's completely stupid. If you have a broken IDE that you can't
> work with, then you need to fix that.
I can work with my IDE just fine, though since I don't have any
choice in the matter if I want to use the same IDE across the
projects in which I'm involved, I couldn't 'fix that' if I couldn't.
Within my IDE, Xcode, among other views of the files in a tree, one
is a flat listing of all files underneath the selected folder. I
often use the name search within that listing to jump to a specific
file. Unique file names make that process much easier when starting
from the project root.
> These files are in separate
> directories, they don't need further "namespacing" to provide unique
> filenames across the source tree.
Okay. I'm still unclear as to why the change is problematic rather
than simply "somewhat superfluous" or "not any better than the
current setup for most developers" (the latter of which I hadn't
considered to be the case, but I'm apparently in the minority in
caring at all), but I don't feel strongly about the issue as it is
A second reason for uniquing the names which I forgot in my original
explanation: Unique file names also make static compilation more
straightforward, especially if the headers from multiple directories
(src, the prpls, etc.) end up in a single Headers directory where
they would otherwise overwrite one another.
> There are also 2 distinct files with the names chat.c, cmds.c, ft.c,
> history.c, idle.c, internal.h, jabber.c, jabber.h, notify.c, simple.c,
> util.h; 3 distinct files called buddy.c and 4 of util.c
> Please don't tell me you plan to rename all of these?
I was planning to take care of what I perceived as a problem when I
had time to do so, so yes, I did before this conversation.