Celestia

Pat,

OK, I downloaded the archive and built

Celestia-kde
Celestia-gtk
Celestia-gnome

without any problems...

++++++++++++++++
However, I noticed one problem in your gtk and gnome versions: The time 
display in the upper right corner sits too far on the right such that 
the /bright green Light-time delay indicator (LT)/ is cut off: After 
pushing the '-' key and selecting e.g. Saturn, the green 'LT' mark must 
be visible to the right of the time zone!

It is essential to display it, otherwise people may get tremendously 
confused...I am also not sure whether the LT subtraction was not broken 
by a coder who forgot about the existence of the LT subtraction...;-) . 
I'll look into that ASAP.
++++++++++++++++

Bye Fridger



Pat Suwalski wrote:
> Okay, I gave up with that am_edit and just ran it by hand. I don't 
> know if that's the correct solution, it pollutes Makefile.ins pretty 
> badly. But it seems to work well.
>
> I've uploaded the autopackage to upload.sf.net so it can be added to 
> the download list. I've verified it works. Chris?
>
> I made a clean source package with make dist on a cleanly installed 
> Debian sarge. I would like someone else to try it before it gets 
> uploaded to SF, in case something went wrong.
>
> Source is here:
>
>     http://pat.suwalski.net/celestia/misc/celestia-1.4.0.tar.bz2
>
>     MD5SUM: 2bce74c2832acfce029290ee6427ded6
>
> I opted for bzip2 because it does save some size:
>
> -rw-r--r--  1 pat pat 24995825 2005-12-22 12:39 celestia-1.4.0.tar.gz
> -rw-r--r--  1 pat pat 23681393 2005-12-22 12:39 celestia-1.4.0.tar.bz2
>
> Over 1MB is starting to get somewhat significant.
>
> --Pat
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through log 
> files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> _______________________________________________
> Celestia-developers mailing list
> Celestia-developers@...
> https://lists.sourceforge.net/lists/listinfo/celestia-developers

I'll upload the autopackage . . .  Should we make a new file package for
this on SourceForge? Or should we just reuse Celestia-unix? If there's
some sort of convention here, I'd like to follow it.

And just to make sure that I understand: autopackage is a source
distribution that will build on any Linux system with Gtk 2.6?

--Chris

> Okay, I gave up with that am_edit and just ran it by hand. I don't know
> if that's the correct solution, it pollutes Makefile.ins pretty badly.
> But it seems to work well.
>
> I've uploaded the autopackage to upload.sf.net so it can be added to the
> download list. I've verified it works. Chris?
>
> I made a clean source package with make dist on a cleanly installed
> Debian sarge. I would like someone else to try it before it gets
> uploaded to SF, in case something went wrong.
>
> Source is here:
>
> 	http://pat.suwalski.net/celestia/misc/celestia-1.4.0.tar.bz2
>
> 	MD5SUM: 2bce74c2832acfce029290ee6427ded6
>
> I opted for bzip2 because it does save some size:
>
> -rw-r--r--  1 pat pat 24995825 2005-12-22 12:39 celestia-1.4.0.tar.gz
> -rw-r--r--  1 pat pat 23681393 2005-12-22 12:39 celestia-1.4.0.tar.bz2
>
> Over 1MB is starting to get somewhat significant.
>
> --Pat
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through log
> files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> _______________________________________________
> Celestia-developers mailing list
> Celestia-developers@...
> https://lists.sourceforge.net/lists/listinfo/celestia-developers
>

Pat,

I made sure, the LT travel delay subtraction is NOT broken. Neither in 
Celestia-KDE nor in your two flavors. But as I wrote, in your case the 
crucial LT mark is cut off!

Bye Fridger

Fridger Schrempp wrote:
> However, I noticed one problem in your gtk and gnome versions: The time
> display in the upper right corner sits too far on the right such that
> the /bright green Light-time delay indicator (LT)/ is cut off: After
> pushing the '-' key and selecting e.g. Saturn, the green 'LT' mark must
> be visible to the right of the time zone!

I'm afraid I'm confused. I don't have any code that does anything with
light-time. Isn't this drawn by the core?

Is this really a showstopper? I would personally like to release as is.
I'll take a quick peek at the code this evening anyway.

--Pat

Pat,

I just booted Windows to have a look: Also here, the time display is further 
to the left such that the bright green LT mark is correctly displayed after 
pushing the '-' key.

So Celestia-gnome and Celestia-gtk are the only ones that break the LT display 
feature.

Bye Fridger

 > Fridger Schrempp wrote:
> Sure it's core code, but whatever the reason, your time output is too 
> far on the rhs of the canvas such that the LT mark is cut-off. Just 
> compare how it looks in Celestia-KDE.
> 
> Otherwise one has NO idea whether LT-delay subtraction is on or off. I 
> don't recall what the LT display status is in Windows.
> 
> Bye Fridger




Pat Suwalski wrote:
> Fridger Schrempp wrote:
>   
>> However, I noticed one problem in your gtk and gnome versions: The time
>> display in the upper right corner sits too far on the right such that
>> the /bright green Light-time delay indicator (LT)/ is cut off: After
>> pushing the '-' key and selecting e.g. Saturn, the green 'LT' mark must
>> be visible to the right of the time zone!
>>     
>
> I'm afraid I'm confused. I don't have any code that does anything with
> light-time. Isn't this drawn by the core?
>
> Is this really a showstopper? I would personally like to release as is.
> I'll take a quick peek at the code this evening anyway.
>
> --Pat
>

Fridger Schrempp wrote:
> I made sure, the LT travel delay subtraction is NOT broken. Neither in
> Celestia-KDE nor in your two flavors. But as I wrote, in your case the
> crucial LT mark is cut off!

Okay, problem solved.

I don't use CelestiaCore::setTimeZoneName() anywhere in my code because
the core seems to display it properly without that.

However, if that function is not called, the core does not display the
LT label. It probably has something to do with celestiacore.cpp:2947,
where it tries to access timeZoneName.length() and gets a NULL back.

As a workaround, I just set the time zone name to UTC at startup. I
tested it, and it works.

--Pat

Perfect, Pat,...

I just compiled your modification in the CVs. That's how it should look 
like.

Bye Fridger

Pat Suwalski wrote:
> Fridger Schrempp wrote:
>   
>> I made sure, the LT travel delay subtraction is NOT broken. Neither in
>> Celestia-KDE nor in your two flavors. But as I wrote, in your case the
>> crucial LT mark is cut off!
>>     
>
> Okay, problem solved.
>
> I don't use CelestiaCore::setTimeZoneName() anywhere in my code because
> the core seems to display it properly without that.
>
> However, if that function is not called, the core does not display the
> LT label. It probably has something to do with celestiacore.cpp:2947,
> where it tries to access timeZoneName.length() and gets a NULL back.
>
> As a workaround, I just set the time zone name to UTC at startup. I
> tested it, and it works.
>
> --Pat
>

I'll flip the order of the quotes so it makes more sense. :)

Chris Laurel wrote:
> And just to make sure that I understand: autopackage is a source
> distribution that will build on any Linux system with Gtk 2.6?

Autopackage is a binary package. The binary has quite a bit statically
compiled in, and will run on just about anything that is 32-bit x86.
It's like a Windows Installer for Linux, complete with wizard. It is
distribution-agnostic.

> I'll upload the autopackage . . .  Should we make a new file package for
> this on SourceForge? Or should we just reuse Celestia-unix? If there's
> some sort of convention here, I'd like to follow it.

The way I see it, "Celestia-unix" is really something that should be
deprecated. It really makes no sense, as classically we've had the
source there.

I'd like to see it as "Source Code" for the source (duh!). Other
projects seem to consolidate all of the binaries into one blob (exe's
together with rpm's etc). For us, it might make sense to make a
"Celestia-Linux" category akin to the "Celestia-macosx" category and
dump all Linux binaries in there. There is no restriction to how many
files can be there for each version number.

I'm just in the process of creating a new autopackage for Linux with the
LT-delay fix. The source code obviously can't go up since the MacOS guys
are still at it. But the binary can. I'll send mail when I'm done.

--Pat