Many apologies for the delay on this...
IIRC, it was name of -finemessage, and whether it was necessary to
truncate the messages at 255. The most useful message in ther thread
You aren't truncating the message any more, so that is great. Kevin
suggested "-detail" instead of "-finemessage", which seems fine to me.
He also suggested just concatenating -message & -detail for now on
Windows - where there isn't a standard smaller font bit of the dialog.
Doing that on Windows & X11 would be pretty easy, and then if somebody
wanted to do more on these platforms later, they would be welcome.
If you can update the TIP and do these changes, I will reopen it for
discussion and call for a vote after a seemly interval. I didn't read
the code with a fine-tooth comb, but it seems fine. You will have to
do a few formating things, like wrap lines at 80 characters, and don't
Tcl_InitStubs( interp, "8.1", 0 )
Tcl_InitStubs(interp, "8.1", 0)
and don't indent with tabs - which relies on tabs being set at 4
characters, but indent with pure whitespace (actually, you may be fine
at keeping within the 80 char. limit if I had 4-space tabs, which I
don't...) Also, don't use "//" for comments.
In general, the code looks pretty clean. Sorry to be a bit picky about
this, I just let too many little errors slip in when we were doing the
9->X port, and I would rather keep them at a minimum in new code.
On Monday, August 25, 2003, at 6:12 AM, Daniel A. Steffen wrote:
> On Monday, Aug 25, 2003, at 23:03 Australia/Sydney, Mats Bengtsson
>> We've had this discussion already when I wrote the TIP for the message
>> box on classic. Except for the -finemessage option, which can be
>> removed, my tk_messageBox does not add anything that is not there
>> and it implements all documented features completely. It is therefore
>> completely compatible with the existing tk_messageBox on all
>> platforms. It is an "implementation issue" that just uses the
>> degree of freedom that already exist in the porting layer.
>> So please someone....
> ah ok, so if I understand correctly it's either
> withdraw tip 25, remove -finemessage, and integrate so updated
> changes ASAP
> ask for vote on updated tip 25, if accepted, integrate current changes
> IMHO, if we can get it, the -finemsg functionality would be nice...
> AFAIR (faintly), the only objection to tip 25 was the wording of
> -finemessage, if you dig up the old discussions and updated the TIP
> accordingly (also referencing OSX instead of OS9 etc), I don't see a
> reason why this wouldn't be accepted. There might be some minor work
> involved to get -finemessage (or whatever it gets renamed to) working
> on X11 and Windows.
> ** Daniel A. Steffen ** "And now for something completely
> ** Dept. of Mathematics ** different" Monty Python
> ** Macquarie University ** <mailto:steffen@...>
> ** NSW 2109 Australia ** <http://www.maths.mq.edu.au/~steffen/>
> This SF.net email is sponsored by: VM Ware
> With VMware you can run multiple operating systems on a single machine.
> WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines
> at the same time. Free trial click
> Tcl-mac mailing list
Jim Ingham jingham@...