On Wed, Aug 01, 2001 at 08:36:54PM +0200, Martin Atzmueller wrote:
> William Harold Newman wrote:
> > On Wed, Aug 01, 2001 at 05:06:08PM +0200, Martin Atzmueller wrote:
> > > Attached is a patch for src/pcl/walk.lisp, and some test code for that
> > > (based upon the walker tests in walk.lisp):
> > I reviewed it some. I'm not sure it's a perfect solution, since the
> > PCL approach of embedding everything in a function still seems a
> > little bizarre. I think someday it might be possible to do something
> > more straightforward, given that, unlike PCL, we don't need to be
> > portable across implementations. But it looks to me as though your
> > BOGO-FUNCTION type is distinctly cleaner than what the walker was
> > doing before.
> Yes, perhaps it's not the perfect solution, but it seemed like the best
> solution, if the walker-environment is still stuffing its info into the
> LEXENV structure.
> The approach is somewhat unusual, yes, but if it's done like that,
> SBCL's internals seem just to ignore the bogus-function-information.
> I thought about stuffing the list as-is in the lexenv structure, but
> this would have violated the "assertion" that the elements in the
> :function slot of LEXENV are like (<name> sb-c::macro <macro-function>),
> and so I wasn't sure, whether the compiler would like that.
Yes, any bigger changes would be more complicated. And it's not clear
that it's worth making bigger changes. I'm happy with the changes you
made, since they're an improvement on what was there before. The only
reason I compared them against some ideal, instead of what was there
before, is that I was trying to respond to the way you said
(in a remark not quoted above) that wanted them reviewed.
I wasn't wasn't sure exactly what you were looking for..
a. This code is good, I don't think it will crash.
b. This code is a good example of the kind of fix which I'm likely
to commit routinely.
c. This code is such a beautiful collection of cyberdelights that
it makes women swoon and strong men weep.
(I choose 'b'.:-)
William Harold Newman <william.newman@...>
"The best is the enemy of the good." -- ??
PGP key fingerprint 85 CE 1C BA 79 8D 51 8C B9 25 FB EE E0 C3 E5 7C