Library and GUI for Apple's iPod

I would like to lift this function into the public API as well as submit a
bugfix for properly detecting free space and capacity on gvfs-fuse mounted
devices. Basically the current mechanism of calling statvfs does not work
for devices mounted this way (iphone in ubuntu 10.10 mounts this way). The
reason I would like to lift this function into the public API is so that
other applications depending on libgpod can have a more reliable way of
accessing device capacity and free space that works. Currently gpodder uses
statvfs as well, which leads to it thinking the device has no free space.

Let me know if this seems like I'm heading in the right direction as I'm not
that familiar with libgpod. The patch will essentially forward to a glib
file function that properly handles gvfs-fuse mounted filesystems.

Thanks,
Adam

Re: [Gtkpod-devel] libgpod itdb_device_get_storage_info From: Bastien Nocera <hadess@ha...> - 2011-03-19 18:53 On Sat, 2011-03-19 at 13:24 -0400, Adam Lewis wrote: > I would like to lift this function into the public API as well as > submit a bugfix for properly detecting free space and capacity on > gvfs-fuse mounted devices. Basically the current mechanism of calling > statvfs does not work for devices mounted this way (iphone in ubuntu > 10.10 mounts this way). The reason I would like to lift this function > into the public API is so that other applications depending on libgpod > can have a more reliable way of accessing device capacity and free > space that works. Currently gpodder uses statvfs as well, which leads > to it thinking the device has no free space. > > Let me know if this seems like I'm heading in the right direction as > I'm not that familiar with libgpod. The patch will essentially forward > to a glib file function that properly handles gvfs-fuse mounted > filesystems. Given that libgpod has historically been quite reticent to using gvfs, you might want to look at adding statvfs support to gvfs-fuse instead, which would "fix" support for more than just the AFC backend.

Re: [Gtkpod-devel] libgpod itdb_device_get_storage_info From: Christophe Fergeau <cfergeau@gm...> - 2011-03-19 21:12 2011/3/19 Bastien Nocera <hadess@...>: > Given that libgpod has historically been quite reticent to using gvfs, Actually, Nikias showed me a libgpod-gio patch which seemed far less scary than what I expected, so maybe I'd take a patch doing this if I got my hands on a final version. Christophe

Re: [Gtkpod-devel] libgpod itdb_device_get_storage_info From: Christophe Fergeau <cfergeau@gm...> - 2011-03-19 21:14 2011/3/19 Adam Lewis <adam.j.lewis@...>: > > Let me know if this seems like I'm heading in the right direction as I'm not > that familiar with libgpod. The patch will essentially forward to a glib > file function that properly handles gvfs-fuse mounted filesystems. Do you have a patch to show (even if it's just a preliminary one) or the name of the function you're planning to use? Christophe

Re: [Gtkpod-devel] libgpod itdb_device_get_storage_info From: Adam Lewis <adam.lewis@gm...> - 2011-03-19 21:31 Attachments: Message as HTML      Here is a rough approximation of what the patch would look like: GFile *root; GFileInfo *info; guint64 capacity, free; root = g_file_new_for_path (device->mountpoint); info = g_file_query_filesystem_info (root, "*", NULL, NULL); g_object_unref (G_OBJECT (root)); if (info == NULL) { return 0; } capacity = g_file_info_get_attribute_uint64 (info, G_FILE_ATTRIBUTE_FILESYSTEM_SIZE); free = g_file_info_get_attribute_uint64 (info, G_FILE_ATTRIBUTE_FILESYSTEM_FREE); g_object_unref (G_OBJECT (info)); On Sat, Mar 19, 2011 at 5:14 PM, Christophe Fergeau <cfergeau@...: > 2011/3/19 Adam Lewis <adam.j.lewis@...>: > > > > Let me know if this seems like I'm heading in the right direction as I'm > not > > that familiar with libgpod. The patch will essentially forward to a glib > > file function that properly handles gvfs-fuse mounted filesystems. > > Do you have a patch to show (even if it's just a preliminary one) or > the name of the function you're planning to use? > > Christophe >

Re: [Gtkpod-devel] libgpod itdb_device_get_storage_info From: Christophe Fergeau <cfergeau@gm...> - 2011-03-21 10:00 Attachments: Message as HTML      Hi, On Sat, Mar 19, 2011 at 05:31:38PM -0400, Adam Lewis wrote: > Here is a rough approximation of what the patch would look like: > > GFile *root; > GFileInfo *info; > guint64 capacity, free; > > root = g_file_new_for_path (device->mountpoint); > > info = g_file_query_filesystem_info (root, "*", NULL, NULL); > g_object_unref (G_OBJECT (root)); > if (info == NULL) { > return 0; > } > > capacity = g_file_info_get_attribute_uint64 (info, > G_FILE_ATTRIBUTE_FILESYSTEM_SIZE); > free = g_file_info_get_attribute_uint64 (info, > G_FILE_ATTRIBUTE_FILESYSTEM_FREE); > g_object_unref (G_OBJECT (info)); I tend to think this kind of things should be handled by the application using, it's at the same level as detecting whether a newly plugged device is an iPod and this kind of things. On the other hand, this is at least the 2nd time such an API is requested which means there's a real need for it :) However, if we add this API, we'll probably also want a way to get the space used by music/movies/ebooks/other files. Christophe

2 messages have been excluded from this view by a project administrator.